From: Yixun Lan <dlan@kernel.org>
To: Troy Mitchell <troy.mitchell@linux.spacemit.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Sandie Cao <sandie.cao@deepcomputing.io>,
Conor Dooley <conor+dt@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
spacemit@lists.linux.dev, linux-riscv@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] dts: riscv: spacemit: k3: only keep spacemit,k1-i2c
Date: Mon, 20 Apr 2026 09:09:36 +0000 [thread overview]
Message-ID: <20260420090936-GKB203300@kernel.org> (raw)
In-Reply-To: <DHXUQHVK4XRN.3CVZ3GH75L4L4@linux.spacemit.com>
Hi Troy,
On 16:50 Mon 20 Apr , Troy Mitchell wrote:
> On Mon Apr 20, 2026 at 4:44 PM CST, Krzysztof Kozlowski wrote:
> > On 20/04/2026 10:43, Krzysztof Kozlowski wrote:
> >> On 20/04/2026 10:39, Sandie Cao wrote:
> >>> Fix dtcheck issue: compatible:0: 'spacemit,k1-i2c' was expected
> >>
> >> Missing space after main commit msg.
> >>
> >>> Reported-by: kernel test robot <lkp@intel.com>
> >>> Closes: https://lore.kernel.org/r/202604140259.eKDaxKua-lkp@intel.com/
> >>>
> >
> > Also, the file reported in above warning DOES NOT EXIST (I checked
> > next-20260414).
> In Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml:
>
> properties:
> compatible:
> enum:
> - spacemit,k1-pinctrl
> - spacemit,k3-pinctrl
>
I think you refer to wrong file, which should be
Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml
> So there's no reason to use k1-i2c. As far as I can tell, while they are the same IP,
> there are subtle differences between them.
>
But yes, the idea is correct, so NAK to this patch
> - Troy
--
Yixun Lan (dlan)
WARNING: multiple messages have this Message-ID (diff)
From: Yixun Lan <dlan@kernel.org>
To: Troy Mitchell <troy.mitchell@linux.spacemit.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Sandie Cao <sandie.cao@deepcomputing.io>,
Conor Dooley <conor+dt@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
spacemit@lists.linux.dev, linux-riscv@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] dts: riscv: spacemit: k3: only keep spacemit,k1-i2c
Date: Mon, 20 Apr 2026 09:09:36 +0000 [thread overview]
Message-ID: <20260420090936-GKB203300@kernel.org> (raw)
In-Reply-To: <DHXUQHVK4XRN.3CVZ3GH75L4L4@linux.spacemit.com>
Hi Troy,
On 16:50 Mon 20 Apr , Troy Mitchell wrote:
> On Mon Apr 20, 2026 at 4:44 PM CST, Krzysztof Kozlowski wrote:
> > On 20/04/2026 10:43, Krzysztof Kozlowski wrote:
> >> On 20/04/2026 10:39, Sandie Cao wrote:
> >>> Fix dtcheck issue: compatible:0: 'spacemit,k1-i2c' was expected
> >>
> >> Missing space after main commit msg.
> >>
> >>> Reported-by: kernel test robot <lkp@intel.com>
> >>> Closes: https://lore.kernel.org/r/202604140259.eKDaxKua-lkp@intel.com/
> >>>
> >
> > Also, the file reported in above warning DOES NOT EXIST (I checked
> > next-20260414).
> In Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml:
>
> properties:
> compatible:
> enum:
> - spacemit,k1-pinctrl
> - spacemit,k3-pinctrl
>
I think you refer to wrong file, which should be
Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml
> So there's no reason to use k1-i2c. As far as I can tell, while they are the same IP,
> there are subtle differences between them.
>
But yes, the idea is correct, so NAK to this patch
> - Troy
--
Yixun Lan (dlan)
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2026-04-20 9:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 8:39 [PATCH] dts: riscv: spacemit: k3: only keep spacemit,k1-i2c Sandie Cao
2026-04-20 8:39 ` Sandie Cao
2026-04-20 8:43 ` Krzysztof Kozlowski
2026-04-20 8:43 ` Krzysztof Kozlowski
2026-04-20 8:44 ` Krzysztof Kozlowski
2026-04-20 8:44 ` Krzysztof Kozlowski
2026-04-20 8:50 ` Troy Mitchell
2026-04-20 8:50 ` Troy Mitchell
2026-04-20 9:09 ` Yixun Lan [this message]
2026-04-20 9:09 ` Yixun Lan
2026-04-20 9:26 ` Sandie Cao
2026-04-20 9:26 ` Sandie Cao
2026-04-20 9:35 ` Troy Mitchell
2026-04-20 9:35 ` Troy Mitchell
2026-04-20 10:28 ` Krzysztof Kozlowski
2026-04-20 10:28 ` Krzysztof Kozlowski
2026-04-20 9:27 ` Troy Mitchell
2026-04-20 9:27 ` Troy Mitchell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260420090936-GKB203300@kernel.org \
--to=dlan@kernel.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lkp@intel.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=sandie.cao@deepcomputing.io \
--cc=spacemit@lists.linux.dev \
--cc=troy.mitchell@linux.spacemit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.