[koverstreet-bcachefs:master 74/93] fs/bcachefs/journal/journal.c:633:2-8: preceding lock on line 630

[koverstreet-bcachefs:master 74/93] fs/bcachefs/journal/journal.c:633:2-8: preceding lock on line 630

[kernel test robot]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: Kent Overstreet <kent.overstreet@linux.dev>

tree:   https://github.com/koverstreet/bcachefs master
head:   9921311178817ed16cae0482ce5bfdd27135981a
commit: 2886cbbed99692c196ebb056fe270842e5f784a5 [74/93] bcachefs: journal: add journal_ringbuf, journal_res_data()
:::::: branch date: 5 hours ago
:::::: commit date: 2 days ago
config: sh-randconfig-r063-20260420 (https://download.01.org/0day-ci/archive/20260420/202604201145.W0Mx9JKI-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 12.5.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202604201145.W0Mx9JKI-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> fs/bcachefs/journal/journal.c:633:2-8: preceding lock on line 630

vim +633 fs/bcachefs/journal/journal.c

1c6fdbd8f2465d fs/bcachefs/journal.c         Kent Overstreet 2017-03-16  619  
35282ce9e82f6e fs/bcachefs/journal.c         Kent Overstreet 2025-02-05  620  static void journal_buf_prealloc(struct journal *j)
35282ce9e82f6e fs/bcachefs/journal.c         Kent Overstreet 2025-02-05  621  {
35282ce9e82f6e fs/bcachefs/journal.c         Kent Overstreet 2025-02-05  622  	if (j->free_buf &&
35282ce9e82f6e fs/bcachefs/journal.c         Kent Overstreet 2025-02-05  623  	    j->free_buf_size >= j->buf_size_want)
35282ce9e82f6e fs/bcachefs/journal.c         Kent Overstreet 2025-02-05  624  		return;
35282ce9e82f6e fs/bcachefs/journal.c         Kent Overstreet 2025-02-05  625  
35282ce9e82f6e fs/bcachefs/journal.c         Kent Overstreet 2025-02-05  626  	unsigned buf_size = j->buf_size_want;
35282ce9e82f6e fs/bcachefs/journal.c         Kent Overstreet 2025-02-05  627  
35282ce9e82f6e fs/bcachefs/journal.c         Kent Overstreet 2025-02-05  628  	spin_unlock(&j->lock);
35282ce9e82f6e fs/bcachefs/journal.c         Kent Overstreet 2025-02-05  629  	void *buf = kvmalloc(buf_size, GFP_NOFS);
35282ce9e82f6e fs/bcachefs/journal.c         Kent Overstreet 2025-02-05 @630  	spin_lock(&j->lock);
35282ce9e82f6e fs/bcachefs/journal.c         Kent Overstreet 2025-02-05  631  
2886cbbed99692 fs/bcachefs/journal/journal.c Kent Overstreet 2026-04-17  632  	if (!buf)
2886cbbed99692 fs/bcachefs/journal/journal.c Kent Overstreet 2026-04-17 @633  		return;
2886cbbed99692 fs/bcachefs/journal/journal.c Kent Overstreet 2026-04-17  634  
35282ce9e82f6e fs/bcachefs/journal.c         Kent Overstreet 2025-02-05  635  	swap(buf,	j->free_buf);
35282ce9e82f6e fs/bcachefs/journal.c         Kent Overstreet 2025-02-05  636  	swap(buf_size,	j->free_buf_size);
35282ce9e82f6e fs/bcachefs/journal.c         Kent Overstreet 2025-02-05  637  
35282ce9e82f6e fs/bcachefs/journal.c         Kent Overstreet 2025-02-05  638  	if (unlikely(buf)) {
35282ce9e82f6e fs/bcachefs/journal.c         Kent Overstreet 2025-02-05  639  		spin_unlock(&j->lock);
35282ce9e82f6e fs/bcachefs/journal.c         Kent Overstreet 2025-02-05  640  		/* kvfree can sleep */
35282ce9e82f6e fs/bcachefs/journal.c         Kent Overstreet 2025-02-05  641  		kvfree(buf);
35282ce9e82f6e fs/bcachefs/journal.c         Kent Overstreet 2025-02-05  642  		spin_lock(&j->lock);
35282ce9e82f6e fs/bcachefs/journal.c         Kent Overstreet 2025-02-05  643  	}
35282ce9e82f6e fs/bcachefs/journal.c         Kent Overstreet 2025-02-05  644  }
35282ce9e82f6e fs/bcachefs/journal.c         Kent Overstreet 2025-02-05  645  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki