Re: [PATCH] docs: add guidelines for submitting new filesystems

["Darrick J. Wong" <djwong@kernel.org>]

On Tue, Apr 21, 2026 at 02:08:13PM +0200, Jan Kara wrote:
> On Tue 21-04-26 13:17:34, Amir Goldstein wrote:
> > On Tue, Apr 21, 2026 at 12:16 PM Jan Kara <jack@suse.cz> wrote:
> > > I definitely want to keep a clause like this. Maybe I'd just reformulate it
> > > like:
> > >
> > >   - Handle security issues promptly.  Both those reported by ordinary users
> > >     as well as those reported by fuzzing tools. Expect that your filesystem
> > >     will be subject to syscall fuzzing as well as filesystem image fuzzing.
> > >     Dealing with maliciously corrupted filesystem images is not generally
> > >     considered a high severity security issue but still it is considered a
> > >     quality-of-implementation issue that should be fixed.
> > >
> > 
> > I can take this version, but tbh feels like debating this clause misses
> > the main goal of the doc, so I'd rather go with something a lot shorter:
> > 
> > - Handle security issues and regression promptly.  Both those reported
> >   by ordinary users as well as those reported by test bots.
> > 
> > IMO, getting into more details doesn't really add much value to the
> > prospect reader of the doc before submitting a new filesystem nor to
> > the filesystem reviewer.
> 
> Agreed. Your shorter version conveys the idea and the details aren't that
> useful. So the short version is fine.

I still want

"The filesystem must handle corrupted input gracefully without hanging
or crashing the kernel."

to be part of this.  Not screwing over a running system is important,
The guidelines ought to make that explicit.

--D

> 
> 								Honza
> 
> -- 
> Jan Kara <jack@suse.com>
> SUSE Labs, CR