All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Matthew Wilcox <willy@infradead.org>,
	Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
	Al Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel@vger.kernel.org, Theodore Tso <tytso@mit.edu>,
	Christoph Hellwig <hch@lst.de>,
	"Darrick J. Wong" <djwong@kernel.org>
Subject: Re: [PATCH] docs: add guidelines for submitting new filesystems
Date: Sat, 18 Apr 2026 22:18:56 +0000	[thread overview]
Message-ID: <aeQDUIaxc5qBvLA4@google.com> (raw)
In-Reply-To: <CAOQ4uxhG0wgTAfn-XQz2Kkosh=upeE4x5r_PuYmc_H2X9snogQ@mail.gmail.com>

On 04/18, Amir Goldstein wrote:
> On Fri, Apr 17, 2026 at 7:20 PM Jaegeuk Kim <jaegeuk@kernel.org> wrote:
> >
> > On 04/17, Matthew Wilcox wrote:
> > >
> ...
> > > I kind of want a section on "no weird ioctls".  Anything you want to
> > > implement beyond ioctls already implemented by other filesystems,
> > > you need to bring to linux-fsdevel as a separate proposal from "please
> > > merge my filesystem".  Almost anything implemented by f2fs is a good
> > > example here.
> >
> > I disagree to this. As a filesystem developer, I belive ioctl provides a way
> > to tune the filesystem-specific features which are not supported by all the
> > other filesystems.
> >
> 
> Jaegeuk,
> 
> Note that, despite Matthew's unhidden opinion about "weird ioctls",
> the proposed clause does not say that they are not allowed.
> 
> The section refers to the way to submit a new filesystem for review
> and requests that special ioctls will be clearly submitted separately.
> Here is how I have added it in my work branch:
> 
>  - Structure the submission logically.  It is neither acceptable to send one
>    large patch containing the entire filesystem, nor is a replay of the full
>    development history helpful to reviewers.  Instead, split the series by
>    topic -- for example: superblock and mount handling, inode operations,
>    directory operations, address space operations, and so on -- so that each
>    patch is reviewable in isolation.
> 
>  - Separate any filesystem-specific ioctls into their own patches with
>    dedicated justification.  Interfaces beyond those already common across
>    other filesystems will receive additional scrutiny because they are hard
>    to maintain and may conflict with future generic interfaces.
> 
>  - Expect thorough review.  Filesystem code interacts deeply with the VFS,
>    memory management, and block layers, so reviewers will examine the code
>    carefully.  Address all review feedback and be prepared for multiple
>    revision cycles.

Thanks, those are all reasonable to me, as I did quite similarly in 2012,
https://lwn.net/Articles/518718/.

Some useful tips before submission might be helpful:
1) find a company sponsorship for long-term maintenance support
2) present key differentiating features to filesystem/kernel leads (e.g., Ted)
3) check any patent/copyright violation
4) share the results of xfstests/fsstress/power-off recovery test/code coverage

Thanks,

> 
> Thanks,
> Amir.

  reply	other threads:[~2026-04-18 22:18 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-17 14:25 [PATCH] docs: add guidelines for submitting new filesystems Amir Goldstein
2026-04-17 15:36 ` Matthew Wilcox
2026-04-17 16:44   ` Amir Goldstein
2026-04-17 17:20   ` Jaegeuk Kim
2026-04-18 17:24     ` Amir Goldstein
2026-04-18 22:18       ` Jaegeuk Kim [this message]
2026-04-19 11:06         ` Amir Goldstein
2026-04-18 21:32 ` Matthew Wilcox
2026-04-19 11:03   ` Amir Goldstein
2026-04-20  8:15   ` Jan Kara
2026-04-20  8:32 ` Jan Kara
2026-04-20 18:14   ` Amir Goldstein
2026-04-20 18:34     ` Darrick J. Wong
2026-04-21 10:16     ` Jan Kara
2026-04-21 11:17       ` Amir Goldstein
2026-04-21 12:08         ` Jan Kara
2026-04-21 18:10           ` Darrick J. Wong
2026-04-21 19:42             ` Amir Goldstein
2026-04-21 20:15               ` Darrick J. Wong
2026-04-21 20:22                 ` Amir Goldstein
2026-04-22 14:09                   ` Theodore Tso
2026-04-22 14:35                     ` Amir Goldstein
2026-04-22 15:50                       ` Darrick J. Wong
2026-04-21 11:27 ` Christian Brauner
2026-04-21 11:45   ` Amir Goldstein
2026-04-22  8:50 ` Askar Safin
2026-04-22  9:02   ` Amir Goldstein
2026-04-22 12:35     ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aeQDUIaxc5qBvLA4@google.com \
    --to=jaegeuk@kernel.org \
    --cc=amir73il@gmail.com \
    --cc=brauner@kernel.org \
    --cc=djwong@kernel.org \
    --cc=hch@lst.de \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.