All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michele Bisogno <micbis.openwrt@gmail.com>
To: Marek Vasut <marex@denx.de>, Lukasz Majewski <lukma@denx.de>,
	Mattijs Korpershoek <mkorpershoek@kernel.org>
Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>,
	Tom Rini <trini@konsulko.com>,
	u-boot@lists.denx.de, Michele Bisogno <micbis.openwrt@gmail.com>
Subject: [PATCH v4 1/3] usb: gadget: rcar: Fix gadget registration lifecycle in remove
Date: Wed, 22 Apr 2026 18:59:36 +0200	[thread overview]
Message-ID: <20260422165938.35925-2-micbis.openwrt@gmail.com> (raw)
In-Reply-To: <20260422165938.35925-1-micbis.openwrt@gmail.com>

The driver currently fails to unregister the USB gadget when the
device is removed or the driver is unbound. This leads to dangling
pointers in the UDC core and potential memory corruption.

Add a call to usb_del_gadget_udc() in the remove path to ensure
a clean teardown of the gadget interface.

Signed-off-by: Michele Bisogno <micbis.openwrt@gmail.com>
---
 drivers/usb/gadget/rcar/common.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/usb/gadget/rcar/common.c b/drivers/usb/gadget/rcar/common.c
index 2ba022a3f2c..f7b34f0485f 100644
--- a/drivers/usb/gadget/rcar/common.c
+++ b/drivers/usb/gadget/rcar/common.c
@@ -447,8 +447,12 @@ err_clk:
 static int usbhs_udc_otg_remove(struct udevice *dev)
 {
 	struct usbhs_priv_otg_data *priv = dev_get_priv(dev);
+	struct usb_gadget *gadget;
 
 	usbhs_rcar3_power_ctrl(&priv->usbhs_priv, false);
+	gadget = usbhsg_get_gadget(&priv->usbhs_priv);
+	if (gadget)
+		usb_del_gadget_udc(gadget);
 	usbhs_mod_remove(&priv->usbhs_priv);
 	usbhs_fifo_remove(&priv->usbhs_priv);
 	usbhs_pipe_remove(&priv->usbhs_priv);
-- 
2.34.1


  reply	other threads:[~2026-04-22 20:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-22 16:59 [PATCH v4 0/3] usb: gadget: rcar: Add RZ/G2L support and lifecycle fixes Michele Bisogno
2026-04-22 16:59 ` Michele Bisogno [this message]
     [not found]   ` <edd83758-4f28-425c-b828-fb1e7a885d4d@mailbox.org>
2026-04-23  8:05     ` [PATCH v4 1/3] usb: gadget: rcar: Fix gadget registration lifecycle in remove Michele Bisogno
2026-04-22 16:59 ` [PATCH v4 2/3] usb: gadget: rcar: Add support for reset controller Michele Bisogno
     [not found]   ` <4961ac43-a879-411d-a32e-7fe8d1c879e5@mailbox.org>
2026-04-23  8:14     ` Michele Bisogno
2026-04-22 16:59 ` [PATCH v4 3/3] usb: gadget: rcar: Add support for RZ/G2L (R9A07G044) Michele Bisogno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260422165938.35925-2-micbis.openwrt@gmail.com \
    --to=micbis.openwrt@gmail.com \
    --cc=iwamatsu@nigauri.org \
    --cc=lukma@denx.de \
    --cc=marex@denx.de \
    --cc=mkorpershoek@kernel.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.