From: Eric Biggers <ebiggers@kernel.org>
To: Andrey Albershteyn <aalbersh@redhat.com>
Cc: Andrey Albershteyn <aalbersh@kernel.org>,
linux-xfs@vger.kernel.org, fsverity@lists.linux.dev,
linux-fsdevel@vger.kernel.org, hch@lst.de,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-btrfs@vger.kernel.org, linux-unionfs@vger.kernel.org,
djwong@kernel.org, Amir Goldstein <amir73il@gmail.com>
Subject: Re: [PATCH v8 03/22] ovl: use core fsverity ensure info interface
Date: Wed, 22 Apr 2026 15:46:04 -0700 [thread overview]
Message-ID: <20260422224604.GA2226@sol> (raw)
In-Reply-To: <gpmgtg2wkoo4vozzaaouhdp2df6zlifwi6gy4jvq7xc22zo7om@t3f2bl374nlr>
On Wed, Apr 22, 2026 at 11:59:11AM +0200, Andrey Albershteyn wrote:
> > The 'if (!fsverity_active(inode) && IS_VERITY(inode)) {' condition
> > should stay
>
> Why? With recent changes, the fsverity_active() now checks for
> IS_VERITY() instead of verity_descriptor.
>
Okay, I forgot that that had changed. Looks like the kerneldoc never
got updated, though. It still says "This checks whether the inode's
verity info has been set."
- Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Andrey Albershteyn <aalbersh@redhat.com>
Cc: fsverity@lists.linux.dev,
Andrey Albershteyn <aalbersh@kernel.org>,
djwong@kernel.org, Amir Goldstein <amir73il@gmail.com>,
linux-unionfs@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org, hch@lst.de,
linux-btrfs@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH v8 03/22] ovl: use core fsverity ensure info interface
Date: Wed, 22 Apr 2026 15:46:04 -0700 [thread overview]
Message-ID: <20260422224604.GA2226@sol> (raw)
In-Reply-To: <gpmgtg2wkoo4vozzaaouhdp2df6zlifwi6gy4jvq7xc22zo7om@t3f2bl374nlr>
On Wed, Apr 22, 2026 at 11:59:11AM +0200, Andrey Albershteyn wrote:
> > The 'if (!fsverity_active(inode) && IS_VERITY(inode)) {' condition
> > should stay
>
> Why? With recent changes, the fsverity_active() now checks for
> IS_VERITY() instead of verity_descriptor.
>
Okay, I forgot that that had changed. Looks like the kerneldoc never
got updated, though. It still says "This checks whether the inode's
verity info has been set."
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2026-04-22 22:47 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 11:46 [PATCH v8 00/22] fs-verity support for XFS with post EOF merkle tree Andrey Albershteyn
2026-04-20 11:46 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-04-20 11:46 ` [PATCH v8 01/22] fsverity: report validation errors through fserror to fsnotify Andrey Albershteyn
2026-04-20 11:46 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-04-20 11:46 ` [PATCH v8 02/22] fsverity: expose ensure_fsverity_info() Andrey Albershteyn
2026-04-20 11:46 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-04-20 11:46 ` [PATCH v8 03/22] ovl: use core fsverity ensure info interface Andrey Albershteyn
2026-04-20 11:46 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-04-21 21:44 ` Eric Biggers
2026-04-21 21:44 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2026-04-22 9:59 ` Andrey Albershteyn
2026-04-22 9:59 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-04-22 22:46 ` Eric Biggers [this message]
2026-04-22 22:46 ` Eric Biggers via Linux-f2fs-devel
2026-04-20 11:46 ` [PATCH v8 04/22] fsverity: generate and store zero-block hash Andrey Albershteyn
2026-04-20 11:46 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-04-21 21:47 ` Eric Biggers
2026-04-21 21:47 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2026-04-20 11:46 ` [PATCH v8 05/22] fsverity: pass digest size and hash of the all-zeroes block to ->write Andrey Albershteyn
2026-04-20 11:46 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-04-20 11:46 ` [PATCH v8 06/22] fsverity: hoist pagecache_read from f2fs/ext4 to fsverity Andrey Albershteyn
2026-04-20 11:46 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-04-20 11:46 ` [PATCH v8 07/22] iomap: introduce IOMAP_F_FSVERITY and teach writeback to handle fsverity Andrey Albershteyn
2026-04-20 11:46 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-04-20 11:46 ` [PATCH v8 08/22] iomap: teach iomap to read files with fsverity Andrey Albershteyn
2026-04-20 11:46 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-04-20 11:46 ` [PATCH v8 09/22] iomap: introduce iomap_fsverity_write() for writing fsverity metadata Andrey Albershteyn
2026-04-20 11:46 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-04-20 11:46 ` [PATCH v8 10/22] xfs: introduce fsverity on-disk changes Andrey Albershteyn
2026-04-20 11:46 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-04-20 11:46 ` [PATCH v8 11/22] xfs: initialize fs-verity on file open Andrey Albershteyn
2026-04-20 11:46 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-04-20 11:46 ` [PATCH v8 12/22] xfs: don't allow to enable DAX on fs-verity sealed inode Andrey Albershteyn
2026-04-20 11:46 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-04-20 11:47 ` [PATCH v8 13/22] xfs: disable direct read path for fs-verity files Andrey Albershteyn
2026-04-20 11:47 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-04-20 11:47 ` [PATCH v8 14/22] xfs: handle fsverity I/O in write/read path Andrey Albershteyn
2026-04-20 11:47 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-04-20 11:47 ` [PATCH v8 15/22] xfs: use read ioend for fsverity data verification Andrey Albershteyn
2026-04-20 11:47 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-04-20 11:47 ` [PATCH v8 16/22] xfs: add fs-verity support Andrey Albershteyn
2026-04-20 11:47 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-04-20 11:47 ` [PATCH v8 17/22] xfs: remove unwritten extents after preallocations in fsverity metadata Andrey Albershteyn
2026-04-20 11:47 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-04-20 11:47 ` [PATCH v8 18/22] xfs: add fs-verity ioctls Andrey Albershteyn
2026-04-20 11:47 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-04-20 11:47 ` [PATCH v8 19/22] xfs: advertise fs-verity being available on filesystem Andrey Albershteyn
2026-04-20 11:47 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-04-20 11:47 ` [PATCH v8 20/22] xfs: check and repair the verity inode flag state Andrey Albershteyn
2026-04-20 11:47 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-04-20 11:47 ` [PATCH v8 21/22] xfs: introduce health state for corrupted fsverity metadata Andrey Albershteyn
2026-04-20 11:47 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-04-20 11:47 ` [PATCH v8 22/22] xfs: enable ro-compat fs-verity flag Andrey Albershteyn
2026-04-20 11:47 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-04-21 21:43 ` [PATCH v8 00/22] fs-verity support for XFS with post EOF merkle tree Eric Biggers
2026-04-21 21:43 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2026-04-22 8:58 ` Andrey Albershteyn
2026-04-22 8:58 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260422224604.GA2226@sol \
--to=ebiggers@kernel.org \
--cc=aalbersh@kernel.org \
--cc=aalbersh@redhat.com \
--cc=amir73il@gmail.com \
--cc=djwong@kernel.org \
--cc=fsverity@lists.linux.dev \
--cc=hch@lst.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.