Re: [PATCH v4 0/3] hvf: map granule abstraction, configurable IPA, and MAP_FIXED alignment fix

[Lucas Amaral <lucaaamaral@gmail.com>]

Hi Peter,

Thanks for the review and for asking Mohamed and Alex to take a look.

> The question that comes to my mind is whether the two places changed
> in accel/hvf to look at hvf_get_map_granule() really are the only
> two places in the whole of QEMU where we call
> qemu_real_host_page_size() and expect it to be also the guest page
> size. The general idea of 'guest page size might not be the same as
> the host page size QEMU itself gets' isn't hvf specific -- maybe we
> should have a qemu_guest_page_size() function?

Good point. I'll audit the qemu_real_host_page_size() call sites to
see which ones actually mean "guest page size" and whether a broader
qemu_guest_page_size() abstraction makes sense. I'd send that as a
follow-up series once these patches land, so the immediate HVF fix
isn't blocked on the broader refactor.

Thanks,
Lucas