All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas Amaral <lucaaamaral@gmail.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Mohamed Mediouni" <mohamed@unpredictable.fr>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Alexander Graf" <agraf@csgraf.de>
Subject: Re: [PATCH v4 1/3] virtio-gpu: validate host page alignment for MAP_FIXED blobs
Date: Fri, 24 Apr 2026 18:37:38 -0300	[thread overview]
Message-ID: <20260424213738.45385-1-lucaaamaral@gmail.com> (raw)
In-Reply-To: <875x5gwtxx.fsf@draig.linaro.org>

On 2026-04-24, Alex Bennée wrote:
> Well we at least images for the Linux side which we can use. See
> tests/functional/aarch64/test_virt_gpu.py

Good pointer — that infrastructure should work. My local reproduction
is even simpler: a plain Ubuntu 24.04 ARM64 image, unmodified, with
stock Mesa. The failure surfaces immediately on:

  sudo vulkaninfo --summary
  sudo run_wayland timeout 120 vkmark

Without patch 1/3, virgl_renderer_resource_map_fixed() returns EINVAL
on the first 4KB-aligned blob and the guest renderer falls over.

> I wonder if TCG guests will also fail?

Yes — the MAP_FIXED requirement is a host kernel mmap() constraint,
not an accelerator one. The patch 1/3 guard sits in the
accelerator-agnostic path and protects all configurations, including
TCG.

> A lot of moving parts, do you have a rolled up branch I can test
> against?
> Any rolled up branch for this set as well?

Easier than a rolled-up branch — the three QEMU series apply cleanly
on current master in any order:

  Stack A (ISV=0 emulation):
    https://patchew.org/QEMU/20260409220614.65558-1-lucaaamaral@gmail.com/
  Stack B (this series):
    https://patchew.org/QEMU/20260424000544.9617-1-lucaaamaral@gmail.com/
  Stack C (Venus without OpenGL):
    https://patchew.org/QEMU/20260317182049.33848-1-lucaaamaral@gmail.com/

Renderer side just needs current virglrenderer main — the last macOS
Metal/Vulkan MR landed yesterday.

> This is a bit of a challenge - we will be loosing CirrusCI soon
> which has our only real MacOS build test. Either we get someone
> willing to host a custom runner or we need to find another CI
> runner that we can plug MacOS tests into.

Acknowledged — separate infrastructure problem, but I'm happy to
share my macOS test scripts/workflow if useful, and can ack-test
macOS-specific patches locally on Apple Silicon when asked.

Thanks,
Lucas


  reply	other threads:[~2026-04-24 21:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-17 17:57 [PATCH v4 0/3] hvf: map granule abstraction, configurable IPA, and MAP_FIXED alignment fix Lucas Amaral
2026-03-17 17:57 ` [PATCH v4 1/3] virtio-gpu: validate host page alignment for MAP_FIXED blobs Lucas Amaral
2026-04-23 18:00   ` Alex Bennée
2026-04-23 23:44     ` Lucas Amaral
2026-04-24 10:09       ` Alex Bennée
2026-04-24 21:37         ` Lucas Amaral [this message]
2026-03-17 17:57 ` [PATCH v4 2/3] accel/hvf: introduce map granule abstraction and IPA property Lucas Amaral
2026-04-23 18:05   ` Alex Bennée
2026-04-23 23:44     ` Lucas Amaral
2026-03-17 17:57 ` [PATCH v4 3/3] target/arm/hvf: configure IPA granule on macOS 26 Lucas Amaral
2026-04-09 17:52 ` [PATCH v4 0/3] hvf: map granule abstraction, configurable IPA, and MAP_FIXED alignment fix Lucas Amaral
2026-04-09 19:06   ` Peter Maydell
2026-04-10 14:13     ` Peter Maydell
2026-04-23 17:22       ` Lucas Amaral
2026-04-24  7:08         ` Philippe Mathieu-Daudé
2026-04-24 21:38           ` Lucas Amaral
  -- strict thread matches above, loose matches on Subject: below --
2026-03-17 17:48 Lucas Amaral
2026-03-17 17:48 ` [PATCH v4 1/3] virtio-gpu: validate host page alignment for MAP_FIXED blobs Lucas Amaral

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260424213738.45385-1-lucaaamaral@gmail.com \
    --to=lucaaamaral@gmail.com \
    --cc=agraf@csgraf.de \
    --cc=alex.bennee@linaro.org \
    --cc=mohamed@unpredictable.fr \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.