From: Simon Horman <horms@kernel.org>
To: Corinna Vinschen <vinschen@redhat.com>
Cc: intel-wired-lan@osuosl.org, stable@vger.kernel.org,
Jose Ignacio Tornos Martinez <jtornosm@redhat.com>,
netdev@vger.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH net] iavf: iavf_virtchnl_completion: drop duplicate ether_addr_equal() test
Date: Thu, 23 Apr 2026 19:55:30 +0100 [thread overview]
Message-ID: <20260423185530.GI900403@horms.kernel.org> (raw)
In-Reply-To: <20260421111236.875379-1-vinschen@redhat.com>
On Tue, Apr 21, 2026 at 01:12:36PM +0200, Corinna Vinschen wrote:
> This is just a simple cleanup fix. Commit 35a2443d0910f ("iavf: Add
> waiting for response from PF in set mac") introduced a duplicate
> ether_addr_equal() check, so the current code tests the new MAC twice
> against the former MAC.
>
> Remove the outer ether_addr_equal() test, remnant of commit c5c922b3e09b
> ("iavf: fix MAC address setting for VFs when filter is rejected")
>
> Signed-off-by: Corinna Vinschen <vinschen@redhat.com>
> Fixes: 35a2443d0910f ("iavf: Add waiting for response from PF in set mac")
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
> ---
> Added CC: stable@vger.kernel.org
Hi,
This feels more like a cleanup for net-next (without a Fixes tag)
than a fix for net. I'm missing where the bug is here.
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Corinna Vinschen <vinschen@redhat.com>
Cc: intel-wired-lan@osuosl.org, netdev@vger.kernel.org,
Jose Ignacio Tornos Martinez <jtornosm@redhat.com>,
Michal Schmidt <mschmidt@redhat.com>,
stable@vger.kernel.org
Subject: Re: [PATCH net] iavf: iavf_virtchnl_completion: drop duplicate ether_addr_equal() test
Date: Thu, 23 Apr 2026 19:55:30 +0100 [thread overview]
Message-ID: <20260423185530.GI900403@horms.kernel.org> (raw)
In-Reply-To: <20260421111236.875379-1-vinschen@redhat.com>
On Tue, Apr 21, 2026 at 01:12:36PM +0200, Corinna Vinschen wrote:
> This is just a simple cleanup fix. Commit 35a2443d0910f ("iavf: Add
> waiting for response from PF in set mac") introduced a duplicate
> ether_addr_equal() check, so the current code tests the new MAC twice
> against the former MAC.
>
> Remove the outer ether_addr_equal() test, remnant of commit c5c922b3e09b
> ("iavf: fix MAC address setting for VFs when filter is rejected")
>
> Signed-off-by: Corinna Vinschen <vinschen@redhat.com>
> Fixes: 35a2443d0910f ("iavf: Add waiting for response from PF in set mac")
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
> ---
> Added CC: stable@vger.kernel.org
Hi,
This feels more like a cleanup for net-next (without a Fixes tag)
than a fix for net. I'm missing where the bug is here.
next prev parent reply other threads:[~2026-04-23 18:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 9:59 [Intel-wired-lan] [PATCH net] iavf: iavf_virtchnl_completion: drop duplicate ether_addr_equal() test Corinna Vinschen
2026-04-21 9:59 ` Corinna Vinschen
2026-04-21 10:20 ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-04-21 10:20 ` Loktionov, Aleksandr
2026-04-21 11:12 ` Corinna Vinschen
2026-04-21 11:12 ` Corinna Vinschen
2026-04-23 18:55 ` Simon Horman [this message]
2026-04-23 18:55 ` Simon Horman
2026-04-24 8:32 ` [Intel-wired-lan] " Corinna Vinschen
2026-04-25 0:37 ` Jacob Keller
2026-04-27 15:58 ` Corinna Vinschen
2026-05-11 9:41 ` Romanowski, Rafal
2026-05-11 9:41 ` Romanowski, Rafal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260423185530.GI900403@horms.kernel.org \
--to=horms@kernel.org \
--cc=intel-wired-lan@osuosl.org \
--cc=jtornosm@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=vinschen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.