All of lore.kernel.org
 help / color / mirror / Atom feed
* [PULL 0/2] Plugins update for 24/04/2026
@ 2026-04-25  0:31 Pierrick Bouvier
  2026-04-25  0:31 ` [PULL 1/2] contrib/plugins/uftrace_symbols.py: fix symbols reading Pierrick Bouvier
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Pierrick Bouvier @ 2026-04-25  0:31 UTC (permalink / raw)
  To: qemu-devel, peter.maydell, richard.henderson, pbonzini, stefanha
  Cc: pierrick.bouvier

The following changes since commit 4bde339ecb41b16e90810233ba5ee2fa87bd443f:

  Merge tag 'pull-11.1-virtio-gpu-hotfixes-230426-1' of https://gitlab.com/stsquad/qemu into staging (2026-04-23 20:51:57 -0400)

are available in the Git repository at:

  https://gitlab.com/p-b-o/qemu tags/pbouvier/pr/plugins-20260424

for you to fetch changes up to 068076d4dfe29ca71626beaa8840c47c18eeb332:

  contrib/plugins/uftrace_symbols.py: handle missing source line from addr2line (2026-04-24 17:30:50 -0700)

----------------------------------------------------------------
Changes:
- [PATCH v2 0/2] contrib/plugins/uftrace_symbols.py: fix issues to (Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>)
  Link: https://lore.kernel.org/qemu-devel/20260424194451.1439316-1-pierrick.bouvier@oss.qualcomm.com

----------------------------------------------------------------
Pierrick Bouvier (2):
      contrib/plugins/uftrace_symbols.py: fix symbols reading
      contrib/plugins/uftrace_symbols.py: handle missing source line from addr2line

 contrib/plugins/uftrace_symbols.py | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PULL 1/2] contrib/plugins/uftrace_symbols.py: fix symbols reading
  2026-04-25  0:31 [PULL 0/2] Plugins update for 24/04/2026 Pierrick Bouvier
@ 2026-04-25  0:31 ` Pierrick Bouvier
  2026-04-25  0:31 ` [PULL 2/2] contrib/plugins/uftrace_symbols.py: handle missing source line from addr2line Pierrick Bouvier
  2026-04-25 16:59 ` [PULL 0/2] Plugins update for 24/04/2026 Stefan Hajnoczi
  2 siblings, 0 replies; 4+ messages in thread
From: Pierrick Bouvier @ 2026-04-25  0:31 UTC (permalink / raw)
  To: qemu-devel, peter.maydell, richard.henderson, pbonzini, stefanha
  Cc: pierrick.bouvier

When running this on hexagon binary, we observe some undefined symbols
without any address or size.

Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Link: https://lore.kernel.org/qemu-devel/20260424194451.1439316-2-pierrick.bouvier@oss.qualcomm.com
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
---
 contrib/plugins/uftrace_symbols.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/contrib/plugins/uftrace_symbols.py b/contrib/plugins/uftrace_symbols.py
index 02d1221228c..6eb999bca5f 100755
--- a/contrib/plugins/uftrace_symbols.py
+++ b/contrib/plugins/uftrace_symbols.py
@@ -36,8 +36,8 @@ def get_symbols(elf_file):
     out = out.strip().split('\n')
     for line in out:
         info = line.split(' ')
-        if len(info) == 3:
-            # missing size information
+        if len(info) != 4:
+            # missing size/address information
             continue
         addr, size, type, name = info
         # add only symbols from .text section
-- 
2.43.0



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PULL 2/2] contrib/plugins/uftrace_symbols.py: handle missing source line from addr2line
  2026-04-25  0:31 [PULL 0/2] Plugins update for 24/04/2026 Pierrick Bouvier
  2026-04-25  0:31 ` [PULL 1/2] contrib/plugins/uftrace_symbols.py: fix symbols reading Pierrick Bouvier
@ 2026-04-25  0:31 ` Pierrick Bouvier
  2026-04-25 16:59 ` [PULL 0/2] Plugins update for 24/04/2026 Stefan Hajnoczi
  2 siblings, 0 replies; 4+ messages in thread
From: Pierrick Bouvier @ 2026-04-25  0:31 UTC (permalink / raw)
  To: qemu-devel, peter.maydell, richard.henderson, pbonzini, stefanha
  Cc: pierrick.bouvier

Some symbols have only a file information, and no line information. In
this case, addr2line reports '?'. Replace with 0 to guarantee consistent
data for consumers.

Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Link: https://lore.kernel.org/qemu-devel/20260424194451.1439316-3-pierrick.bouvier@oss.qualcomm.com
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
---
 contrib/plugins/uftrace_symbols.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/contrib/plugins/uftrace_symbols.py b/contrib/plugins/uftrace_symbols.py
index 6eb999bca5f..9f0095e73b9 100755
--- a/contrib/plugins/uftrace_symbols.py
+++ b/contrib/plugins/uftrace_symbols.py
@@ -70,7 +70,10 @@ def find_symbols_locations(elf_file, symbols):
         file, line = out[i].split(':')
         # addr2line may return 'line (discriminator [0-9]+)' sometimes,
         # remove this to keep only line number.
-        line = line.split(' ')[0]
+        if line == '?':
+            line = 0
+        else:
+            line = int(line.split(' ')[0])
         s.set_loc(file, line)
 
 class BinaryFile:
-- 
2.43.0



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PULL 0/2] Plugins update for 24/04/2026
  2026-04-25  0:31 [PULL 0/2] Plugins update for 24/04/2026 Pierrick Bouvier
  2026-04-25  0:31 ` [PULL 1/2] contrib/plugins/uftrace_symbols.py: fix symbols reading Pierrick Bouvier
  2026-04-25  0:31 ` [PULL 2/2] contrib/plugins/uftrace_symbols.py: handle missing source line from addr2line Pierrick Bouvier
@ 2026-04-25 16:59 ` Stefan Hajnoczi
  2 siblings, 0 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2026-04-25 16:59 UTC (permalink / raw)
  To: Pierrick Bouvier
  Cc: qemu-devel, peter.maydell, richard.henderson, pbonzini, stefanha,
	pierrick.bouvier

[-- Attachment #1: Type: text/plain, Size: 116 bytes --]

Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/11.1 for any user-visible changes.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-04-25 20:00 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-25  0:31 [PULL 0/2] Plugins update for 24/04/2026 Pierrick Bouvier
2026-04-25  0:31 ` [PULL 1/2] contrib/plugins/uftrace_symbols.py: fix symbols reading Pierrick Bouvier
2026-04-25  0:31 ` [PULL 2/2] contrib/plugins/uftrace_symbols.py: handle missing source line from addr2line Pierrick Bouvier
2026-04-25 16:59 ` [PULL 0/2] Plugins update for 24/04/2026 Stefan Hajnoczi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.