From: Sanjay Chitroda <sanjayembeddedse@gmail.com>
To: jic23@kernel.org
Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
sanjayembeddedse@gmail.com, mingo@kernel.org,
christophe.jaillet@wanadoo.fr, nabijaczleweli@nabijaczleweli.xyz,
kees@kernel.org, kyungmin.park@samsung.com, k.wrona@samsung.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v7 4/9] iio: ssp_sensors: factor out mcu enable/disable helper(s)
Date: Sun, 26 Apr 2026 14:47:05 +0530 [thread overview]
Message-ID: <20260426091710.3722035-5-sanjayembedded@gmail.com> (raw)
In-Reply-To: <20260426091710.3722035-1-sanjayembedded@gmail.com>
From: Sanjay Chitroda <sanjayembeddedse@gmail.com>
Re-factor the enable and disable MCU logic into small helper functions
this simplify transfer flow to follow.
No functional change intended.
Signed-off-by: Sanjay Chitroda <sanjayembeddedse@gmail.com>
---
drivers/iio/common/ssp_sensors/ssp_dev.c | 18 ++++++++++++++----
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/common/ssp_sensors/ssp_dev.c b/drivers/iio/common/ssp_sensors/ssp_dev.c
index 51730dae5871..9b8642193176 100644
--- a/drivers/iio/common/ssp_sensors/ssp_dev.c
+++ b/drivers/iio/common/ssp_sensors/ssp_dev.c
@@ -89,7 +89,7 @@ static void ssp_sync_available_sensors(struct ssp_data *data)
"SSP_MSG2SSP_AP_MCU_SET_DUMPMODE failed\n");
}
-static void ssp_enable_mcu(struct ssp_data *data, bool enable)
+static void ssp_set_mcu(struct ssp_data *data, bool enable)
{
dev_info(&data->spi->dev, "current shutdown = %d, old = %d\n", enable,
data->shut_down);
@@ -108,6 +108,16 @@ static void ssp_enable_mcu(struct ssp_data *data, bool enable)
}
}
+static inline void ssp_enable_mcu(struct ssp_data *data)
+{
+ ssp_set_mcu(data, true);
+}
+
+static inline void ssp_disable_mcu(struct ssp_data *data)
+{
+ ssp_set_mcu(data, false);
+}
+
/*
* This function is the first one which communicates with the mcu so it is
* possible that the first attempt will fail
@@ -146,10 +156,10 @@ static int ssp_check_fwbl(struct ssp_data *data)
static void ssp_reset_mcu(struct ssp_data *data)
{
- ssp_enable_mcu(data, false);
+ ssp_disable_mcu(data);
ssp_clean_pending_list(data);
ssp_toggle_mcu_reset_gpio(data);
- ssp_enable_mcu(data, true);
+ ssp_enable_mcu(data);
}
static void ssp_wdt_work_func(struct work_struct *work)
@@ -584,7 +594,7 @@ static void ssp_remove(struct spi_device *spi)
dev_err(&data->spi->dev,
"SSP_MSG2SSP_AP_STATUS_SHUTDOWN failed\n");
- ssp_enable_mcu(data, false);
+ ssp_disable_mcu(data);
ssp_disable_wdt_timer(data);
ssp_clean_pending_list(data);
--
2.34.1
next prev parent reply other threads:[~2026-04-26 9:17 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-26 9:17 [PATCH v7 0/9] iio: ssp_sensors: improve resource cleanup Sanjay Chitroda
2026-04-26 9:17 ` [PATCH v7 1/9] iio: ssp_sensors: cleanup codestyle warning Sanjay Chitroda
2026-04-26 13:53 ` Jonathan Cameron
2026-04-29 18:12 ` Sanjay Chitroda
2026-04-26 9:17 ` [PATCH v7 2/9] iio: ssp_sensors: factor out pending list add/remove helper(s) Sanjay Chitroda
2026-04-26 14:08 ` Jonathan Cameron
2026-04-27 8:05 ` Andy Shevchenko
2026-05-03 11:23 ` Sanjay Chitroda
2026-05-05 16:38 ` Jonathan Cameron
2026-05-06 7:37 ` Andy Shevchenko
2026-05-06 14:37 ` Jonathan Cameron
2026-04-26 9:17 ` [PATCH v7 3/9] iio: ssp_sensors: cancel delayed work_refresh on remove Sanjay Chitroda
2026-04-26 14:09 ` Jonathan Cameron
2026-04-29 18:06 ` Sanjay Chitroda
2026-04-29 18:09 ` Jonathan Cameron
2026-04-26 9:17 ` Sanjay Chitroda [this message]
2026-04-26 14:13 ` [PATCH v7 4/9] iio: ssp_sensors: factor out mcu enable/disable helper(s) Jonathan Cameron
2026-04-26 9:17 ` [PATCH v7 5/9] iio: ssp_sensors: use local struct device Sanjay Chitroda
2026-04-26 14:16 ` Jonathan Cameron
2026-04-27 8:09 ` Andy Shevchenko
2026-05-03 12:06 ` Sanjay Chitroda
2026-04-26 9:17 ` [PATCH v7 6/9] iio: ssp_sensors: Drop duplicated wdt timer and work cleanup Sanjay Chitroda
2026-04-27 8:17 ` Andy Shevchenko
2026-05-03 13:06 ` Sanjay Chitroda
2026-04-26 9:17 ` [PATCH v7 7/9] iio: ssp_sensors: convert probe and teardown to devm-managed resources Sanjay Chitroda
2026-04-26 9:17 ` [PATCH v7 8/9] iio: ssp_sensors: Use dev_err_probe Sanjay Chitroda
2026-04-26 14:24 ` Jonathan Cameron
2026-04-27 8:20 ` Andy Shevchenko
2026-04-27 8:19 ` Andy Shevchenko
2026-04-26 9:17 ` [PATCH v7 9/9] iio: ssp_sensors: reuse embedded RX buffer for SPI transfers Sanjay Chitroda
2026-04-26 14:31 ` Jonathan Cameron
2026-05-03 15:02 ` Sanjay Chitroda
2026-04-26 14:35 ` Jonathan Cameron
2026-05-03 14:17 ` Sanjay Chitroda
2026-05-04 8:41 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260426091710.3722035-5-sanjayembedded@gmail.com \
--to=sanjayembeddedse@gmail.com \
--cc=andy@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=k.wrona@samsung.com \
--cc=kees@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nabijaczleweli@nabijaczleweli.xyz \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.