From: Sanjay Chitroda <sanjayembeddedse@gmail.com>
To: jic23@kernel.org
Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
sanjayembeddedse@gmail.com, mingo@kernel.org,
christophe.jaillet@wanadoo.fr, nabijaczleweli@nabijaczleweli.xyz,
kees@kernel.org, kyungmin.park@samsung.com, k.wrona@samsung.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v7 5/9] iio: ssp_sensors: use local struct device
Date: Sun, 26 Apr 2026 14:47:06 +0530 [thread overview]
Message-ID: <20260426091710.3722035-6-sanjayembedded@gmail.com> (raw)
In-Reply-To: <20260426091710.3722035-1-sanjayembedded@gmail.com>
From: Sanjay Chitroda <sanjayembeddedse@gmail.com>
Introduce a struct device *dev derived from &spi->dev to improve
readability and reorder variable(s) to follow reversed xmas tree style.
Signed-off-by: Sanjay Chitroda <sanjayembeddedse@gmail.com>
---
drivers/iio/common/ssp_sensors/ssp_dev.c | 23 ++++++++++++-----------
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/drivers/iio/common/ssp_sensors/ssp_dev.c b/drivers/iio/common/ssp_sensors/ssp_dev.c
index 9b8642193176..fa47282b39c0 100644
--- a/drivers/iio/common/ssp_sensors/ssp_dev.c
+++ b/drivers/iio/common/ssp_sensors/ssp_dev.c
@@ -492,27 +492,28 @@ EXPORT_SYMBOL_NS(ssp_register_consumer, "IIO_SSP_SENSORS");
static int ssp_probe(struct spi_device *spi)
{
- int ret, i;
+ struct device *dev = &spi->dev;
struct ssp_data *data;
+ int ret, i;
- data = ssp_parse_dt(&spi->dev);
+ data = ssp_parse_dt(dev);
if (!data) {
- dev_err(&spi->dev, "Failed to find platform data\n");
+ dev_err(dev, "Failed to find platform data\n");
return -ENODEV;
}
- ret = mfd_add_devices(&spi->dev, PLATFORM_DEVID_NONE,
+ ret = mfd_add_devices(dev, PLATFORM_DEVID_NONE,
sensorhub_sensor_devs,
ARRAY_SIZE(sensorhub_sensor_devs), NULL, 0, NULL);
if (ret < 0) {
- dev_err(&spi->dev, "mfd add devices fail\n");
+ dev_err(dev, "mfd add devices fail\n");
return ret;
}
spi->mode = SPI_MODE_1;
ret = spi_setup(spi);
if (ret < 0) {
- dev_err(&spi->dev, "Failed to setup spi\n");
+ dev_err(dev, "Failed to setup spi\n");
goto err_setup_spi;
}
@@ -548,7 +549,7 @@ static int ssp_probe(struct spi_device *spi)
IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
"SSP_Int", data);
if (ret < 0) {
- dev_err(&spi->dev, "Irq request fail\n");
+ dev_err(dev, "Irq request fail\n");
goto err_setup_irq;
}
@@ -562,11 +563,11 @@ static int ssp_probe(struct spi_device *spi)
if (data->fw_dl_state == SSP_FW_DL_STATE_NONE) {
ret = ssp_initialize_mcu(data);
if (ret < 0) {
- dev_err(&spi->dev, "Initialize_mcu failed\n");
+ dev_err(dev, "Initialize_mcu failed\n");
goto err_read_reg;
}
} else {
- dev_err(&spi->dev, "Firmware version not supported\n");
+ dev_err(dev, "Firmware version not supported\n");
ret = -EPERM;
goto err_read_reg;
}
@@ -579,9 +580,9 @@ static int ssp_probe(struct spi_device *spi)
mutex_destroy(&data->pending_lock);
mutex_destroy(&data->comm_lock);
err_setup_spi:
- mfd_remove_devices(&spi->dev);
+ mfd_remove_devices(dev);
- dev_err(&spi->dev, "Probe failed!\n");
+ dev_err(dev, "Probe failed!\n");
return ret;
}
--
2.34.1
next prev parent reply other threads:[~2026-04-26 9:17 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-26 9:17 [PATCH v7 0/9] iio: ssp_sensors: improve resource cleanup Sanjay Chitroda
2026-04-26 9:17 ` [PATCH v7 1/9] iio: ssp_sensors: cleanup codestyle warning Sanjay Chitroda
2026-04-26 13:53 ` Jonathan Cameron
2026-04-29 18:12 ` Sanjay Chitroda
2026-04-26 9:17 ` [PATCH v7 2/9] iio: ssp_sensors: factor out pending list add/remove helper(s) Sanjay Chitroda
2026-04-26 14:08 ` Jonathan Cameron
2026-04-27 8:05 ` Andy Shevchenko
2026-05-03 11:23 ` Sanjay Chitroda
2026-05-05 16:38 ` Jonathan Cameron
2026-05-06 7:37 ` Andy Shevchenko
2026-05-06 14:37 ` Jonathan Cameron
2026-04-26 9:17 ` [PATCH v7 3/9] iio: ssp_sensors: cancel delayed work_refresh on remove Sanjay Chitroda
2026-04-26 14:09 ` Jonathan Cameron
2026-04-29 18:06 ` Sanjay Chitroda
2026-04-29 18:09 ` Jonathan Cameron
2026-04-26 9:17 ` [PATCH v7 4/9] iio: ssp_sensors: factor out mcu enable/disable helper(s) Sanjay Chitroda
2026-04-26 14:13 ` Jonathan Cameron
2026-04-26 9:17 ` Sanjay Chitroda [this message]
2026-04-26 14:16 ` [PATCH v7 5/9] iio: ssp_sensors: use local struct device Jonathan Cameron
2026-04-27 8:09 ` Andy Shevchenko
2026-05-03 12:06 ` Sanjay Chitroda
2026-04-26 9:17 ` [PATCH v7 6/9] iio: ssp_sensors: Drop duplicated wdt timer and work cleanup Sanjay Chitroda
2026-04-27 8:17 ` Andy Shevchenko
2026-05-03 13:06 ` Sanjay Chitroda
2026-04-26 9:17 ` [PATCH v7 7/9] iio: ssp_sensors: convert probe and teardown to devm-managed resources Sanjay Chitroda
2026-04-26 9:17 ` [PATCH v7 8/9] iio: ssp_sensors: Use dev_err_probe Sanjay Chitroda
2026-04-26 14:24 ` Jonathan Cameron
2026-04-27 8:20 ` Andy Shevchenko
2026-04-27 8:19 ` Andy Shevchenko
2026-04-26 9:17 ` [PATCH v7 9/9] iio: ssp_sensors: reuse embedded RX buffer for SPI transfers Sanjay Chitroda
2026-04-26 14:31 ` Jonathan Cameron
2026-05-03 15:02 ` Sanjay Chitroda
2026-04-26 14:35 ` Jonathan Cameron
2026-05-03 14:17 ` Sanjay Chitroda
2026-05-04 8:41 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260426091710.3722035-6-sanjayembedded@gmail.com \
--to=sanjayembeddedse@gmail.com \
--cc=andy@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=k.wrona@samsung.com \
--cc=kees@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nabijaczleweli@nabijaczleweli.xyz \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.