All of lore.kernel.org
 help / color / mirror / Atom feed
From: Abhinav Mahadevan <abhi220204@gmail.com>
To: tiwai@suse.com
Cc: perex@perex.cz, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Abhinav Mahadevan <abhi220204@gmail.com>
Subject: [PATCH v4] ALSA: usb-audio: Fix quirk entry placement for PreSonus AudioBox USB
Date: Tue, 28 Apr 2026 21:20:00 +0530	[thread overview]
Message-ID: <20260428155117.5170-1-abhi220204@gmail.com> (raw)
In-Reply-To: <20260410143335.5974-1-abhi220204@gmail.com>

The quirk entry for PreSonus AudioBox USB was mistakenly placed inside
a disabled #if 0 block. Move it to the correct position after the

Fixes: 34fe4a9df247 ("ALSA: usb-audio: Add quirk for PreSonus AudioBox USB")
Signed-off-by: Abhinav Mahadevan <abhi220204@gmail.com>
---

v4: Use correct upstream commit hash in Fixes tag (12 characters).
Rewrite patch description to accurately describe this patch  - correcting 
the position of the entry from inside a disabled #if 0 block to after the 
#endif /* disabled */.

 sound/usb/quirks-table.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h
index 803e03d4d..4e9cfff40 100644
--- a/sound/usb/quirks-table.h
+++ b/sound/usb/quirks-table.h
@@ -2652,6 +2652,9 @@ YAMAHA_DEVICE(0x7010, "UB99"),
 		}
 	}
 },
+
+#endif /* disabled */
+
 {
 	/*
 	 * The AudioBox USB advertises S24_3LE as the only supported format
@@ -2700,7 +2703,6 @@ YAMAHA_DEVICE(0x7010, "UB99"),
 		}
 	}
 },
-#endif /* disabled */
 
 {
 	/*
-- 
2.43.0


  parent reply	other threads:[~2026-04-28 15:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-10 14:33 [PATCH] ALSA: usb-audio: Add quirk for PreSonus AudioBox USB Abhinav Mahadevan
2026-04-10 15:06 ` Takashi Iwai
2026-04-28  0:51 ` [PATCH v2] " Abhinav Mahadevan
2026-04-28  6:04   ` Takashi Iwai
2026-04-28 14:33 ` [PATCH v3] " Abhinav Mahadevan
2026-04-28 14:44   ` Takashi Iwai
2026-04-28 15:50 ` Abhinav Mahadevan [this message]
2026-04-29  5:48   ` [PATCH v4] ALSA: usb-audio: Fix quirk entry placement " Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260428155117.5170-1-abhi220204@gmail.com \
    --to=abhi220204@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.