From: Takashi Iwai <tiwai@suse.de>
To: Abhinav Mahadevan <abhi220204@gmail.com>
Cc: tiwai@suse.com, perex@perex.cz, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] ALSA: usb-audio: Add quirk for PreSonus AudioBox USB
Date: Tue, 28 Apr 2026 16:44:27 +0200 [thread overview]
Message-ID: <87bjf3du0k.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260428143527.5453-1-abhi220204@gmail.com>
On Tue, 28 Apr 2026 16:33:38 +0200,
Abhinav Mahadevan wrote:
>
> The PreSonus AudioBox USB (0x194f:0x0301) only advertises S24_3LE
> for both playback and capture interfaces. Add an explicit entry to
> the quirks table to ensure correct format handling for this device.
>
> Fixes: 099cce2b5 ("ALSA: usb-audio: Add quirk for PreSonus AudioBox USB")
Non-existing commit ID for the upstream.
And, you'll have to put 12 letters SHA id here.
> Signed-off-by: Abhinav Mahadevan <abhi220204@gmail.com>
> ---
>
> v3: Update patch description to accurately reflect the change
> (adding a quirks table entry, not fixing format negotiation).
... and it's not exactly what *this* patch does!
You don't have to repeat the same text you already gave in the
original commit at all.
Basically this patch *corrects* the position of the quirk entry that
was mistakenly put into the disabled block in the previous commit.
Please resubmit with a proper patch description and Fixes tag again.
thanks,
Takashi
next prev parent reply other threads:[~2026-04-28 14:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-10 14:33 [PATCH] ALSA: usb-audio: Add quirk for PreSonus AudioBox USB Abhinav Mahadevan
2026-04-10 15:06 ` Takashi Iwai
2026-04-28 0:51 ` [PATCH v2] " Abhinav Mahadevan
2026-04-28 6:04 ` Takashi Iwai
2026-04-28 14:33 ` [PATCH v3] " Abhinav Mahadevan
2026-04-28 14:44 ` Takashi Iwai [this message]
2026-04-28 15:50 ` [PATCH v4] ALSA: usb-audio: Fix quirk entry placement " Abhinav Mahadevan
2026-04-29 5:48 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bjf3du0k.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=abhi220204@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.