From: Salman Alghamdi <me@cipherat.com>
To: gregkh@linuxfoundation.org
Cc: luka.gejak@linux.dev, straube.linux@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH v6 6/8] staging: rtl8723bs: rtw_mlme: remove dead commented-out code
Date: Tue, 28 Apr 2026 19:44:36 +0300 [thread overview]
Message-ID: <20260428164513.763471-7-me@cipherat.com> (raw)
In-Reply-To: <20260428164513.763471-1-me@cipherat.com>
Remove commented-out code and its associated orphaned comments.
Signed-off-by: Salman Alghamdi <me@cipherat.com>
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 19 +------------------
1 file changed, 1 insertion(+), 18 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index 9582d9704393..233675f3a045 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
@@ -750,9 +750,6 @@ void rtw_surveydone_event_callback(struct adapter *adapter, u8 *pbuf)
u8 *pibss = regs->dev_network.mac_address;
u8 ret = _SUCCESS;
- /* pmlmepriv->fw_state ^= _FW_UNDER_SURVEY;
- * because don't set assoc_timer
- */
_clr_fwstate_(pmlmepriv, _FW_UNDER_SURVEY);
memcpy(&pdev_network->ssid, &pmlmepriv->assoc_ssid,
@@ -1707,14 +1704,8 @@ void rtw_dynamic_check_timer_handler(struct adapter *adapter)
linked_status_chk(adapter);
should_enter_ps = traffic_status_watchdog(adapter, true);
- if (should_enter_ps) {
- /* rtw_lps_ctrl_wk_cmd(adapter, LPS_CTRL_ENTER, 1); */
+ if (should_enter_ps)
rtw_hal_dm_watchdog_in_lps(adapter);
- } else {
- /* call rtw_lps_ctrl_wk_cmd(padapter, LPS_CTRL_LEAVE, 1)
- * in traffic_status_watchdog()
- */
- }
} else {
rtw_dynamic_chk_wk_cmd(adapter);
@@ -2249,19 +2240,11 @@ void rtw_update_registrypriv_dev_network(struct adapter *adapter)
/* 1. Supported rates */
/* 2. IE */
- /* rtw_set_supported_rate(pdev_network->supported_rates, pregistrypriv->wireless_mode);
- * will be called in rtw_generate_ie
- */
sz = rtw_generate_ie(pregistrypriv);
pdev_network->ie_length = sz;
pdev_network->length = get_wlan_bssid_ex_sz((struct wlan_bssid_ex *)pdev_network);
-
- /* notes: translate ie_length & length after assign the
- * length to cmdsz in createbss_cmd();
- */
- /* pdev_network->ie_length = cpu_to_le32(sz); */
}
/* the function is at passive_level */
--
2.54.0
next prev parent reply other threads:[~2026-04-28 16:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 16:44 [PATCH v6 0/8] staging: rtl8723bs: rtw_mlme: fix long lines and related issues Salman Alghamdi
2026-04-28 16:44 ` [PATCH v6 1/8] staging: rtl8723bs: fix buffer over-read in rtw_update_protection Salman Alghamdi
2026-05-04 9:35 ` Greg KH
2026-05-07 21:56 ` Salman Alghamdi
2026-05-08 5:00 ` Greg KH
2026-04-28 16:44 ` [PATCH v6 2/8] staging: rtl8723bs: rtw_mlme: add bounds checks before ie_length subtraction Salman Alghamdi
2026-04-28 16:44 ` [PATCH v6 3/8] staging: rtl8723bs: rtw_mlme: wrap lines exceeding 100 columns Salman Alghamdi
2026-04-28 16:44 ` [PATCH v6 4/8] staging: rtl8723bs: rtw_mlme: wrap rtw_sitesurvey_cmd condition Salman Alghamdi
2026-04-28 16:44 ` [PATCH v6 5/8] staging: rtl8723bs: rtw_mlme: extract local variables for long expressions Salman Alghamdi
2026-04-28 16:44 ` Salman Alghamdi [this message]
2026-04-28 16:44 ` [PATCH v6 7/8] staging: rtl8723bs: rtw_mlme: consolidate capability comparisons lines Salman Alghamdi
2026-04-28 16:44 ` [PATCH v6 8/8] staging: rtl8723bs: rtw_mlme: add blank line for readability Salman Alghamdi
2026-04-28 17:42 ` [PATCH v6 0/8] staging: rtl8723bs: rtw_mlme: fix long lines and related issues Luka Gejak
2026-04-28 18:43 ` Salman Alghamdi
2026-04-28 19:52 ` Luka Gejak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260428164513.763471-7-me@cipherat.com \
--to=me@cipherat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=luka.gejak@linux.dev \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.