All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luka Gejak <luka.gejak@linux.dev>
To: Salman Alghamdi <me@cipherat.com>, gregkh@linuxfoundation.org
Cc: straube.linux@gmail.com, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org, luka.gejak@linux.dev
Subject: Re: [PATCH v6 0/8] staging: rtl8723bs: rtw_mlme: fix long lines and related issues
Date: Tue, 28 Apr 2026 19:42:36 +0200	[thread overview]
Message-ID: <9EC2EE03-DBFE-42D0-AC1E-520D73C83C5F@linux.dev> (raw)
In-Reply-To: <20260428164513.763471-1-me@cipherat.com>

On April 28, 2026 6:44:30 PM GMT+02:00, Salman Alghamdi <me@cipherat.com> wrote:
>This series addresses review feedback on v5. Changes from v5:
>
>- Fix variable declaration ordering that broke compilation due to
>  dependency on uninitialized pointer (per Luka Gejak)
>
>Salman Alghamdi (8):
>  staging: rtl8723bs: fix buffer over-read in rtw_update_protection
>  staging: rtl8723bs: rtw_mlme: add bounds checks before ie_length
>    subtraction
>  staging: rtl8723bs: rtw_mlme: wrap lines exceeding 100 columns
>  staging: rtl8723bs: rtw_mlme: wrap rtw_sitesurvey_cmd condition
>  staging: rtl8723bs: rtw_mlme: extract local variables for long
>    expressions
>  staging: rtl8723bs: rtw_mlme: remove dead commented-out code
>  staging: rtl8723bs: rtw_mlme: consolidate capability comparisons lines
>  staging: rtl8723bs: rtw_mlme: add blank line for readability
>
> drivers/staging/rtl8723bs/core/rtw_mlme.c | 276 ++++++++++++++--------
> 1 file changed, 183 insertions(+), 93 deletions(-)
>

LGTM, so unless Dan has something to add, for the patch series:

Reviewed-by: Luka Gejak <luka.gejak@linux.dev>

Best regards,
Luka Gejak

  parent reply	other threads:[~2026-04-28 17:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-28 16:44 [PATCH v6 0/8] staging: rtl8723bs: rtw_mlme: fix long lines and related issues Salman Alghamdi
2026-04-28 16:44 ` [PATCH v6 1/8] staging: rtl8723bs: fix buffer over-read in rtw_update_protection Salman Alghamdi
2026-05-04  9:35   ` Greg KH
2026-05-07 21:56     ` Salman Alghamdi
2026-05-08  5:00       ` Greg KH
2026-04-28 16:44 ` [PATCH v6 2/8] staging: rtl8723bs: rtw_mlme: add bounds checks before ie_length subtraction Salman Alghamdi
2026-04-28 16:44 ` [PATCH v6 3/8] staging: rtl8723bs: rtw_mlme: wrap lines exceeding 100 columns Salman Alghamdi
2026-04-28 16:44 ` [PATCH v6 4/8] staging: rtl8723bs: rtw_mlme: wrap rtw_sitesurvey_cmd condition Salman Alghamdi
2026-04-28 16:44 ` [PATCH v6 5/8] staging: rtl8723bs: rtw_mlme: extract local variables for long expressions Salman Alghamdi
2026-04-28 16:44 ` [PATCH v6 6/8] staging: rtl8723bs: rtw_mlme: remove dead commented-out code Salman Alghamdi
2026-04-28 16:44 ` [PATCH v6 7/8] staging: rtl8723bs: rtw_mlme: consolidate capability comparisons lines Salman Alghamdi
2026-04-28 16:44 ` [PATCH v6 8/8] staging: rtl8723bs: rtw_mlme: add blank line for readability Salman Alghamdi
2026-04-28 17:42 ` Luka Gejak [this message]
2026-04-28 18:43   ` [PATCH v6 0/8] staging: rtl8723bs: rtw_mlme: fix long lines and related issues Salman Alghamdi
2026-04-28 19:52     ` Luka Gejak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9EC2EE03-DBFE-42D0-AC1E-520D73C83C5F@linux.dev \
    --to=luka.gejak@linux.dev \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=me@cipherat.com \
    --cc=straube.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.