All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 06/13] package/python-nmcli: new package
@ 2026-04-28 17:20 Alexandre Ondet
  2026-05-30 22:00 ` Marcus Hoffmann via buildroot
  0 siblings, 1 reply; 2+ messages in thread
From: Alexandre Ondet @ 2026-04-28 17:20 UTC (permalink / raw)
  To: buildroot; +Cc: Alexandre Ondet, James Hilliard, Thomas Petazzoni

Signed-off-by: Alexandre Ondet <frcomdev@gmail.com>
---
 package/Config.in                      |  1 +
 package/python-nmcli/Config.in         |  6 ++++++
 package/python-nmcli/python-nmcli.hash |  3 +++
 package/python-nmcli/python-nmcli.mk   | 14 ++++++++++++++
 4 files changed, 24 insertions(+)
 create mode 100644 package/python-nmcli/Config.in
 create mode 100644 package/python-nmcli/python-nmcli.hash
 create mode 100644 package/python-nmcli/python-nmcli.mk

diff --git a/package/Config.in b/package/Config.in
index 754bdee9f4..83c9e0809c 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1261,6 +1261,7 @@ menu "External python modules"
 	source "package/python-netifaces/Config.in"
 	source "package/python-networkmanager/Config.in"
 	source "package/python-networkx/Config.in"
+	source "package/python-nmcli/Config.in"
 	source "package/python-numpy/Config.in"
 	source "package/python-oauthlib/Config.in"
 	source "package/python-opcua-asyncio/Config.in"
diff --git a/package/python-nmcli/Config.in b/package/python-nmcli/Config.in
new file mode 100644
index 0000000000..acdb6a1423
--- /dev/null
+++ b/package/python-nmcli/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_PYTHON_NMCLI
+	bool "python-nmcli"
+	help
+	  Python wrapper for nmcli (NetworkManager).
+
+	  https://github.com/ushiboy/nmcli
\ No newline at end of file
diff --git a/package/python-nmcli/python-nmcli.hash b/package/python-nmcli/python-nmcli.hash
new file mode 100644
index 0000000000..d11842e3e8
--- /dev/null
+++ b/package/python-nmcli/python-nmcli.hash
@@ -0,0 +1,3 @@
+# From https://pypi.org/pypi/nmcli/1.7.0/json
+sha256  4fb17b6c33d276a264a27b7109fa1d70987570536fa8852b51830f9f7732f982  nmcli-1.7.0.tar.gz
+sha256  9dbbc4debacc85f5f5f074614cd9cadd61da09eaa19f98f6bbb5463c34133820  LICENSE.txt
\ No newline at end of file
diff --git a/package/python-nmcli/python-nmcli.mk b/package/python-nmcli/python-nmcli.mk
new file mode 100644
index 0000000000..449131974d
--- /dev/null
+++ b/package/python-nmcli/python-nmcli.mk
@@ -0,0 +1,14 @@
+################################################################################
+#
+# python-nmcli
+#
+################################################################################
+
+PYTHON_NMCLI_VERSION = 1.7.0
+PYTHON_NMCLI_SOURCE = nmcli-$(PYTHON_NMCLI_VERSION).tar.gz
+PYTHON_NMCLI_SITE = https://files.pythonhosted.org/packages/source/n/nmcli
+PYTHON_NMCLI_SETUP_TYPE = setuptools
+PYTHON_NMCLI_LICENSE = MIT
+PYTHON_NMCLI_LICENSE_FILES = LICENSE.txt
+
+$(eval $(python-package))
\ No newline at end of file
-- 
2.53.0.windows.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 2+ messages in thread
* Re: [Buildroot] [PATCH 06/13] package/python-nmcli: new package
  2026-04-28 17:20 [Buildroot] [PATCH 06/13] package/python-nmcli: new package Alexandre Ondet
@ 2026-05-30 22:00 ` Marcus Hoffmann via buildroot
  0 siblings, 0 replies; 2+ messages in thread
From: Marcus Hoffmann via buildroot @ 2026-05-30 22:00 UTC (permalink / raw)
  To: Alexandre Ondet, buildroot; +Cc: James Hilliard, Thomas Petazzoni

Hi Alexandre,

some comments below.

On 4/28/26 19:20, Alexandre Ondet wrote:
> Signed-off-by: Alexandre Ondet <frcomdev@gmail.com>
> ---
>   package/Config.in                      |  1 +
>   package/python-nmcli/Config.in         |  6 ++++++
>   package/python-nmcli/python-nmcli.hash |  3 +++
>   package/python-nmcli/python-nmcli.mk   | 14 ++++++++++++++
>   4 files changed, 24 insertions(+)
>   create mode 100644 package/python-nmcli/Config.in
>   create mode 100644 package/python-nmcli/python-nmcli.hash
>   create mode 100644 package/python-nmcli/python-nmcli.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index 754bdee9f4..83c9e0809c 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1261,6 +1261,7 @@ menu "External python modules"
>   	source "package/python-netifaces/Config.in"
>   	source "package/python-networkmanager/Config.in"
>   	source "package/python-networkx/Config.in"
> +	source "package/python-nmcli/Config.in"
>   	source "package/python-numpy/Config.in"
>   	source "package/python-oauthlib/Config.in"
>   	source "package/python-opcua-asyncio/Config.in"
> diff --git a/package/python-nmcli/Config.in b/package/python-nmcli/Config.in
> new file mode 100644
> index 0000000000..acdb6a1423
> --- /dev/null
> +++ b/package/python-nmcli/Config.in
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_PYTHON_NMCLI
> +	bool "python-nmcli"

This should depend on BR2_PACKAGE_NETWORK_MANAGER, as it probably 
doesn't make any sense to have this package without also having 
network-manager on your device?

And then you can select BR2_PACKAGE_NETWORK_MANAGER_CLI to ensure the 
nmcli part also gets enabled automatically when you enable python-nmcli.

> +	help
> +	  Python wrapper for nmcli (NetworkManager).
> +
> +	  https://github.com/ushiboy/nmcli
> \ No newline at end of file
> diff --git a/package/python-nmcli/python-nmcli.hash b/package/python-nmcli/python-nmcli.hash
> new file mode 100644
> index 0000000000..d11842e3e8
> --- /dev/null
> +++ b/package/python-nmcli/python-nmcli.hash
> @@ -0,0 +1,3 @@
> +# From https://pypi.org/pypi/nmcli/1.7.0/json
> +sha256  4fb17b6c33d276a264a27b7109fa1d70987570536fa8852b51830f9f7732f982  nmcli-1.7.0.tar.gz
> +sha256  9dbbc4debacc85f5f5f074614cd9cadd61da09eaa19f98f6bbb5463c34133820  LICENSE.txt
> \ No newline at end of file
> diff --git a/package/python-nmcli/python-nmcli.mk b/package/python-nmcli/python-nmcli.mk
> new file mode 100644
> index 0000000000..449131974d
> --- /dev/null
> +++ b/package/python-nmcli/python-nmcli.mk
> @@ -0,0 +1,14 @@
> +################################################################################
> +#
> +# python-nmcli
> +#
> +################################################################################
> +
> +PYTHON_NMCLI_VERSION = 1.7.0
> +PYTHON_NMCLI_SOURCE = nmcli-$(PYTHON_NMCLI_VERSION).tar.gz
> +PYTHON_NMCLI_SITE = https://files.pythonhosted.org/packages/source/n/nmcli
> +PYTHON_NMCLI_SETUP_TYPE = setuptools
> +PYTHON_NMCLI_LICENSE = MIT
> +PYTHON_NMCLI_LICENSE_FILES = LICENSE.txt
> +
> +$(eval $(python-package))
> \ No newline at end of file

Please make sure your files all have a newline at the end.

A general note for these type of packages with runtime dependencies 
(which applies to python packages in general but also for this 
specifically for the network-manager dependency): it would be really 
good to add a runtime test together with the package [1]. It helps to 
test the package when reviewing and ensures it doesn't silently break 
with some network-manager update.

I've marked this as changes requested in patchwork.


Best,
Marcus

[1] 
https://nightly.buildroot.org/manual.html#_using_the_runtime_tests_framework
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-30 22:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-28 17:20 [Buildroot] [PATCH 06/13] package/python-nmcli: new package Alexandre Ondet
2026-05-30 22:00 ` Marcus Hoffmann via buildroot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.