From: Conor Dooley <conor@kernel.org>
To: Yixun Lan <dlan@kernel.org>
Cc: Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Inochi Amaoto <inochiama@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
linux-clk@vger.kernel.org, linux-riscv@lists.infradead.org,
devicetree@vger.kernel.org, spacemit@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: soc: spacemit: k3: Add PCIe DBI clock IDs
Date: Thu, 30 Apr 2026 19:55:20 +0100 [thread overview]
Message-ID: <20260430-plug-bolt-8ff9137717fa@spud> (raw)
In-Reply-To: <20260430-06-pci-clk-fix-v1-1-32fdc77c02ab@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1212 bytes --]
On Thu, Apr 30, 2026 at 10:30:26AM +0000, Yixun Lan wrote:
> Add clock IDs of PCIe DBI (Data Bus Interface) clock.
>
> Fixes: efe897b557e2 ("dt-bindings: soc: spacemit: k3: add clock support")
Why is this a fix? As-is, this looks like you're abusing the Fixes tag
so that this gets backported alongside things that are a fix that depend
on it.
> Signed-off-by: Yixun Lan <dlan@kernel.org>
> ---
> include/dt-bindings/clock/spacemit,k3-clocks.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/include/dt-bindings/clock/spacemit,k3-clocks.h b/include/dt-bindings/clock/spacemit,k3-clocks.h
> index b22336f3ae40..dfae52547cda 100644
> --- a/include/dt-bindings/clock/spacemit,k3-clocks.h
> +++ b/include/dt-bindings/clock/spacemit,k3-clocks.h
> @@ -380,6 +380,11 @@
> #define CLK_APMU_ISIM_VCLK1 86
> #define CLK_APMU_ISIM_VCLK2 87
> #define CLK_APMU_ISIM_VCLK3 88
> +#define CLK_APMU_PCIE_PORTA_DBI 89
> +#define CLK_APMU_PCIE_PORTB_DBI 90
> +#define CLK_APMU_PCIE_PORTC_DBI 91
> +#define CLK_APMU_PCIE_PORTD_DBI 92
> +#define CLK_APMU_PCIE_PORTE_DBI 93
>
> /* DCIU clocks */
> #define CLK_DCIU_HDMA 0
>
> --
> 2.53.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org>
To: Yixun Lan <dlan@kernel.org>
Cc: Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Inochi Amaoto <inochiama@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
linux-clk@vger.kernel.org, linux-riscv@lists.infradead.org,
devicetree@vger.kernel.org, spacemit@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: soc: spacemit: k3: Add PCIe DBI clock IDs
Date: Thu, 30 Apr 2026 19:55:20 +0100 [thread overview]
Message-ID: <20260430-plug-bolt-8ff9137717fa@spud> (raw)
In-Reply-To: <20260430-06-pci-clk-fix-v1-1-32fdc77c02ab@kernel.org>
[-- Attachment #1.1: Type: text/plain, Size: 1212 bytes --]
On Thu, Apr 30, 2026 at 10:30:26AM +0000, Yixun Lan wrote:
> Add clock IDs of PCIe DBI (Data Bus Interface) clock.
>
> Fixes: efe897b557e2 ("dt-bindings: soc: spacemit: k3: add clock support")
Why is this a fix? As-is, this looks like you're abusing the Fixes tag
so that this gets backported alongside things that are a fix that depend
on it.
> Signed-off-by: Yixun Lan <dlan@kernel.org>
> ---
> include/dt-bindings/clock/spacemit,k3-clocks.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/include/dt-bindings/clock/spacemit,k3-clocks.h b/include/dt-bindings/clock/spacemit,k3-clocks.h
> index b22336f3ae40..dfae52547cda 100644
> --- a/include/dt-bindings/clock/spacemit,k3-clocks.h
> +++ b/include/dt-bindings/clock/spacemit,k3-clocks.h
> @@ -380,6 +380,11 @@
> #define CLK_APMU_ISIM_VCLK1 86
> #define CLK_APMU_ISIM_VCLK2 87
> #define CLK_APMU_ISIM_VCLK3 88
> +#define CLK_APMU_PCIE_PORTA_DBI 89
> +#define CLK_APMU_PCIE_PORTB_DBI 90
> +#define CLK_APMU_PCIE_PORTC_DBI 91
> +#define CLK_APMU_PCIE_PORTD_DBI 92
> +#define CLK_APMU_PCIE_PORTE_DBI 93
>
> /* DCIU clocks */
> #define CLK_DCIU_HDMA 0
>
> --
> 2.53.0
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2026-04-30 18:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 10:30 [PATCH 0/4] riscv: spacemit: k3: some clock fixes related to PCIe Yixun Lan
2026-04-30 10:30 ` Yixun Lan
2026-04-30 10:30 ` [PATCH 1/4] dt-bindings: soc: spacemit: k3: Add PCIe DBI clock IDs Yixun Lan
2026-04-30 10:30 ` Yixun Lan
2026-04-30 18:55 ` Conor Dooley [this message]
2026-04-30 18:55 ` Conor Dooley
2026-05-02 11:32 ` Yixun Lan
2026-05-02 11:32 ` Yixun Lan
2026-05-03 17:59 ` Conor Dooley
2026-05-03 17:59 ` Conor Dooley
2026-04-30 10:30 ` [PATCH 2/4] clk: spacemit: k3: Add PCIe DBI clock Yixun Lan
2026-04-30 10:30 ` Yixun Lan
2026-05-01 9:28 ` Krzysztof Kozlowski
2026-05-01 9:28 ` Krzysztof Kozlowski
2026-05-02 11:30 ` Yixun Lan
2026-05-02 11:30 ` Yixun Lan
2026-04-30 10:30 ` [PATCH 3/4] clk: spacemit: k3: Switch to pll2_d6 as parent for PCIe clock Yixun Lan
2026-04-30 10:30 ` Yixun Lan
2026-04-30 10:30 ` [PATCH 4/4] clk: spacemit: k3: Fix PCIe clock register offset Yixun Lan
2026-04-30 10:30 ` Yixun Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260430-plug-bolt-8ff9137717fa@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@kernel.org \
--cc=inochiama@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=spacemit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.