* [PATCH v4 0/3] wireless: p54 devicetree conversion
@ 2026-04-30 8:12 Arnd Bergmann
2026-04-30 8:12 ` [PATCH v4 1/3 net-next] dt-bindings: net: add st,stlc4560/p54spi binding Arnd Bergmann
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Arnd Bergmann @ 2026-04-30 8:12 UTC (permalink / raw)
To: netdev
Cc: Arnd Bergmann, Aaro Koskinen, Andreas Kemnade,
Bartosz Golaszewski, Benoît Cousson, David S. Miller,
Dmitry Torokhov, Eric Dumazet, Felipe Balbi, Jakub Kicinski,
Johannes Berg, Kevin Hilman, Krzysztof Kozlowski, Linus Walleij,
Paolo Abeni, Rob Herring, Roger Quadros, Tony Lindgren,
linux-wireless, devicetree, linux-kernel, linux-arm-kernel,
linux-gpio, linux-omap
From: Arnd Bergmann <arnd@arndb.de>
This is an older patch of mine that I lost track of. We already decided
a while ago that the OMAP2 platform should probably be removed entirely,
and this is the only known user, but it's probably a good idea to still
get the driver changes in, in case there are other out-of-tree users.
We probably don't have to worry about bisectability any more though,
so the devicetree and driver changes can just get merged independently
through the OMAP and wireless trees, respectively.
Arnd
v3 Link: https://lore.kernel.org/all/20260427142355.2532714-1-arnd@kernel.org/
v2 Link: https://lore.kernel.org/all/20230404082401.1087835-1-arnd@kernel.org/
Cc: "Aaro Koskinen" <aaro.koskinen@iki.fi>
Cc: "Andreas Kemnade" <andreas@kemnade.info>
Cc: "Arnd Bergmann" <arnd@arndb.de>
Cc: "Bartosz Golaszewski" <brgl@kernel.org>
Cc: "Benoît Cousson" <bcousson@baylibre.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
Cc: "Eric Dumazet" <edumazet@google.com>
Cc: "Felipe Balbi" <balbi@kernel.org>
Cc: "Jakub Kicinski" <kuba@kernel.org>
Cc: "Johannes Berg" <johannes@sipsolutions.net>
Cc: "Kevin Hilman" <khilman@baylibre.com>
Cc: "Krzysztof Kozlowski" <krzk+dt@kernel.org>
Cc: "Linus Walleij" <linusw@kernel.org>
Cc: "Paolo Abeni" <pabeni@redhat.com>
Cc: "Rob Herring" <robh+dt@kernel.org>
Cc: "Roger Quadros" <rogerq@kernel.org>
Cc: "Tony Lindgren" <tony@atomide.com>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-gpio@vger.kernel.org
Cc: linux-omap@vger.kernel.org
Arnd Bergmann (3):
[net-next][v4] dt-bindings: net: add st,stlc4560/p54spi binding
[net-next][v4] p54spi: convert to devicetree
[omap][v4] ARM: dts: omap2: add stlc4560 spi-wireless node
.../bindings/net/wireless/st,stlc4560.yaml | 61 +++++++++++++++++
MAINTAINERS | 1 +
arch/arm/boot/dts/ti/omap/omap2.dtsi | 4 ++
.../dts/ti/omap/omap2420-n8x0-common.dtsi | 12 ++++
arch/arm/mach-omap2/board-n8x0.c | 18 -----
drivers/net/wireless/intersil/p54/p54spi.c | 66 +++++++------------
drivers/net/wireless/intersil/p54/p54spi.h | 3 +
7 files changed, 103 insertions(+), 62 deletions(-)
create mode 100644 Documentation/devicetree/bindings/net/wireless/st,stlc4560.yaml
--
2.39.5
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH v4 1/3 net-next] dt-bindings: net: add st,stlc4560/p54spi binding 2026-04-30 8:12 [PATCH v4 0/3] wireless: p54 devicetree conversion Arnd Bergmann @ 2026-04-30 8:12 ` Arnd Bergmann 2026-04-30 9:25 ` Rob Herring (Arm) 2026-04-30 8:12 ` [PATCH v4 2/3 net-next] p54spi: convert to devicetree Arnd Bergmann 2026-04-30 8:12 ` [PATCH v4 3/3 omap] ARM: dts: omap2: add stlc4560 spi-wireless node Arnd Bergmann 2 siblings, 1 reply; 10+ messages in thread From: Arnd Bergmann @ 2026-04-30 8:12 UTC (permalink / raw) To: netdev Cc: Arnd Bergmann, Aaro Koskinen, Andreas Kemnade, Bartosz Golaszewski, Benoît Cousson, David S. Miller, Dmitry Torokhov, Eric Dumazet, Felipe Balbi, Jakub Kicinski, Johannes Berg, Kevin Hilman, Krzysztof Kozlowski, Linus Walleij, Paolo Abeni, Rob Herring, Roger Quadros, Tony Lindgren, linux-wireless, devicetree, linux-kernel, linux-arm-kernel, linux-gpio, linux-omap, Christian Lamparter From: Arnd Bergmann <arnd@arndb.de> The SPI version of Prism54 was sold under a couple of different names and supported by the Linux p54spi driver, but there was never a DT binding for it. Document the four known names of this device and the properties that are sufficient for its use on the Nokia N8x0 tablet. As I don't have this hardware or documentation for it, this is purely based on existing usage in the driver. Link: https://lore.kernel.org/all/e8dc9acb-6f85-e0a9-a145-d101ca6da201@gmail.com/ Acked-by: Christian Lamparter <chunkeey@gmail.com> Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- v4: renamed file to st,stlc4560, matching the primary compatible string require st,stlc4560 string --- .../bindings/net/wireless/st,stlc4560.yaml | 61 +++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 62 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/wireless/st,stlc4560.yaml diff --git a/Documentation/devicetree/bindings/net/wireless/st,stlc4560.yaml b/Documentation/devicetree/bindings/net/wireless/st,stlc4560.yaml new file mode 100644 index 000000000000..979c8d7d859a --- /dev/null +++ b/Documentation/devicetree/bindings/net/wireless/st,stlc4560.yaml @@ -0,0 +1,61 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/wireless/st,stlc45xx.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: ST/Intersil/Conexant stlc45xx/p54spi/cx3110x SPI wireless device + +maintainers: + - Christian Lamparter <chunkeey@gmail.com> + +description: + The SPI variant of the Intersil Prism54 wireless device was sold + under a variety of names, including Conexant CX3110x and + ST Microelectronics STLC5460. + +allOf: + - $ref: ieee80211.yaml# + - $ref: /schemas/spi/spi-peripheral-props.yaml# + +properties: + compatible: + oneOf: + - const: st,stlc4560 + - items: + - enum: + - cnxt,3110x + - isil,p54spi + - st,stlc4550 + - const: st,stlc4560 + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + powerdown-gpios: + maxItems: 1 + +required: + - compatible + - reg + - interrupts + +unevaluatedProperties: false + +examples: + - | + spi { + #address-cells = <1>; + #size-cells = <0>; + + wifi@0 { + compatible = "st,stlc4560"; + reg = <0>; + spi-max-frequency = <48000000>; + interrupts-extended = <&gpio 23>; + powerdown-gpios = <&gpio 1>; + }; + }; diff --git a/MAINTAINERS b/MAINTAINERS index 86ca9297edab..67cf5ae5b652 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -20093,6 +20093,7 @@ M: Christian Lamparter <chunkeey@googlemail.com> L: linux-wireless@vger.kernel.org S: Maintained W: https://wireless.wiki.kernel.org/en/users/Drivers/p54 +F: Documentation/devicetree/bindings/net/wireless/st,stlc45xx.yaml F: drivers/net/wireless/intersil/ PACKET SOCKETS -- 2.39.5 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v4 1/3 net-next] dt-bindings: net: add st,stlc4560/p54spi binding 2026-04-30 8:12 ` [PATCH v4 1/3 net-next] dt-bindings: net: add st,stlc4560/p54spi binding Arnd Bergmann @ 2026-04-30 9:25 ` Rob Herring (Arm) 2026-04-30 9:58 ` Arnd Bergmann 0 siblings, 1 reply; 10+ messages in thread From: Rob Herring (Arm) @ 2026-04-30 9:25 UTC (permalink / raw) To: Arnd Bergmann Cc: Christian Lamparter, Andreas Kemnade, Benoît Cousson, Eric Dumazet, Bartosz Golaszewski, Krzysztof Kozlowski, Johannes Berg, Jakub Kicinski, Kevin Hilman, Arnd Bergmann, linux-kernel, linux-wireless, linux-omap, Felipe Balbi, Rob Herring, linux-gpio, Paolo Abeni, devicetree, netdev, David S. Miller, Roger Quadros, linux-arm-kernel, Dmitry Torokhov, Aaro Koskinen, Tony Lindgren, Linus Walleij On Thu, 30 Apr 2026 10:12:40 +0200, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The SPI version of Prism54 was sold under a couple of different > names and supported by the Linux p54spi driver, but there was > never a DT binding for it. > > Document the four known names of this device and the properties > that are sufficient for its use on the Nokia N8x0 tablet. > > As I don't have this hardware or documentation for it, this is > purely based on existing usage in the driver. > > Link: https://lore.kernel.org/all/e8dc9acb-6f85-e0a9-a145-d101ca6da201@gmail.com/ > Acked-by: Christian Lamparter <chunkeey@gmail.com> > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > v4: renamed file to st,stlc4560, matching the primary compatible string > require st,stlc4560 string > --- > .../bindings/net/wireless/st,stlc4560.yaml | 61 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 62 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/wireless/st,stlc4560.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/st,stlc4560.yaml: $id: Cannot determine base path from $id, relative path/filename doesn't match actual path or filename $id: http://devicetree.org/schemas/net/wireless/st,stlc45xx.yaml file: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/st,stlc4560.yaml doc reference errors (make refcheckdocs): Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/net/wireless/st,stlc45xx.yaml MAINTAINERS: Documentation/devicetree/bindings/net/wireless/st,stlc45xx.yaml See https://patchwork.kernel.org/project/devicetree/patch/20260430081242.3686993-2-arnd@kernel.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v4 1/3 net-next] dt-bindings: net: add st,stlc4560/p54spi binding 2026-04-30 9:25 ` Rob Herring (Arm) @ 2026-04-30 9:58 ` Arnd Bergmann 0 siblings, 0 replies; 10+ messages in thread From: Arnd Bergmann @ 2026-04-30 9:58 UTC (permalink / raw) To: Rob Herring, Arnd Bergmann Cc: Christian Lamparter, Andreas Kemnade, Benoît Cousson, Eric Dumazet, Bartosz Golaszewski, Krzysztof Kozlowski, Johannes Berg, Jakub Kicinski, Kevin Hilman, linux-kernel, linux-wireless, Linux-OMAP, Felipe Balbi, Rob Herring, open list:GPIO SUBSYSTEM, Paolo Abeni, devicetree, Netdev, David S . Miller, Roger Quadros, linux-arm-kernel, Dmitry Torokhov, Aaro Koskinen, Tony Lindgren, Linus Walleij On Thu, Apr 30, 2026, at 11:25, Rob Herring (Arm) wrote: > On Thu, 30 Apr 2026 10:12:40 +0200, Arnd Bergmann wrote: >> .../bindings/net/wireless/st,stlc4560.yaml | 61 +++++++++++++++++++ >> MAINTAINERS | 1 + >> 2 files changed, 62 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/wireless/st,stlc4560.yaml >> > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > $id: Cannot determine base path from $id, relative path/filename > doesn't match actual path or filename > $id: http://devicetree.org/schemas/net/wireless/st,stlc45xx.yaml > file: Thanks for the report, I've fixed it now for v5, to adjust for the renamed file. Arnd ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v4 2/3 net-next] p54spi: convert to devicetree 2026-04-30 8:12 [PATCH v4 0/3] wireless: p54 devicetree conversion Arnd Bergmann 2026-04-30 8:12 ` [PATCH v4 1/3 net-next] dt-bindings: net: add st,stlc4560/p54spi binding Arnd Bergmann @ 2026-04-30 8:12 ` Arnd Bergmann 2026-05-05 10:37 ` Linus Walleij 2026-04-30 8:12 ` [PATCH v4 3/3 omap] ARM: dts: omap2: add stlc4560 spi-wireless node Arnd Bergmann 2 siblings, 1 reply; 10+ messages in thread From: Arnd Bergmann @ 2026-04-30 8:12 UTC (permalink / raw) To: netdev Cc: Arnd Bergmann, Aaro Koskinen, Andreas Kemnade, Bartosz Golaszewski, Benoît Cousson, David S. Miller, Dmitry Torokhov, Eric Dumazet, Felipe Balbi, Jakub Kicinski, Johannes Berg, Kevin Hilman, Krzysztof Kozlowski, Linus Walleij, Paolo Abeni, Rob Herring, Roger Quadros, Tony Lindgren, linux-wireless, devicetree, linux-kernel, linux-arm-kernel, linux-gpio, linux-omap, Christian Lamparter From: Arnd Bergmann <arnd@arndb.de> The Prism54 SPI driver hardcodes GPIO numbers and expects users to pass them as module parameters, apparently a relic from its life as a staging driver. This works because there is only one user, the Nokia N8x0 tablet. Convert this to the gpio descriptor interface and DT based probing to improve this and simplify the code at the same time. Acked-by: Christian Lamparter <chunkeey@gmail.com> Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- v4: - make gpio line optional again - fix EPROBE_DEFER handling - match only st,stlc4560 compatible value, with binding change v3: - rebase an older patch --- arch/arm/mach-omap2/board-n8x0.c | 18 ------ drivers/net/wireless/intersil/p54/p54spi.c | 66 ++++++++-------------- drivers/net/wireless/intersil/p54/p54spi.h | 3 + 3 files changed, 25 insertions(+), 62 deletions(-) diff --git a/arch/arm/mach-omap2/board-n8x0.c b/arch/arm/mach-omap2/board-n8x0.c index 969265d5d5c6..d9acd32c5457 100644 --- a/arch/arm/mach-omap2/board-n8x0.c +++ b/arch/arm/mach-omap2/board-n8x0.c @@ -20,7 +20,6 @@ #include <linux/spi/spi.h> #include <linux/usb/musb.h> #include <linux/mmc/host.h> -#include <linux/platform_data/spi-omap2-mcspi.h> #include <linux/platform_data/mmc-omap.h> #include <linux/mfd/menelaus.h> @@ -106,21 +105,6 @@ static void __init n8x0_usb_init(void) {} #endif /*CONFIG_USB_MUSB_TUSB6010 */ - -static struct omap2_mcspi_device_config p54spi_mcspi_config = { - .turbo_mode = 0, -}; - -static struct spi_board_info n800_spi_board_info[] __initdata = { - { - .modalias = "p54spi", - .bus_num = 2, - .chip_select = 0, - .max_speed_hz = 48000000, - .controller_data = &p54spi_mcspi_config, - }, -}; - #if defined(CONFIG_MENELAUS) && IS_ENABLED(CONFIG_MMC_OMAP) /* @@ -524,7 +508,5 @@ omap_late_initcall(n8x0_late_initcall); void * __init n8x0_legacy_init(void) { board_check_revision(); - spi_register_board_info(n800_spi_board_info, - ARRAY_SIZE(n800_spi_board_info)); return &mmc1_data; } diff --git a/drivers/net/wireless/intersil/p54/p54spi.c b/drivers/net/wireless/intersil/p54/p54spi.c index 9d66dcae54e0..806761580759 100644 --- a/drivers/net/wireless/intersil/p54/p54spi.c +++ b/drivers/net/wireless/intersil/p54/p54spi.c @@ -8,6 +8,7 @@ */ #include <linux/module.h> +#include <linux/mod_devicetable.h> #include <linux/platform_device.h> #include <linux/interrupt.h> #include <linux/firmware.h> @@ -15,7 +16,7 @@ #include <linux/irq.h> #include <linux/spi/spi.h> #include <linux/etherdevice.h> -#include <linux/gpio.h> +#include <linux/gpio/consumer.h> #include <linux/slab.h> #include "p54spi.h" @@ -30,19 +31,6 @@ MODULE_FIRMWARE("3826.arm"); MODULE_FIRMWARE("3826.eeprom"); -/* gpios should be handled in board files and provided via platform data, - * but because it's currently impossible for p54spi to have a header file - * in include/linux, let's use module parameters for now - */ - -static int p54spi_gpio_power = 97; -module_param(p54spi_gpio_power, int, 0444); -MODULE_PARM_DESC(p54spi_gpio_power, "gpio number for power line"); - -static int p54spi_gpio_irq = 87; -module_param(p54spi_gpio_irq, int, 0444); -MODULE_PARM_DESC(p54spi_gpio_irq, "gpio number for irq line"); - static void p54spi_spi_read(struct p54s_priv *priv, u8 address, void *buf, size_t len) { @@ -262,14 +250,14 @@ static int p54spi_upload_firmware(struct ieee80211_hw *dev) static void p54spi_power_off(struct p54s_priv *priv) { - disable_irq(gpio_to_irq(p54spi_gpio_irq)); - gpio_set_value(p54spi_gpio_power, 0); + disable_irq(priv->irq); + gpiod_set_value(priv->gpio_powerdown, 1); } static void p54spi_power_on(struct p54s_priv *priv) { - gpio_set_value(p54spi_gpio_power, 1); - enable_irq(gpio_to_irq(p54spi_gpio_irq)); + gpiod_set_value(priv->gpio_powerdown, 0); + enable_irq(priv->irq); /* need to wait a while before device can be accessed, the length * is just a guess @@ -608,31 +596,19 @@ static int p54spi_probe(struct spi_device *spi) goto err_free; } - ret = gpio_request(p54spi_gpio_power, "p54spi power"); - if (ret < 0) { - dev_err(&priv->spi->dev, "power GPIO request failed: %d", ret); + priv->gpio_powerdown = gpiod_get_optional(&spi->dev, "powerdown", GPIOD_OUT_HIGH); + if (IS_ERR(priv->gpio_powerdown)) { + ret = dev_err_probe(&priv->spi->dev, PTR_ERR(priv->gpio_powerdown), + "powerdown GPIO request failed\n"); goto err_free; } - ret = gpio_request(p54spi_gpio_irq, "p54spi irq"); - if (ret < 0) { - dev_err(&priv->spi->dev, "irq GPIO request failed: %d", ret); - goto err_free_gpio_power; - } - - gpio_direction_output(p54spi_gpio_power, 0); - gpio_direction_input(p54spi_gpio_irq); - - ret = request_irq(gpio_to_irq(p54spi_gpio_irq), - p54spi_interrupt, IRQF_NO_AUTOEN, "p54spi", - priv->spi); + ret = request_irq(spi->irq, p54spi_interrupt, IRQF_NO_AUTOEN, "p54spi", priv->spi); if (ret < 0) { dev_err(&priv->spi->dev, "request_irq() failed"); - goto err_free_gpio_irq; + goto err_free_gpio_power; } - irq_set_irq_type(gpio_to_irq(p54spi_gpio_irq), IRQ_TYPE_EDGE_RISING); - INIT_WORK(&priv->work, p54spi_work); init_completion(&priv->fw_comp); INIT_LIST_HEAD(&priv->tx_pending); @@ -659,11 +635,9 @@ static int p54spi_probe(struct spi_device *spi) err_free_common: release_firmware(priv->firmware); - free_irq(gpio_to_irq(p54spi_gpio_irq), spi); -err_free_gpio_irq: - gpio_free(p54spi_gpio_irq); + free_irq(priv->irq, spi); err_free_gpio_power: - gpio_free(p54spi_gpio_power); + gpiod_put(priv->gpio_powerdown); err_free: p54_free_common(priv->hw); return ret; @@ -675,10 +649,8 @@ static void p54spi_remove(struct spi_device *spi) p54_unregister_common(priv->hw); - free_irq(gpio_to_irq(p54spi_gpio_irq), spi); - - gpio_free(p54spi_gpio_power); - gpio_free(p54spi_gpio_irq); + free_irq(priv->irq, spi); + gpiod_put(priv->gpio_powerdown); release_firmware(priv->firmware); mutex_destroy(&priv->mutex); @@ -686,10 +658,16 @@ static void p54spi_remove(struct spi_device *spi) p54_free_common(priv->hw); } +static const struct of_device_id p54spi_of_ids[] = { + { .compatible = "st,stlc4560", }, + { }, +}; +MODULE_DEVICE_TABLE(of, p54spi_of_ids); static struct spi_driver p54spi_driver = { .driver = { .name = "p54spi", + .of_match_table = p54spi_of_ids, }, .probe = p54spi_probe, diff --git a/drivers/net/wireless/intersil/p54/p54spi.h b/drivers/net/wireless/intersil/p54/p54spi.h index e5619a13fd61..118785cc635a 100644 --- a/drivers/net/wireless/intersil/p54/p54spi.h +++ b/drivers/net/wireless/intersil/p54/p54spi.h @@ -107,6 +107,9 @@ struct p54s_priv { enum fw_state fw_state; const struct firmware *firmware; + + struct gpio_desc *gpio_powerdown; + int irq; }; #endif /* P54SPI_H */ -- 2.39.5 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v4 2/3 net-next] p54spi: convert to devicetree 2026-04-30 8:12 ` [PATCH v4 2/3 net-next] p54spi: convert to devicetree Arnd Bergmann @ 2026-05-05 10:37 ` Linus Walleij 0 siblings, 0 replies; 10+ messages in thread From: Linus Walleij @ 2026-05-05 10:37 UTC (permalink / raw) To: Arnd Bergmann Cc: netdev, Arnd Bergmann, Aaro Koskinen, Andreas Kemnade, Bartosz Golaszewski, Benoît Cousson, David S. Miller, Dmitry Torokhov, Eric Dumazet, Felipe Balbi, Jakub Kicinski, Johannes Berg, Kevin Hilman, Krzysztof Kozlowski, Paolo Abeni, Rob Herring, Roger Quadros, Tony Lindgren, linux-wireless, devicetree, linux-kernel, linux-arm-kernel, linux-gpio, linux-omap, Christian Lamparter On Thu, Apr 30, 2026 at 10:13 AM Arnd Bergmann <arnd@kernel.org> wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The Prism54 SPI driver hardcodes GPIO numbers and expects users to > pass them as module parameters, apparently a relic from its life as a > staging driver. This works because there is only one user, the Nokia > N8x0 tablet. > > Convert this to the gpio descriptor interface and DT based probing > to improve this and simplify the code at the same time. > > Acked-by: Christian Lamparter <chunkeey@gmail.com> > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Linus Walleij <linusw@kernel.org> Yours, Linus Walleij ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v4 3/3 omap] ARM: dts: omap2: add stlc4560 spi-wireless node 2026-04-30 8:12 [PATCH v4 0/3] wireless: p54 devicetree conversion Arnd Bergmann 2026-04-30 8:12 ` [PATCH v4 1/3 net-next] dt-bindings: net: add st,stlc4560/p54spi binding Arnd Bergmann 2026-04-30 8:12 ` [PATCH v4 2/3 net-next] p54spi: convert to devicetree Arnd Bergmann @ 2026-04-30 8:12 ` Arnd Bergmann 2026-04-30 14:19 ` Bartosz Golaszewski 2026-05-05 10:41 ` Linus Walleij 2 siblings, 2 replies; 10+ messages in thread From: Arnd Bergmann @ 2026-04-30 8:12 UTC (permalink / raw) To: netdev Cc: Arnd Bergmann, Aaro Koskinen, Andreas Kemnade, Bartosz Golaszewski, Benoît Cousson, David S. Miller, Dmitry Torokhov, Eric Dumazet, Felipe Balbi, Jakub Kicinski, Johannes Berg, Kevin Hilman, Krzysztof Kozlowski, Linus Walleij, Paolo Abeni, Rob Herring, Roger Quadros, Tony Lindgren, linux-wireless, devicetree, linux-kernel, linux-arm-kernel, linux-gpio, linux-omap, Krzysztof Kozlowski From: Arnd Bergmann <arnd@arndb.de> Converted from the platform_device creation in board-n8x0.c. Link: https://lore.kernel.org/all/20230314163201.955689-1-arnd@kernel.org/ Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- arch/arm/boot/dts/ti/omap/omap2.dtsi | 4 ++++ arch/arm/boot/dts/ti/omap/omap2420-n8x0-common.dtsi | 12 ++++++++++++ 2 files changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/ti/omap/omap2.dtsi b/arch/arm/boot/dts/ti/omap/omap2.dtsi index afabb36a8ac1..fdc1790adf43 100644 --- a/arch/arm/boot/dts/ti/omap/omap2.dtsi +++ b/arch/arm/boot/dts/ti/omap/omap2.dtsi @@ -129,6 +129,8 @@ i2c2: i2c@48072000 { }; mcspi1: spi@48098000 { + #address-cells = <1>; + #size-cells = <0>; compatible = "ti,omap2-mcspi"; ti,hwmods = "mcspi1"; reg = <0x48098000 0x100>; @@ -140,6 +142,8 @@ mcspi1: spi@48098000 { }; mcspi2: spi@4809a000 { + #address-cells = <1>; + #size-cells = <0>; compatible = "ti,omap2-mcspi"; ti,hwmods = "mcspi2"; reg = <0x4809a000 0x100>; diff --git a/arch/arm/boot/dts/ti/omap/omap2420-n8x0-common.dtsi b/arch/arm/boot/dts/ti/omap/omap2420-n8x0-common.dtsi index 63b0b4921e4e..fe9dd8bbfc85 100644 --- a/arch/arm/boot/dts/ti/omap/omap2420-n8x0-common.dtsi +++ b/arch/arm/boot/dts/ti/omap/omap2420-n8x0-common.dtsi @@ -109,3 +109,15 @@ partition@5 { }; }; }; + +&mcspi2 { + status = "okay"; + + wifi@0 { + reg = <0>; + compatible = "st,stlc4560"; + spi-max-frequency = <48000000>; + interrupts-extended = <&gpio3 23 IRQ_TYPE_EDGE_RISING>; + powerdown-gpios = <&gpio4 1 GPIO_ACTIVE_LOW>; /* gpio 97 */ + }; +}; -- 2.39.5 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v4 3/3 omap] ARM: dts: omap2: add stlc4560 spi-wireless node 2026-04-30 8:12 ` [PATCH v4 3/3 omap] ARM: dts: omap2: add stlc4560 spi-wireless node Arnd Bergmann @ 2026-04-30 14:19 ` Bartosz Golaszewski 2026-05-05 10:41 ` Linus Walleij 1 sibling, 0 replies; 10+ messages in thread From: Bartosz Golaszewski @ 2026-04-30 14:19 UTC (permalink / raw) To: Arnd Bergmann Cc: Arnd Bergmann, Aaro Koskinen, Andreas Kemnade, Bartosz Golaszewski, Benoît Cousson, David S. Miller, Dmitry Torokhov, Eric Dumazet, Felipe Balbi, Jakub Kicinski, Johannes Berg, Kevin Hilman, Krzysztof Kozlowski, Linus Walleij, Paolo Abeni, Rob Herring, Roger Quadros, Tony Lindgren, linux-wireless, devicetree, linux-kernel, linux-arm-kernel, linux-gpio, linux-omap, Krzysztof Kozlowski, netdev On Thu, 30 Apr 2026 10:12:42 +0200, Arnd Bergmann <arnd@kernel.org> said: > From: Arnd Bergmann <arnd@arndb.de> > > Converted from the platform_device creation in board-n8x0.c. > > Link: https://lore.kernel.org/all/20230314163201.955689-1-arnd@kernel.org/ > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com> ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v4 3/3 omap] ARM: dts: omap2: add stlc4560 spi-wireless node 2026-04-30 8:12 ` [PATCH v4 3/3 omap] ARM: dts: omap2: add stlc4560 spi-wireless node Arnd Bergmann 2026-04-30 14:19 ` Bartosz Golaszewski @ 2026-05-05 10:41 ` Linus Walleij 1 sibling, 0 replies; 10+ messages in thread From: Linus Walleij @ 2026-05-05 10:41 UTC (permalink / raw) To: Arnd Bergmann Cc: netdev, Arnd Bergmann, Aaro Koskinen, Andreas Kemnade, Bartosz Golaszewski, Benoît Cousson, David S. Miller, Dmitry Torokhov, Eric Dumazet, Felipe Balbi, Jakub Kicinski, Johannes Berg, Kevin Hilman, Krzysztof Kozlowski, Paolo Abeni, Rob Herring, Roger Quadros, Tony Lindgren, linux-wireless, devicetree, linux-kernel, linux-arm-kernel, linux-gpio, linux-omap, Krzysztof Kozlowski On Thu, Apr 30, 2026 at 10:13 AM Arnd Bergmann <arnd@kernel.org> wrote: > From: Arnd Bergmann <arnd@arndb.de> > > Converted from the platform_device creation in board-n8x0.c. > > Link: https://lore.kernel.org/all/20230314163201.955689-1-arnd@kernel.org/ > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Linus Walleij <linusw@kernel.org> Yours, Linus Walleij ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v4 3/3 omap] ARM: dts: omap2: add stlc4560 spi-wireless node
@ 2026-05-01 7:27 kernel test robot
0 siblings, 0 replies; 10+ messages in thread
From: kernel test robot @ 2026-05-01 7:27 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp
::::::
:::::: Manual check reason: "dtcheck: binding changes may go via different trees"
::::::
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20260430081242.3686993-4-arnd@kernel.org>
References: <20260430081242.3686993-4-arnd@kernel.org>
TO: Arnd Bergmann <arnd@kernel.org>
TO: netdev@vger.kernel.org
CC: Arnd Bergmann <arnd@arndb.de>
CC: Aaro Koskinen <aaro.koskinen@iki.fi>
CC: Andreas Kemnade <andreas@kemnade.info>
CC: Bartosz Golaszewski <brgl@kernel.org>
CC: "Benoît Cousson" <bcousson@baylibre.com>
CC: Dmitry Torokhov <dmitry.torokhov@gmail.com>
CC: Eric Dumazet <edumazet@google.com>
CC: Felipe Balbi <balbi@kernel.org>
CC: Jakub Kicinski <kuba@kernel.org>
CC: Johannes Berg <johannes@sipsolutions.net>
CC: Kevin Hilman <khilman@baylibre.com>
CC: Krzysztof Kozlowski <krzk@kernel.org>
CC: Linus Walleij <linusw@kernel.org>
CC: Paolo Abeni <pabeni@redhat.com>
CC: Rob Herring <robh+dt@kernel.org>
CC: Roger Quadros <rogerq@kernel.org>
CC: Tony Lindgren <tony@atomide.com>
CC: linux-wireless@vger.kernel.org
CC: devicetree@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: linux-arm-kernel@lists.infradead.org
CC: linux-gpio@vger.kernel.org
CC: linux-omap@vger.kernel.org
Hi Arnd,
kernel test robot noticed the following build warnings:
[auto build test WARNING on wireless-next/main]
[also build test WARNING on wireless/main robh/for-next net/main net-next/main linus/master v7.1-rc1 next-20260430]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Arnd-Bergmann/dt-bindings-net-add-st-stlc4560-p54spi-binding/20260501-012420
base: https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main
patch link: https://lore.kernel.org/r/20260430081242.3686993-4-arnd%40kernel.org
patch subject: [PATCH v4 3/3 omap] ARM: dts: omap2: add stlc4560 spi-wireless node
:::::: branch date: 14 hours ago
:::::: commit date: 14 hours ago
config: openrisc-randconfig-2052-20260501 (https://download.01.org/0day-ci/archive/20260501/202605010927.JSmsDbME-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 15.1.0
dtschema: 2026.5.dev4+g4ccc1997d
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260501/202605010927.JSmsDbME-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202605010927.JSmsDbME-lkp@intel.com/
dtcheck warnings: (new ones prefixed by >>)
>> Documentation/devicetree/bindings/net/wireless/st,stlc4560.yaml: $id: Cannot determine base path from $id, relative path/filename doesn't match actual path or filename
$id: http://devicetree.org/schemas/net/wireless/st,stlc45xx.yaml
file: Documentation/devicetree/bindings/net/wireless/st,stlc4560.yaml
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 10+ messages in threadend of thread, other threads:[~2026-05-05 10:42 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-04-30 8:12 [PATCH v4 0/3] wireless: p54 devicetree conversion Arnd Bergmann 2026-04-30 8:12 ` [PATCH v4 1/3 net-next] dt-bindings: net: add st,stlc4560/p54spi binding Arnd Bergmann 2026-04-30 9:25 ` Rob Herring (Arm) 2026-04-30 9:58 ` Arnd Bergmann 2026-04-30 8:12 ` [PATCH v4 2/3 net-next] p54spi: convert to devicetree Arnd Bergmann 2026-05-05 10:37 ` Linus Walleij 2026-04-30 8:12 ` [PATCH v4 3/3 omap] ARM: dts: omap2: add stlc4560 spi-wireless node Arnd Bergmann 2026-04-30 14:19 ` Bartosz Golaszewski 2026-05-05 10:41 ` Linus Walleij -- strict thread matches above, loose matches on Subject: below -- 2026-05-01 7:27 kernel test robot
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.