+ selftests-cgroup-fix-hardcoded-page-size-in-test_percpu_basic.patch added to mm-new branch

+ selftests-cgroup-fix-hardcoded-page-size-in-test_percpu_basic.patch added to mm-new branch

[Andrew Morton]

The patch titled
     Subject: selftests/cgroup: fix hardcoded page size in test_percpu_basic
has been added to the -mm mm-new branch.  Its filename is
     selftests-cgroup-fix-hardcoded-page-size-in-test_percpu_basic.patch

This patch will shortly appear at
     https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/selftests-cgroup-fix-hardcoded-page-size-in-test_percpu_basic.patch

This patch will later appear in the mm-new branch at
    git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

Note, mm-new is a provisional staging ground for work-in-progress
patches, and acceptance into mm-new is a notification for others take
notice and to finish up reviews.  Please do not hesitate to respond to
review feedback and post updated versions to replace or incrementally
fixup patches in mm-new.

The mm-new branch of mm.git is not included in linux-next

If a few days of testing in mm-new is successful, the patch will me moved
into mm.git's mm-unstable branch, which is included in linux-next

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next via various
branches at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there most days

------------------------------------------------------
From: Li Wang <li.wang@linux.dev>
Subject: selftests/cgroup: fix hardcoded page size in test_percpu_basic
Date: Fri, 1 May 2026 10:20:57 +0800

Patch series "selftests/cgroup: Fix false positive failures in
test_percpu_basic", v2.

This patch series addresses two separate issues that cause false
positive failures in the test_percpu_basic test within the cgroup
kmem selftests.

The first issue stems from a hardcoded assumption about the system
page size, which breaks the test on architectures with larger page
sizes.

The second issue is an overly strict memory check that fails to
account for the slab metadata allocated during cgroup creation.


Thi patch (of 2):

MAX_VMSTAT_ERROR uses a hardcoded page size of 4096, which assumes 4K
pages.  This causes test_percpu_basic to fail on systems where the kernel
is configured with a larger page size, such as aarch64 systems using 16K
or 64K pages, where the maximum permissible discrepancy between
memory.current and percpu charges is proportionally larger.

Replace the hardcoded 4096 with sysconf(_SC_PAGESIZE) to correctly derive
the page size at runtime regardless of the underlying architecture or
kernel configuration.

Link: https://lore.kernel.org/20260501022058.18024-1-li.wang@linux.dev
Link: https://lore.kernel.org/20260501022058.18024-2-li.wang@linux.dev
Signed-off-by: Li Wang <li.wang@linux.dev>
Acked-by: Waiman Long <longman@redhat.com>
Cc: Christoph Lameter <cl@linux.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Shakeel Butt <shakeelb@google.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 tools/testing/selftests/cgroup/test_kmem.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/tools/testing/selftests/cgroup/test_kmem.c~selftests-cgroup-fix-hardcoded-page-size-in-test_percpu_basic
+++ a/tools/testing/selftests/cgroup/test_kmem.c
@@ -24,7 +24,7 @@
  * the maximum discrepancy between charge and vmstat entries is number
  * of cpus multiplied by 64 pages.
  */
-#define MAX_VMSTAT_ERROR (4096 * 64 * get_nprocs())
+#define MAX_VMSTAT_ERROR (sysconf(_SC_PAGESIZE) * 64 * get_nprocs())
 
 #define KMEM_DEAD_WAIT_RETRIES        80
 
_

Patches currently in -mm which might be from li.wang@linux.dev are

selftests-cgroup-skip-test_zswap-if-zswap-is-globally-disabled.patch
selftests-cgroup-avoid-oom-in-test_swapin_nozswap.patch
selftests-cgroup-use-runtime-page-size-for-zswpin-check.patch
selftests-cgroup-rename-page_size-to-buf_size-in-cgroup_util.patch
selftests-cgroup-replace-hardcoded-page-size-values-in-test_zswap.patch
selftest-cgroup-fix-zswap-test_no_invasive_cgroup_shrink-on-large-pagesize-system.patch
selftest-cgroup-fix-zswap-attempt_writeback-on-64k-pagesize-system.patch
selftests-cgroup-test_zswap-wait-for-asynchronous-writeback.patch
selftests-cgroup-fix-hardcoded-page-size-in-test_percpu_basic.patch
selftests-cgroup-include-slab-in-test_percpu_basic-memory-check.patch

Re: + selftests-cgroup-fix-hardcoded-page-size-in-test_percpu_basic.patch added to mm-new branch

[SeongJae Park]

On Fri, 01 May 2026 05:35:46 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:

> 
> The patch titled
>      Subject: selftests/cgroup: fix hardcoded page size in test_percpu_basic
> has been added to the -mm mm-new branch.  Its filename is
>      selftests-cgroup-fix-hardcoded-page-size-in-test_percpu_basic.patch
[...]
> ------------------------------------------------------
> From: Li Wang <li.wang@linux.dev>
> Subject: selftests/cgroup: fix hardcoded page size in test_percpu_basic
> Date: Fri, 1 May 2026 10:20:57 +0800
> 
> Patch series "selftests/cgroup: Fix false positive failures in
> test_percpu_basic", v2.
> 
> This patch series addresses two separate issues that cause false
> positive failures in the test_percpu_basic test within the cgroup
> kmem selftests.
> 
> The first issue stems from a hardcoded assumption about the system
> page size, which breaks the test on architectures with larger page
> sizes.
> 
> The second issue is an overly strict memory check that fails to
> account for the slab metadata allocated during cgroup creation.
> 
> 
> Thi patch (of 2):

Nit.  s/Thi/This/


Thanks,
SJ

[...]