From: Rohit Chavan <roheetchavan@gmail.com>
To: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Rohit Chavan <roheetchavan@gmail.com>
Subject: [PATCH] nvme: use str_enabled_disabled() for digest mismatch messages
Date: Mon, 4 May 2026 18:05:55 +0530 [thread overview]
Message-ID: <20260504123555.1741525-1-roheetchavan@gmail.com> (raw)
Replace open-coded ternary expressions with str_enabled_disabled()
when printing data and header digest mismatch messages in
nvme_tcp_init_connection().
This makes the code more readable and consistent with existing
helpers used for boolean string representation.
No functional change intended.
Signed-off-by: Rohit Chavan <roheetchavan@gmail.com>
---
drivers/nvme/host/tcp.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
index 243dab830dc8..b3165cd79a31 100644
--- a/drivers/nvme/host/tcp.c
+++ b/drivers/nvme/host/tcp.c
@@ -8,6 +8,7 @@
#include <linux/init.h>
#include <linux/slab.h>
#include <linux/err.h>
+#include <linux/string_choices.h>
#include <linux/crc32.h>
#include <linux/nvme-tcp.h>
#include <linux/nvme-keyring.h>
@@ -1550,8 +1551,8 @@ static int nvme_tcp_init_connection(struct nvme_tcp_queue *queue)
(!queue->data_digest && ctrl_ddgst)) {
pr_err("queue %d: data digest mismatch host: %s ctrl: %s\n",
nvme_tcp_queue_id(queue),
- queue->data_digest ? "enabled" : "disabled",
- ctrl_ddgst ? "enabled" : "disabled");
+ str_enabled_disabled(queue->data_digest),
+ str_enabled_disabled(ctrl_ddgst));
goto free_icresp;
}
@@ -1560,8 +1561,8 @@ static int nvme_tcp_init_connection(struct nvme_tcp_queue *queue)
(!queue->hdr_digest && ctrl_hdgst)) {
pr_err("queue %d: header digest mismatch host: %s ctrl: %s\n",
nvme_tcp_queue_id(queue),
- queue->hdr_digest ? "enabled" : "disabled",
- ctrl_hdgst ? "enabled" : "disabled");
+ str_enabled_disabled(queue->hdr_digest),
+ str_enabled_disabled(ctrl_hdgst);
goto free_icresp;
}
--
2.34.1
next reply other threads:[~2026-05-04 12:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 12:35 Rohit Chavan [this message]
2026-05-07 5:32 ` [PATCH] nvme: use str_enabled_disabled() for digest mismatch messages Christoph Hellwig
2026-05-08 9:47 ` Rohit Chavan
2026-05-11 8:14 ` Christoph Hellwig
2026-05-14 20:21 ` kernel test robot
2026-05-14 20:42 ` kernel test robot
2026-05-14 21:25 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260504123555.1741525-1-roheetchavan@gmail.com \
--to=roheetchavan@gmail.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.