From: Christoph Hellwig <hch@infradead.org>
To: Rohit Chavan <roheetchavan@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
kbusch@kernel.org, axboe@kernel.dk, sagi@grimberg.me,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme: use str_enabled_disabled() for digest mismatch messages
Date: Mon, 11 May 2026 01:14:57 -0700 [thread overview]
Message-ID: <agGQAU0K_9PBj6k7@infradead.org> (raw)
In-Reply-To: <20260508094734.2032284-1-roheetchavan@gmail.com>
On Fri, May 08, 2026 at 03:17:33PM +0530, Rohit Chavan wrote:
> Hi Christoph,
>
> Thank you for the feedback.
>
> My intent was to align the code with the standardized string helpers
> recently introduced in the kernel to reduce open-coding. However,
> I respect your preference for keeping the ternary form in the
> NVMe subsystem.
I guess it's more of a question for the people adding the helpers, but it
should also be in any place converting to it: what's the point?
The helpers don't reduce the code size, but increase cognitive load. Not
a good trade-off as far as I can tell, but maybe I'm missing something?
next prev parent reply other threads:[~2026-05-11 8:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 12:35 [PATCH] nvme: use str_enabled_disabled() for digest mismatch messages Rohit Chavan
2026-05-07 5:32 ` Christoph Hellwig
2026-05-08 9:47 ` Rohit Chavan
2026-05-11 8:14 ` Christoph Hellwig [this message]
2026-05-14 20:21 ` kernel test robot
2026-05-14 20:42 ` kernel test robot
2026-05-14 21:25 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agGQAU0K_9PBj6k7@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=roheetchavan@gmail.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.