All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] staging: rtl8723bs: add braces to if/else statements
@ 2026-05-01 20:31 Siwanan Bungtong
  2026-05-01 20:31 ` [PATCH 1/2] staging: rtl8723bs: add braces to if/else arms in rtw_efuse.c Siwanan Bungtong
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Siwanan Bungtong @ 2026-05-01 20:31 UTC (permalink / raw)
  To: gregkh
  Cc: linux-kernel, linux-staging, straube.linux, ignacio.pena87,
	Siwanan Bungtong

This series adds missing braces to if/else statements in rtl8723bs
to comply with the kernel coding style and improve code readability.

No functional changes.

Siwanan Bungtong (2):
  staging: rtl8723bs: add braces to if/else arms in rtw_efuse.c
  staging: rtl8723bs: add braces to if/else arms in HalBtc8723b1Ant.c

 drivers/staging/rtl8723bs/core/rtw_efuse.c      | 4 ++--
 drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 7 ++++---
 2 files changed, 6 insertions(+), 5 deletions(-)

-- 
2.53.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/2] staging: rtl8723bs: add braces to if/else arms in rtw_efuse.c
  2026-05-01 20:31 [PATCH 0/2] staging: rtl8723bs: add braces to if/else statements Siwanan Bungtong
@ 2026-05-01 20:31 ` Siwanan Bungtong
  2026-05-04 14:52   ` Greg KH
  2026-05-01 20:31 ` [PATCH 2/2] staging: rtl8723bs: add braces to if/else arms in HalBtc8723b1Ant.c Siwanan Bungtong
  2026-05-04 12:33 ` [PATCH 0/2] staging: rtl8723bs: add braces to if/else statements Nikolay Kulikov
  2 siblings, 1 reply; 5+ messages in thread
From: Siwanan Bungtong @ 2026-05-01 20:31 UTC (permalink / raw)
  To: gregkh
  Cc: linux-kernel, linux-staging, straube.linux, ignacio.pena87,
	Siwanan Bungtong

Add missing braces to if/else statements to comply with kernel
coding style and improve readability.

No functional changes.

Signed-off-by: Siwanan Bungtong <horstaufmental@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_efuse.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
index 099320e4eb50..7600b723fda3 100644
--- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
@@ -76,9 +76,9 @@ u16		Address)
 				break;
 		}
 		return rtw_read8(Adapter, EFUSE_CTRL);
-	} else
+	} else {
 		return 0xFF;
-
+	}
 } /* EFUSE_Read1Byte */
 
 /*  11/16/2008 MH Read one byte from real Efuse. */
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] staging: rtl8723bs: add braces to if/else arms in HalBtc8723b1Ant.c
  2026-05-01 20:31 [PATCH 0/2] staging: rtl8723bs: add braces to if/else statements Siwanan Bungtong
  2026-05-01 20:31 ` [PATCH 1/2] staging: rtl8723bs: add braces to if/else arms in rtw_efuse.c Siwanan Bungtong
@ 2026-05-01 20:31 ` Siwanan Bungtong
  2026-05-04 12:33 ` [PATCH 0/2] staging: rtl8723bs: add braces to if/else statements Nikolay Kulikov
  2 siblings, 0 replies; 5+ messages in thread
From: Siwanan Bungtong @ 2026-05-01 20:31 UTC (permalink / raw)
  To: gregkh
  Cc: linux-kernel, linux-staging, straube.linux, ignacio.pena87,
	Siwanan Bungtong

Add missing braces to if/else statements to comply with kernel
coding style and improve readability.

No functional changes.

Signed-off-by: Siwanan Bungtong <horstaufmental@gmail.com>
---
 drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
index b3e34f97cfc6..9bef096164fa 100644
--- a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
+++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
@@ -1485,12 +1485,13 @@ static void halbtc8723b1ant_PsTdmaCheckForPowerSaveState(
 	if (lpsMode) {	/*  already under LPS state */
 		if (bNewPsState) {
 			/*  keep state under LPS, do nothing. */
-		} else /*  will leave LPS state, turn off psTdma first */
+		} else { /*  will leave LPS state, turn off psTdma first */
 			halbtc8723b1ant_PsTdma(pBtCoexist, NORMAL_EXEC, false, 0);
+		}
 	} else {						/*  NO PS state */
-		if (bNewPsState) /*  will enter LPS state, turn off psTdma first */
+		if (bNewPsState) { /*  will enter LPS state, turn off psTdma first */
 			halbtc8723b1ant_PsTdma(pBtCoexist, NORMAL_EXEC, false, 0);
-		else {
+		} else {
 			/*  keep state under NO PS state, do nothing. */
 		}
 	}
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/2] staging: rtl8723bs: add braces to if/else statements
  2026-05-01 20:31 [PATCH 0/2] staging: rtl8723bs: add braces to if/else statements Siwanan Bungtong
  2026-05-01 20:31 ` [PATCH 1/2] staging: rtl8723bs: add braces to if/else arms in rtw_efuse.c Siwanan Bungtong
  2026-05-01 20:31 ` [PATCH 2/2] staging: rtl8723bs: add braces to if/else arms in HalBtc8723b1Ant.c Siwanan Bungtong
@ 2026-05-04 12:33 ` Nikolay Kulikov
  2 siblings, 0 replies; 5+ messages in thread
From: Nikolay Kulikov @ 2026-05-04 12:33 UTC (permalink / raw)
  To: Siwanan Bungtong
  Cc: gregkh, linux-kernel, linux-staging, straube.linux,
	ignacio.pena87

On Sat, May 02, 2026 at 03:31:19AM +0700, Siwanan Bungtong wrote:
> This series adds missing braces to if/else statements in rtl8723bs
> to comply with the kernel coding style and improve code readability.
> 
> No functional changes.
> 
> Siwanan Bungtong (2):
>   staging: rtl8723bs: add braces to if/else arms in rtw_efuse.c
>   staging: rtl8723bs: add braces to if/else arms in HalBtc8723b1Ant.c
> 
>  drivers/staging/rtl8723bs/core/rtw_efuse.c      | 4 ++--
>  drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 7 ++++---
>  2 files changed, 6 insertions(+), 5 deletions(-)
> 

This is not applicable to staging-next, please rebase.

Thanks,
Nikolay

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] staging: rtl8723bs: add braces to if/else arms in rtw_efuse.c
  2026-05-01 20:31 ` [PATCH 1/2] staging: rtl8723bs: add braces to if/else arms in rtw_efuse.c Siwanan Bungtong
@ 2026-05-04 14:52   ` Greg KH
  0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2026-05-04 14:52 UTC (permalink / raw)
  To: Siwanan Bungtong
  Cc: linux-kernel, linux-staging, straube.linux, ignacio.pena87

On Sat, May 02, 2026 at 03:31:20AM +0700, Siwanan Bungtong wrote:
> Add missing braces to if/else statements to comply with kernel
> coding style and improve readability.
> 
> No functional changes.
> 
> Signed-off-by: Siwanan Bungtong <horstaufmental@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_efuse.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> index 099320e4eb50..7600b723fda3 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> @@ -76,9 +76,9 @@ u16		Address)
>  				break;
>  		}
>  		return rtw_read8(Adapter, EFUSE_CTRL);
> -	} else
> +	} else {
>  		return 0xFF;
> -
> +	}
>  } /* EFUSE_Read1Byte */
>  
>  /*  11/16/2008 MH Read one byte from real Efuse. */
> -- 
> 2.53.0
> 
> 

Does not apply to my tree :(

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-05-04 14:58 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-01 20:31 [PATCH 0/2] staging: rtl8723bs: add braces to if/else statements Siwanan Bungtong
2026-05-01 20:31 ` [PATCH 1/2] staging: rtl8723bs: add braces to if/else arms in rtw_efuse.c Siwanan Bungtong
2026-05-04 14:52   ` Greg KH
2026-05-01 20:31 ` [PATCH 2/2] staging: rtl8723bs: add braces to if/else arms in HalBtc8723b1Ant.c Siwanan Bungtong
2026-05-04 12:33 ` [PATCH 0/2] staging: rtl8723bs: add braces to if/else statements Nikolay Kulikov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.