From: sashiko-bot@kernel.org
To: "Ethan Nelson-Moore" <enelsonmoore@gmail.com>
Cc: linux-watchdog@vger.kernel.org
Subject: Re: [PATCH] watchdog: remove drivers for discrete ISA WDT cards
Date: Tue, 05 May 2026 03:11:59 +0000 [thread overview]
Message-ID: <20260505031200.76950C2BCB8@smtp.kernel.org> (raw)
In-Reply-To: <20260505023007.58175-1-enelsonmoore@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incomplete cleanup of removed ISA watchdog drivers (stale documentation).
--
commit c15c9debaf78e0e06a920a66f6ec58e1cd3c2f62
Author: Ethan Nelson-Moore <enelsonmoore@gmail.com>
watchdog: remove drivers for discrete ISA WDT cards
This commit removes the mixcomwd, pcwd, and wdt drivers that support
obsolete discrete ISA watchdog cards.
> The mixcomwd, pcwd, and wdt (how generic!) drivers support discrete ISA
> watchdog cards. The wdt driver in particular does not support
> autoprobing and requires manual specification of the I/O port and IRQ
> the card uses. A WDT is integrated into many modern chipsets and Super
> I/O chips. Embedded boards using a WDT, even ones with ISA slots, are
> unlikely to do so via a discrete ISA card due to the amount of space
> required. Given these factors, it is highly unlikely anyone is using
> these drivers. Remove them.
Does this code removal also need to clean up the corresponding documentation?
It looks like the commit removes the mixcomwd, pcwd, and wdt drivers, but
leaves their documentation intact:
- Documentation/watchdog/pcwd-watchdog.rst explicitly documents the removed
pcwd ISA driver.
- Documentation/watchdog/wdt.rst provides obsolete boot parameter examples
(wdt.io and wdt.irq) for the removed wdt driver.
- Documentation/watchdog/watchdog-parameters.rst contains stale module
parameter entries for the removed mixcomwd driver.
- Documentation/watchdog/index.rst still includes links to the orphaned
files in its toctree.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260505023007.58175-1-enelsonmoore@gmail.com?part=1
next prev parent reply other threads:[~2026-05-05 3:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 2:30 [PATCH] watchdog: remove drivers for discrete ISA WDT cards Ethan Nelson-Moore
2026-05-05 3:11 ` sashiko-bot [this message]
2026-05-05 4:59 ` Guenter Roeck
2026-05-05 5:39 ` Ethan Nelson-Moore
2026-05-05 13:05 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260505031200.76950C2BCB8@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=enelsonmoore@gmail.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=sashiko@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.