All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Palmer <daniel@thingy.jp>
To: trini@konsulko.com
Cc: visitorckw@gmail.com, angelo@kernel-space.org,
	bmeng.cn@gmail.com, sjg@chromium.org, u-boot@lists.denx.de,
	Daniel Palmer <daniel@thingy.jp>
Subject: [PATCH v6 2/8] rtc: goldfish: Use __raw_readl() and __raw_writel()
Date: Tue,  5 May 2026 16:49:35 +0900	[thread overview]
Message-ID: <20260505074948.2603870-3-daniel@thingy.jp> (raw)
In-Reply-To: <20260505074948.2603870-1-daniel@thingy.jp>

From: Kuan-Wei Chiu <visitorckw@gmail.com>

In QEMU, the Goldfish RTC is explicitly instantiated as a big-endian
device on the m68k virt machine (via the 'big-endian=true' property).
Currently, this driver uses ioread32() and iowrite32(), which works
by luck because the underlying readl() and writel() are currently
broken on m68k.

Use __raw_readl() and __raw_writel() instead to avoid breaking this
driver when the endianness of readl() and writel() is fixed.

Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
Tested-by: Daniel Palmer <daniel@thingy.jp>
Signed-off-by: Daniel Palmer <daniel@thingy.jp>
---
 drivers/rtc/goldfish_rtc.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/rtc/goldfish_rtc.c b/drivers/rtc/goldfish_rtc.c
index d2991ca67192..4892a63f8d80 100644
--- a/drivers/rtc/goldfish_rtc.c
+++ b/drivers/rtc/goldfish_rtc.c
@@ -40,8 +40,8 @@ static int goldfish_rtc_get(struct udevice *dev, struct rtc_time *time)
 	u64 time_low;
 	u64 now;
 
-	time_low = ioread32(base + GOLDFISH_TIME_LOW);
-	time_high = ioread32(base + GOLDFISH_TIME_HIGH);
+	time_low = __raw_readl(base + GOLDFISH_TIME_LOW);
+	time_high = __raw_readl(base + GOLDFISH_TIME_HIGH);
 	now = (time_high << 32) | time_low;
 
 	do_div(now, 1000000000U);
@@ -62,8 +62,8 @@ static int goldfish_rtc_set(struct udevice *dev, const struct rtc_time *time)
 		return -EINVAL;
 
 	now = rtc_mktime(time) * 1000000000ULL;
-	iowrite32(now >> 32, base + GOLDFISH_TIME_HIGH);
-	iowrite32(now, base + GOLDFISH_TIME_LOW);
+	__raw_writel(now >> 32, base + GOLDFISH_TIME_HIGH);
+	__raw_writel(now, base + GOLDFISH_TIME_LOW);
 
 	if (time->tm_isdst > 0)
 		priv->isdst = 1;
-- 
2.53.0


  parent reply	other threads:[~2026-05-05  7:50 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-05  7:49 [PATCH v6 0/8] Add virtio-mmio support to m68k virt machine Daniel Palmer
2026-05-05  7:49 ` [PATCH v6 1/8] sysreset: qemu virt: Use __raw_writel() Daniel Palmer
2026-05-05  7:49 ` Daniel Palmer [this message]
2026-05-07 13:27   ` [PATCH v6 2/8] rtc: goldfish: Use __raw_readl() and __raw_writel() Simon Glass
2026-05-05  7:49 ` [PATCH v6 3/8] timer: goldfish: Use __raw_readl() Daniel Palmer
2026-05-07 13:27   ` Simon Glass
2026-05-05  7:49 ` [PATCH v6 4/8] m68k: Fix writew(), writel(), readw(), readl() endianness for classic m68k Daniel Palmer
2026-05-05  7:49 ` [PATCH v6 5/8] virtio: mmio: Allow instantiation via platform data Daniel Palmer
2026-05-05  7:49 ` [PATCH v6 6/8] virtio: cmd: Depend on VIRTIO_BLK Daniel Palmer
2026-05-05  7:49 ` [PATCH v6 7/8] virtio: blk: Fix converting the vendor id to a string Daniel Palmer
2026-05-05  7:49 ` [PATCH v6 8/8] board: qemu: m68k: Create virtio mmio instances Daniel Palmer
2026-05-07 17:13   ` Kuan-Wei Chiu
2026-05-08 19:29 ` [PATCH v6 0/8] Add virtio-mmio support to m68k virt machine Tom Rini
2026-05-11  8:50   ` Daniel Palmer
2026-05-11 15:00     ` Tom Rini
2026-05-14 12:35       ` Daniel Palmer
2026-05-14 13:51         ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260505074948.2603870-3-daniel@thingy.jp \
    --to=daniel@thingy.jp \
    --cc=angelo@kernel-space.org \
    --cc=bmeng.cn@gmail.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=visitorckw@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.