Re: [PATCH v6 0/8] Add virtio-mmio support to m68k virt machine

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1900 bytes --]

On Tue, May 05, 2026 at 04:49:33PM +0900, Daniel Palmer wrote:

> Lets start making the m68k virt machine support useful.
> 
> First we need to fix some m68k endian issues.
> 
> Then allow virtio mmio driver instances to be created with
> platform data and fix a minor endian issue.
> 
> Finally, add the code for the board to create the instances.
> 
> v6:
>   - Remove an extra signed-of-by that go added by b4 or me somehow.
>   - Fix the warning about a phys_addr_t being cast to a pointer of different
>     size if phys_addr_t is 32bits but the target cpu is 64bits.
> 
>   CC      drivers/virtio/virtio_mmio.o
> drivers/virtio/virtio_mmio.c: In function ‘virtio_mmio_probe’:
> drivers/virtio/virtio_mmio.c:359:22: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>   359 |         priv->base = (void __iomem *)plat->base;
>       |

We hit another error in CI now, with "allyesconfig":
drivers/sysreset/sysreset_qemu_virt_ctrl.c: In function 'qemu_virt_ctrl_request':
drivers/sysreset/sysreset_qemu_virt_ctrl.c:41:37: error: passing argument 2 of '__raw_writel' makes pointer from integer without a cast [-Werror=int-conversion]
   41 |         __raw_writel(val, plat->reg + VIRT_CTRL_REG_CMD);
      |                                     ^
      |                                     |
      |                                     phys_addr_t {aka long long unsigned int}
In file included from ./arch/sandbox/include/asm/io.h:257,
                 from drivers/sysreset/sysreset_qemu_virt_ctrl.c:11:
include/asm-generic/io.h:168:67: note: expected 'volatile void *' but argument is of type 'phys_addr_t' {aka 'long long unsigned int'}
  168 | static inline void __raw_writel(u32 value, volatile void __iomem *addr)
      |

Please see https://docs.u-boot.org/en/latest/develop/ci_testing.html for
v7, thanks.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]