From: Jakub Kicinski <kuba@kernel.org>
To: Danielle Ratson <danieller@nvidia.com>
Cc: <netdev@vger.kernel.org>, <donald.hunter@gmail.com>,
<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<horms@kernel.org>, <razor@blackwall.org>, <idosch@nvidia.com>,
<andrew+netdev@lunn.ch>, <shuah@kernel.org>, <ast@fiberby.net>,
<liuhangbin@gmail.com>, <daniel@iogearbox.net>,
<aroulin@nvidia.com>, <fmaurer@redhat.com>,
<sdf.kernel@gmail.com>, <sd@queasysnail.net>, <kees@kernel.org>,
<nickgarlis@gmail.com>, <amorenoz@redhat.com>,
<alasdair@mcwilliam.dev>,
<johannes.wiesboeck@aisec.fraunhofer.de>, <petrm@nvidia.com>,
<linux-kernel@vger.kernel.org>, <bridge@lists.linux.dev>,
<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH net-next 1/6] bridge: uapi: Add neigh_forward_grat netlink attributes
Date: Tue, 5 May 2026 19:00:44 -0700 [thread overview]
Message-ID: <20260505190044.0608dfb1@kernel.org> (raw)
In-Reply-To: <20260503073532.2138165-2-danieller@nvidia.com>
On Sun, 3 May 2026 10:35:27 +0300 Danielle Ratson wrote:
> --- a/Documentation/netlink/specs/rt-link.yaml
> +++ b/Documentation/netlink/specs/rt-link.yaml
> @@ -1700,6 +1700,9 @@ attribute-sets:
> -
> name: backup-nhid
> type: u32
> + -
> + name: neigh-forward-grat
> + type: flag
I think this should be u8 ? neigh-vlan-suppress looks buggy too
flag is a type without a payload, the presence of the attr is
the entire information
None of the AIs seem to catch this, I think you may have over-split
this submission a little bit. This patch may have been better off
squashed into patch 4 ?
--
pw-bot: cr
next prev parent reply other threads:[~2026-05-06 2:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-03 7:35 [PATCH net-next 0/6] bridge: Add selective forwarding of gratuitous neighbor announcements Danielle Ratson
2026-05-03 7:35 ` [PATCH net-next 1/6] bridge: uapi: Add neigh_forward_grat netlink attributes Danielle Ratson
2026-05-04 7:41 ` Nikolay Aleksandrov
2026-05-06 2:00 ` Jakub Kicinski [this message]
2026-05-06 7:03 ` Ido Schimmel
2026-05-06 8:31 ` Danielle Ratson
2026-05-06 22:05 ` Jakub Kicinski
2026-05-07 6:54 ` Ido Schimmel
2026-05-03 7:35 ` [PATCH net-next 2/6] bridge: Add internal flags for neigh_forward_grat Danielle Ratson
2026-05-04 7:41 ` Nikolay Aleksandrov
2026-05-03 7:35 ` [PATCH net-next 3/6] bridge: Add selective forwarding of gratuitous neighbor announcements Danielle Ratson
2026-05-04 7:41 ` Nikolay Aleksandrov
2026-05-03 7:35 ` [PATCH net-next 4/6] bridge: Add port-level netlink handling for neigh_forward_grat Danielle Ratson
2026-05-04 7:42 ` Nikolay Aleksandrov
2026-05-03 7:35 ` [PATCH net-next 5/6] bridge: Add per-VLAN " Danielle Ratson
2026-05-04 7:43 ` Nikolay Aleksandrov
2026-05-03 7:35 ` [PATCH net-next 6/6] selftests: net: Add tests for neigh_forward_grat option Danielle Ratson
2026-05-04 7:44 ` Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260505190044.0608dfb1@kernel.org \
--to=kuba@kernel.org \
--cc=alasdair@mcwilliam.dev \
--cc=amorenoz@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=aroulin@nvidia.com \
--cc=ast@fiberby.net \
--cc=bridge@lists.linux.dev \
--cc=daniel@iogearbox.net \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=fmaurer@redhat.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=johannes.wiesboeck@aisec.fraunhofer.de \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nickgarlis@gmail.com \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=razor@blackwall.org \
--cc=sd@queasysnail.net \
--cc=sdf.kernel@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.