From: Ido Schimmel <idosch@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Danielle Ratson <danieller@nvidia.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"donald.hunter@gmail.com" <donald.hunter@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"horms@kernel.org" <horms@kernel.org>,
"razor@blackwall.org" <razor@blackwall.org>,
"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"shuah@kernel.org" <shuah@kernel.org>,
"ast@fiberby.net" <ast@fiberby.net>,
"liuhangbin@gmail.com" <liuhangbin@gmail.com>,
"daniel@iogearbox.net" <daniel@iogearbox.net>,
Andy Roulin <aroulin@nvidia.com>,
"fmaurer@redhat.com" <fmaurer@redhat.com>,
"sdf.kernel@gmail.com" <sdf.kernel@gmail.com>,
"sd@queasysnail.net" <sd@queasysnail.net>,
"kees@kernel.org" <kees@kernel.org>,
"nickgarlis@gmail.com" <nickgarlis@gmail.com>,
"amorenoz@redhat.com" <amorenoz@redhat.com>,
"alasdair@mcwilliam.dev" <alasdair@mcwilliam.dev>,
"johannes.wiesboeck@aisec.fraunhofer.de"
<johannes.wiesboeck@aisec.fraunhofer.de>,
Petr Machata <petrm@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"bridge@lists.linux.dev" <bridge@lists.linux.dev>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH net-next 1/6] bridge: uapi: Add neigh_forward_grat netlink attributes
Date: Thu, 7 May 2026 09:54:03 +0300 [thread overview]
Message-ID: <20260507065403.GA815358@shredder> (raw)
In-Reply-To: <20260506150556.4e540854@kernel.org>
On Wed, May 06, 2026 at 03:05:56PM -0700, Jakub Kicinski wrote:
> > > Related: The AI also did not catch that the spec was missing (easy
> > > to forget for rtnetlink). Do you think it's worth adding to
> > > review-prompts?
>
> I assumed Sashiko missed this because it doesn't spent too much time on
> the series as a whole right now (I was going to tweak that but looks
> like Claude is having another meltdown, crazy inference latency,
> patches backlogging for review..)
>
> Are you saying that the review prompts-based test is also not catching
> this even if you give it the range of commits that form the series?
Yes. I noticed this during the STP mode review:
https://lore.kernel.org/netdev/20260324200051.GA572287@shredder/
Where the entire code changes are in a single patch.
AI review of this patch:
https://sashiko.dev/#/patchset/20260324184942.2828691-1-aroulin%40nvidia.com
https://netdev-ai.bots.linux.dev/ai-review.html?id=d0cd7a7e-a803-45df-8121-555484a45315#patch-0
We can try to add this to the review-prompts and see if it helps.
next prev parent reply other threads:[~2026-05-07 6:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-03 7:35 [PATCH net-next 0/6] bridge: Add selective forwarding of gratuitous neighbor announcements Danielle Ratson
2026-05-03 7:35 ` [PATCH net-next 1/6] bridge: uapi: Add neigh_forward_grat netlink attributes Danielle Ratson
2026-05-04 7:41 ` Nikolay Aleksandrov
2026-05-06 2:00 ` Jakub Kicinski
2026-05-06 7:03 ` Ido Schimmel
2026-05-06 8:31 ` Danielle Ratson
2026-05-06 22:05 ` Jakub Kicinski
2026-05-07 6:54 ` Ido Schimmel [this message]
2026-05-03 7:35 ` [PATCH net-next 2/6] bridge: Add internal flags for neigh_forward_grat Danielle Ratson
2026-05-04 7:41 ` Nikolay Aleksandrov
2026-05-03 7:35 ` [PATCH net-next 3/6] bridge: Add selective forwarding of gratuitous neighbor announcements Danielle Ratson
2026-05-04 7:41 ` Nikolay Aleksandrov
2026-05-03 7:35 ` [PATCH net-next 4/6] bridge: Add port-level netlink handling for neigh_forward_grat Danielle Ratson
2026-05-04 7:42 ` Nikolay Aleksandrov
2026-05-03 7:35 ` [PATCH net-next 5/6] bridge: Add per-VLAN " Danielle Ratson
2026-05-04 7:43 ` Nikolay Aleksandrov
2026-05-03 7:35 ` [PATCH net-next 6/6] selftests: net: Add tests for neigh_forward_grat option Danielle Ratson
2026-05-04 7:44 ` Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260507065403.GA815358@shredder \
--to=idosch@nvidia.com \
--cc=alasdair@mcwilliam.dev \
--cc=amorenoz@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=aroulin@nvidia.com \
--cc=ast@fiberby.net \
--cc=bridge@lists.linux.dev \
--cc=daniel@iogearbox.net \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=fmaurer@redhat.com \
--cc=horms@kernel.org \
--cc=johannes.wiesboeck@aisec.fraunhofer.de \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nickgarlis@gmail.com \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=razor@blackwall.org \
--cc=sd@queasysnail.net \
--cc=sdf.kernel@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.