All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: i2c: convert axxia i2c to dt-schema
@ 2026-05-05 10:08 Chaitanya Sabnis
  2026-05-07 19:29 ` Rob Herring
  0 siblings, 1 reply; 3+ messages in thread
From: Chaitanya Sabnis @ 2026-05-05 10:08 UTC (permalink / raw)
  To: andi.shyti, wsa, anders.berg
  Cc: robh, krzk+dt, conor+dt, linux-i2c, devicetree, linux-kernel,
	Chaitanya Sabnis

Convert the LSI Axxia I2C Controller bindings from legacy text
format to modern dt-schema (YAML).

During the conversion, the obsolete `device_type = "i2c"` property
was dropped from the example, as it is deprecated and not utilized
by the driver. The `clock-names` property is enforced as required
matching the driver probe behavior. The example node address was
also updated to a standard 32-bit address.

Signed-off-by: Chaitanya Sabnis <chaitanya.msabnis@gmail.com>
---
 .../devicetree/bindings/i2c/i2c-axxia.txt     | 30 -----------
 .../devicetree/bindings/i2c/lsi,api2c.yaml    | 52 +++++++++++++++++++
 2 files changed, 52 insertions(+), 30 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-axxia.txt
 create mode 100644 Documentation/devicetree/bindings/i2c/lsi,api2c.yaml

diff --git a/Documentation/devicetree/bindings/i2c/i2c-axxia.txt b/Documentation/devicetree/bindings/i2c/i2c-axxia.txt
deleted file mode 100644
index 7d53a2b79553..000000000000
--- a/Documentation/devicetree/bindings/i2c/i2c-axxia.txt
+++ /dev/null
@@ -1,30 +0,0 @@
-LSI Axxia I2C
-
-Required properties :
-- compatible : Must be "lsi,api2c"
-- reg : Offset and length of the register set for the device
-- interrupts : the interrupt specifier
-- #address-cells : Must be <1>;
-- #size-cells : Must be <0>;
-- clock-names : Must contain "i2c".
-- clocks: Must contain an entry for each name in clock-names. See the common
-  clock bindings.
-
-Optional properties :
-- clock-frequency : Desired I2C bus clock frequency in Hz. If not specified,
-  the default 100 kHz frequency will be used. As only Normal and Fast modes
-  are supported, possible values are 100000 and 400000.
-
-Example :
-
-i2c@2010084000 {
-	compatible = "lsi,api2c";
-	device_type = "i2c";
-	#address-cells = <1>;
-	#size-cells = <0>;
-	reg = <0x20 0x10084000 0x00 0x1000>;
-	interrupts = <0 19 4>;
-	clocks = <&clk_per>;
-	clock-names = "i2c";
-	clock-frequency = <400000>;
-};
diff --git a/Documentation/devicetree/bindings/i2c/lsi,api2c.yaml b/Documentation/devicetree/bindings/i2c/lsi,api2c.yaml
new file mode 100644
index 000000000000..2d1c3069c3a3
--- /dev/null
+++ b/Documentation/devicetree/bindings/i2c/lsi,api2c.yaml
@@ -0,0 +1,52 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/i2c/lsi,api2c.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: LSI Axxia I2C Controller
+
+maintainers:
+  - Anders Berg <anders.berg@lsi.com>
+  - Chaitanya Sabnis <chaitanya.msabnis@gmail.com>
+
+allOf:
+  - $ref: /schemas/i2c/i2c-controller.yaml#
+
+properties:
+  compatible:
+    const: lsi,api2c
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  clock-names:
+    const: i2c
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+  - clock-names
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    i2c@10084000 {
+        compatible = "lsi,api2c";
+        reg = <0x10084000 0x1000>;
+        interrupts = <0 19 4>;
+        clocks = <&clk_per>;
+        clock-names = "i2c";
+        clock-frequency = <400000>;
+        #address-cells = <1>;
+        #size-cells = <0>;
+    };
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: i2c: convert axxia i2c to dt-schema
  2026-05-05 10:08 [PATCH] dt-bindings: i2c: convert axxia i2c to dt-schema Chaitanya Sabnis
@ 2026-05-07 19:29 ` Rob Herring
  2026-06-06  6:30   ` Chaitanya Sabnis
  0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2026-05-07 19:29 UTC (permalink / raw)
  To: Chaitanya Sabnis
  Cc: andi.shyti, wsa, anders.berg, krzk+dt, conor+dt, linux-i2c,
	devicetree, linux-kernel

On Tue, May 05, 2026 at 03:38:54PM +0530, Chaitanya Sabnis wrote:
> Convert the LSI Axxia I2C Controller bindings from legacy text
> format to modern dt-schema (YAML).
> 
> During the conversion, the obsolete `device_type = "i2c"` property
> was dropped from the example, as it is deprecated and not utilized
> by the driver. The `clock-names` property is enforced as required
> matching the driver probe behavior. The example node address was
> also updated to a standard 32-bit address.
> 
> Signed-off-by: Chaitanya Sabnis <chaitanya.msabnis@gmail.com>
> ---
>  .../devicetree/bindings/i2c/i2c-axxia.txt     | 30 -----------
>  .../devicetree/bindings/i2c/lsi,api2c.yaml    | 52 +++++++++++++++++++
>  2 files changed, 52 insertions(+), 30 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-axxia.txt
>  create mode 100644 Documentation/devicetree/bindings/i2c/lsi,api2c.yaml
> 
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-axxia.txt b/Documentation/devicetree/bindings/i2c/i2c-axxia.txt
> deleted file mode 100644
> index 7d53a2b79553..000000000000
> --- a/Documentation/devicetree/bindings/i2c/i2c-axxia.txt
> +++ /dev/null
> @@ -1,30 +0,0 @@
> -LSI Axxia I2C
> -
> -Required properties :
> -- compatible : Must be "lsi,api2c"
> -- reg : Offset and length of the register set for the device
> -- interrupts : the interrupt specifier
> -- #address-cells : Must be <1>;
> -- #size-cells : Must be <0>;
> -- clock-names : Must contain "i2c".
> -- clocks: Must contain an entry for each name in clock-names. See the common
> -  clock bindings.
> -
> -Optional properties :
> -- clock-frequency : Desired I2C bus clock frequency in Hz. If not specified,
> -  the default 100 kHz frequency will be used. As only Normal and Fast modes
> -  are supported, possible values are 100000 and 400000.
> -
> -Example :
> -
> -i2c@2010084000 {
> -	compatible = "lsi,api2c";
> -	device_type = "i2c";
> -	#address-cells = <1>;
> -	#size-cells = <0>;
> -	reg = <0x20 0x10084000 0x00 0x1000>;
> -	interrupts = <0 19 4>;
> -	clocks = <&clk_per>;
> -	clock-names = "i2c";
> -	clock-frequency = <400000>;
> -};
> diff --git a/Documentation/devicetree/bindings/i2c/lsi,api2c.yaml b/Documentation/devicetree/bindings/i2c/lsi,api2c.yaml
> new file mode 100644
> index 000000000000..2d1c3069c3a3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/lsi,api2c.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/i2c/lsi,api2c.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LSI Axxia I2C Controller
> +
> +maintainers:
> +  - Anders Berg <anders.berg@lsi.com>

I don't think lsi.com is valid any more. We'll see if it bounces. 
Otherwise,

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: i2c: convert axxia i2c to dt-schema
  2026-05-07 19:29 ` Rob Herring
@ 2026-06-06  6:30   ` Chaitanya Sabnis
  0 siblings, 0 replies; 3+ messages in thread
From: Chaitanya Sabnis @ 2026-06-06  6:30 UTC (permalink / raw)
  To: Rob Herring
  Cc: andi.shyti, wsa, anders.berg, krzk+dt, conor+dt, linux-i2c,
	devicetree, linux-kernel

Hi Andi and Wolfram,
Just a gentle ping on this patch. It received a Reviewed-by tag from
Rob Herring a month ago.
Is there anything else required from my side to get this merged into
the I2C tree?
Thanks,
Chaitanya

On Fri, May 8, 2026 at 12:59 AM Rob Herring <robh@kernel.org> wrote:
>
> On Tue, May 05, 2026 at 03:38:54PM +0530, Chaitanya Sabnis wrote:
> > Convert the LSI Axxia I2C Controller bindings from legacy text
> > format to modern dt-schema (YAML).
> >
> > During the conversion, the obsolete `device_type = "i2c"` property
> > was dropped from the example, as it is deprecated and not utilized
> > by the driver. The `clock-names` property is enforced as required
> > matching the driver probe behavior. The example node address was
> > also updated to a standard 32-bit address.
> >
> > Signed-off-by: Chaitanya Sabnis <chaitanya.msabnis@gmail.com>
> > ---
> >  .../devicetree/bindings/i2c/i2c-axxia.txt     | 30 -----------
> >  .../devicetree/bindings/i2c/lsi,api2c.yaml    | 52 +++++++++++++++++++
> >  2 files changed, 52 insertions(+), 30 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-axxia.txt
> >  create mode 100644 Documentation/devicetree/bindings/i2c/lsi,api2c.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/i2c/i2c-axxia.txt b/Documentation/devicetree/bindings/i2c/i2c-axxia.txt
> > deleted file mode 100644
> > index 7d53a2b79553..000000000000
> > --- a/Documentation/devicetree/bindings/i2c/i2c-axxia.txt
> > +++ /dev/null
> > @@ -1,30 +0,0 @@
> > -LSI Axxia I2C
> > -
> > -Required properties :
> > -- compatible : Must be "lsi,api2c"
> > -- reg : Offset and length of the register set for the device
> > -- interrupts : the interrupt specifier
> > -- #address-cells : Must be <1>;
> > -- #size-cells : Must be <0>;
> > -- clock-names : Must contain "i2c".
> > -- clocks: Must contain an entry for each name in clock-names. See the common
> > -  clock bindings.
> > -
> > -Optional properties :
> > -- clock-frequency : Desired I2C bus clock frequency in Hz. If not specified,
> > -  the default 100 kHz frequency will be used. As only Normal and Fast modes
> > -  are supported, possible values are 100000 and 400000.
> > -
> > -Example :
> > -
> > -i2c@2010084000 {
> > -     compatible = "lsi,api2c";
> > -     device_type = "i2c";
> > -     #address-cells = <1>;
> > -     #size-cells = <0>;
> > -     reg = <0x20 0x10084000 0x00 0x1000>;
> > -     interrupts = <0 19 4>;
> > -     clocks = <&clk_per>;
> > -     clock-names = "i2c";
> > -     clock-frequency = <400000>;
> > -};
> > diff --git a/Documentation/devicetree/bindings/i2c/lsi,api2c.yaml b/Documentation/devicetree/bindings/i2c/lsi,api2c.yaml
> > new file mode 100644
> > index 000000000000..2d1c3069c3a3
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/i2c/lsi,api2c.yaml
> > @@ -0,0 +1,52 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/i2c/lsi,api2c.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: LSI Axxia I2C Controller
> > +
> > +maintainers:
> > +  - Anders Berg <anders.berg@lsi.com>
>
> I don't think lsi.com is valid any more. We'll see if it bounces.
> Otherwise,
>
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-06-06  6:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-05 10:08 [PATCH] dt-bindings: i2c: convert axxia i2c to dt-schema Chaitanya Sabnis
2026-05-07 19:29 ` Rob Herring
2026-06-06  6:30   ` Chaitanya Sabnis

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.