Re: [PATCH v1] perf record: Refactor ARM64 leaf caller setup out of arch

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Orphaned function declaration `arch__add_leaf_frame_record_opts` left in `tools/perf/util/callchain.h`.
--

commit 9201ab7426a557fd23fbb8e0f9c2a95f023a9477
Author: Ian Rogers <irogers@google.com>

    perf record: Refactor ARM64 leaf caller setup out of arch
    
    Code in tools/perf/arch causes portability issues/opaqueness and LTO
    issues due to the use of weak symbols. Move the adding of LR to the
    sample_user_regs into arm64-frame-pointer-unwind-support.c conditional
    on EM_HOST == EM_AARCH64.

> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> index 4a5eba498c025..272bba7f4b9ec 100644
> --- a/tools/perf/builtin-record.c
> +++ b/tools/perf/builtin-record.c

[ ... ]

> @@ -3230,10 +3231,6 @@ static int record__parse_off_cpu_thresh(const struct option *opt,
>  	return 0;
>  }
>  
> -void __weak arch__add_leaf_frame_record_opts(struct record_opts *opts __maybe_unused)
> -{
> -}
> -

Since the weak definition and usage of arch__add_leaf_frame_record_opts()
are removed in this commit, should its declaration in
tools/perf/util/callchain.h also be removed to avoid leaving an orphaned
function declaration?

tools/perf/util/callchain.h:

[ ... ]
#endif
 
void arch__add_leaf_frame_record_opts(struct record_opts *opts);
 
char *callchain_list__sym_name(struct callchain_list *cl,
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260507170622.611933-1-irogers@google.com?part=1