From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: james.clark@linaro.org, namhyung@kernel.org,
adrian.hunter@intel.com, alexander.shishkin@linux.intel.com,
dapeng1.mi@linux.intel.com, john.g.garry@oracle.com,
jolsa@kernel.org, leo.yan@linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
mark.rutland@arm.com, mike.leach@arm.com, mingo@redhat.com,
peterz@infradead.org, shimin.guo@skydio.com, will@kernel.org
Subject: Re: [PATCH v2] perf record: Refactor ARM64 leaf caller setup out of arch
Date: Thu, 14 May 2026 20:49:52 -0300 [thread overview]
Message-ID: <agZfoDoXEVjF7fBK@x1> (raw)
In-Reply-To: <CAP-5=fU7Y5b2KERuYJuKBK0nqD6GAo_r_QhxesbVw6T3bqrgQQ@mail.gmail.com>
On Thu, May 14, 2026 at 10:38:07AM -0700, Ian Rogers wrote:
> On Mon, May 11, 2026 at 10:41 PM Ian Rogers <irogers@google.com> wrote:
> >
> > Code in tools/perf/arch causes portability issues/opaqueness and LTO
> > issues due to the use of weak symbols. Move the adding of LR to the
> > sample_user_regs into arm64-frame-pointer-unwind-support.c conditional
> > on EM_HOST == EM_AARCH64 (false on all non-ARM64 builds). This also
> > better encapsulates the use of the sampled registers by
> > get_leaf_frame_caller_aarch64 and the set up by the new
> > add_leaf_frame_caller_opts_aarch64, exposing opportunities for
> > possibly sampling PC and SP to help the unwinder.
> >
> > Reviewed-by: James Clark <james.clark@linaro.org>
> > Signed-off-by: Ian Rogers <irogers@google.com>
>
> Ping.
Thanks, applied to perf-tools-next, for v7.2.
- Arnaldo
prev parent reply other threads:[~2026-05-14 23:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 17:06 [PATCH v1] perf record: Refactor ARM64 leaf caller setup out of arch Ian Rogers
2026-05-07 23:16 ` sashiko-bot
2026-05-08 10:35 ` James Clark
2026-05-12 5:41 ` [PATCH v2] " Ian Rogers
2026-05-14 17:38 ` Ian Rogers
2026-05-14 23:49 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agZfoDoXEVjF7fBK@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=dapeng1.mi@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=leo.yan@linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=shimin.guo@skydio.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.