Re: [PATCH 02/18] X.509: Make certificate parser public

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message claims to adjust the `#include <linux/time.h>` directive to `#include <linux/time64.h>`, but the patch fails to do so.
--

commit b079c32d2fd414877e2d8a8b3e079a1f6c2dc220
Author: Lukas Wunner <lukas@wunner.de>

X.509: Make certificate parser public

This commit makes struct x509_certificate and its associated parsing functions
public to allow CMA-SPDM access to the Subject Alternative Name. It moves
these definitions from the private x509_parser.h to a new public header.

>     The private header file x509_parser.h previously included <linux/time.h>
>     for the definition of time64_t.  That definition was since moved to
>     <linux/time64.h> by commit 361a3bf00582 ("time64: Add time64.h header
>     and define struct timespec64"), so adjust the #include directive as part
>     of the move to the new public header file <keys/x509-parser.h>.

[ ... ]

> diff --git a/include/keys/x509-parser.h b/include/keys/x509-parser.h
> new file mode 100644
> index 0000000000000..8b68e720693a6
> --- /dev/null
> +++ b/include/keys/x509-parser.h
> @@ -0,0 +1,55 @@
> +/* SPDX-License-Identifier: GPL-2.0-or-later */
> +/* X.509 certificate parser
> + *
> + * Copyright (C) 2012 Red Hat, Inc. All Rights Reserved.
> + * Written by David Howells (dhowells@redhat.com)
> + */
> +
> +#ifndef _KEYS_X509_PARSER_H
> +#define _KEYS_X509_PARSER_H
> +
> +#include <linux/cleanup.h>
> +#include <linux/time.h>

Does this include directive match the intention stated in the commit message?

The commit message mentions adjusting the include to <linux/time64.h>, but it
appears this still includes <linux/time.h>.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260508031710.514574-1-alistair.francis@wdc.com?part=2