Re: [PATCH 06/18] rust: error: impl From<FromBytesWithNulError> for Kernel Error

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added import `use core::ffi::FromBytesWithNulError;` does not follow the required kernel vertical import style.
--

commit 125b12ec12dfbbb7b1bcebfd39f627c83e1aa2f3
Author: Alistair Francis <alistair.francis@wdc.com>

rust: error: impl From<FromBytesWithNulError> for Kernel Error

Implement From<FromBytesWithNulError> for the Kernel Error type.

> diff --git a/rust/kernel/error.rs b/rust/kernel/error.rs
> index 05cf869ac0908..5463addbfd957 100644
> --- a/rust/kernel/error.rs
> +++ b/rust/kernel/error.rs
> @@ -12,6 +12,7 @@
>      str::CStr,
>  };
>  
> +use core::ffi::FromBytesWithNulError;
>  use core::num::NonZeroI32;
>  use core::num::TryFromIntError;
>  use core::str::Utf8Error;

This isn't a bug, but should this newly added import follow the kernel
vertical import style documented in the general coding guidelines?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260508031710.514574-1-alistair.francis@wdc.com?part=6