Re: Increase in XFS journal flushes with (direct_write;fdatasync)+

[Christoph Hellwig <hch@lst.de>]

On Fri, May 08, 2026 at 10:29:38AM +0200, Pankaj Raghav wrote:
>                 } else {
> -                       if (inode_maybe_inc_iversion(inode, !!dirty))
> +                       /*
> +                        * Don't force iversion increment for pure lazytime
> +                        * updates (when dirty is set to I_DIRTY_TIME only).
> +                        */
> +                       if (inode_maybe_inc_iversion(inode,
> +                                                    dirty != I_DIRTY_TIME))
>                                 dirty |= I_DIRTY_SYNC;
>                 }
>         }
> 
> If you are tests are passing, then I can send a fix as a separate patch.

The comment needs to explain the why and not the how.   AFAICS the
why is that lazytime is not propagated to the disk at this mount,
so incrementing i_version should not happen, but I'm adding Jeff
for insights.

> 
> --
> Pankaj
> 
---end quoted text---