From: Pankaj Raghav <pankaj.raghav@linux.dev>
To: Christoph Hellwig <hch@lst.de>
Cc: Jeff Layton <jlayton@kernel.org>,
Andres Freund <andres@anarazel.de>,
linux-xfs@vger.kernel.org, Carlos Maiolino <cem@kernel.org>,
Christian Brauner <brauner@kernel.org>,
gost.dev@samsung.com, p.raghav@samsung.com
Subject: Re: Increase in XFS journal flushes with (direct_write;fdatasync)+
Date: Mon, 11 May 2026 12:31:28 +0200 [thread overview]
Message-ID: <6ace1bbe-be82-427d-8fa4-0eafe6b821d5@linux.dev> (raw)
In-Reply-To: <20260511085645.GA1186@lst.de>
On 5/11/26 10:56, Christoph Hellwig wrote:
> On Fri, May 08, 2026 at 01:47:58PM +0200, Pankaj Raghav wrote:
>> - if (inode_maybe_inc_iversion(inode, !!dirty))
>> + /*
>> + * Don't force iversion increment for pure lazytime
>> + * updates (I_DIRTY_TIME only), let I_VERSION_QUERIED
>> + * dictate whether the increment is needed.
>> + */
>> + if (inode_maybe_inc_iversion(inode,
>> + dirty != I_DIRTY_TIME))
>
> Looks good, thanks!
Perfect. I will send a separate patch with the Fixes tag in it.
--
Pankaj
next prev parent reply other threads:[~2026-05-11 10:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <IS8F8EYS5pW4UU5a3jxOTy-f18EgkDa_2zAUswRgTm6NVtvmajAaQyu9CDxkTelDnfXfCl7L_692C77zRAxwFQ==@protonmail.internalid>
2026-05-06 13:26 ` Increase in XFS journal flushes with (direct_write;fdatasync)+ Andres Freund
2026-05-06 15:05 ` Carlos Maiolino
2026-05-07 20:34 ` Pankaj Raghav (Samsung)
2026-05-08 8:10 ` Christoph Hellwig
2026-05-08 8:29 ` Pankaj Raghav
2026-05-08 8:43 ` Christoph Hellwig
2026-05-08 11:42 ` Jeff Layton
2026-05-08 11:47 ` Pankaj Raghav
2026-05-11 8:56 ` Christoph Hellwig
2026-05-11 10:31 ` Pankaj Raghav [this message]
2026-05-12 5:25 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ace1bbe-be82-427d-8fa4-0eafe6b821d5@linux.dev \
--to=pankaj.raghav@linux.dev \
--cc=andres@anarazel.de \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=gost.dev@samsung.com \
--cc=hch@lst.de \
--cc=jlayton@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=p.raghav@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.