From: Simon Horman <horms@kernel.org>
To: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,
netdev@vger.kernel.org, Jacob Keller <jacob.e.keller@intel.com>
Subject: Re: [PATCH iwl-next 1/8] ixgbe: rename numa_node to node in struct ixgbe_q_vector
Date: Mon, 11 May 2026 16:27:24 +0100 [thread overview]
Message-ID: <20260511152724.GA27589@horms.kernel.org> (raw)
In-Reply-To: <20260508031226.3601800-2-aleksandr.loktionov@intel.com>
On Fri, May 08, 2026 at 05:12:19AM +0200, Aleksandr Loktionov wrote:
> From: Jacob Keller <jacob.e.keller@intel.com>
>
> The 'numa_node' field in struct ixgbe_q_vector shadows the 'numa_node'
> accessor for struct device, which triggers a sparse warning about
> shadowing a built-in object. The stored value here is a plain NUMA
> node number, not a device attribute, so rename it to 'node' to avoid
> the shadow and keep the naming consistent with other Intel drivers.
>
> Update all three usage sites in ixgbe_lib.c and ixgbe_main.c.
>
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,
netdev@vger.kernel.org, Jacob Keller <jacob.e.keller@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next 1/8] ixgbe: rename numa_node to node in struct ixgbe_q_vector
Date: Mon, 11 May 2026 16:27:24 +0100 [thread overview]
Message-ID: <20260511152724.GA27589@horms.kernel.org> (raw)
In-Reply-To: <20260508031226.3601800-2-aleksandr.loktionov@intel.com>
On Fri, May 08, 2026 at 05:12:19AM +0200, Aleksandr Loktionov wrote:
> From: Jacob Keller <jacob.e.keller@intel.com>
>
> The 'numa_node' field in struct ixgbe_q_vector shadows the 'numa_node'
> accessor for struct device, which triggers a sparse warning about
> shadowing a built-in object. The stored value here is a plain NUMA
> node number, not a device attribute, so rename it to 'node' to avoid
> the shadow and keep the naming consistent with other Intel drivers.
>
> Update all three usage sites in ixgbe_lib.c and ixgbe_main.c.
>
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2026-05-11 15:27 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 3:12 [Intel-wired-lan] [PATCH iwl-next 0/8] ixgbe: small cleanups and improvements Aleksandr Loktionov
2026-05-08 3:12 ` Aleksandr Loktionov
2026-05-08 3:12 ` [Intel-wired-lan] [PATCH iwl-next 1/8] ixgbe: rename numa_node to node in struct ixgbe_q_vector Aleksandr Loktionov
2026-05-08 3:12 ` Aleksandr Loktionov
2026-05-11 15:27 ` Simon Horman [this message]
2026-05-11 15:27 ` [Intel-wired-lan] " Simon Horman
2026-05-08 3:12 ` [Intel-wired-lan] [PATCH iwl-next 2/8] ixgbe: use int instead of u32 for error code variables Aleksandr Loktionov
2026-05-08 3:12 ` Aleksandr Loktionov
2026-05-08 4:15 ` [Intel-wired-lan] " Przemek Kitszel
2026-05-08 4:15 ` Przemek Kitszel
2026-05-08 3:12 ` [Intel-wired-lan] [PATCH iwl-next 3/8] ixgbe: prevent adding duplicate FDIR perfect filter rules Aleksandr Loktionov
2026-05-08 3:12 ` Aleksandr Loktionov
2026-05-08 4:44 ` [Intel-wired-lan] " Przemek Kitszel
2026-05-08 4:44 ` Przemek Kitszel
2026-05-08 3:12 ` [Intel-wired-lan] [PATCH iwl-next 4/8] ixgbe: increase SECRX_RDY polling frequency in ixgbe_disable_rx_buff_generic Aleksandr Loktionov
2026-05-08 3:12 ` Aleksandr Loktionov
2026-05-11 15:30 ` Simon Horman
2026-05-11 15:30 ` [Intel-wired-lan] " Simon Horman
2026-05-08 3:12 ` [Intel-wired-lan] [PATCH iwl-next 5/8] ixgbe: use ktime_get_real_ns() in ixgbe_ptp_reset() Aleksandr Loktionov
2026-05-08 3:12 ` Aleksandr Loktionov
2026-05-08 3:12 ` [Intel-wired-lan] [PATCH iwl-next 6/8] ixgbe: extract ixgbe_restart_auto_neg() to avoid code duplication Aleksandr Loktionov
2026-05-08 3:12 ` Aleksandr Loktionov
2026-05-11 15:40 ` Simon Horman
2026-05-11 15:40 ` [Intel-wired-lan] " Simon Horman
2026-05-12 13:42 ` Loktionov, Aleksandr
2026-05-12 13:42 ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-05-13 12:13 ` Simon Horman
2026-05-13 12:13 ` [Intel-wired-lan] " Simon Horman
2026-05-08 3:12 ` [Intel-wired-lan] [PATCH iwl-next 7/8] ixgbe: limit ITR decrease in latency mode to prevent ACK overdrive Aleksandr Loktionov
2026-05-08 3:12 ` Aleksandr Loktionov
2026-05-11 15:47 ` Simon Horman
2026-05-11 15:47 ` [Intel-wired-lan] " Simon Horman
2026-05-08 3:12 ` [Intel-wired-lan] [PATCH iwl-next 8/8] ixgbe: add IXGBE_ITR_ADAPTIVE_MASK_USECS constant Aleksandr Loktionov
2026-05-08 3:12 ` Aleksandr Loktionov
2026-05-11 15:52 ` Simon Horman
2026-05-11 15:52 ` [Intel-wired-lan] " Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260511152724.GA27589@horms.kernel.org \
--to=horms@kernel.org \
--cc=aleksandr.loktionov@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.