[PATCH] arm64: dts: qcom: ipq5210: add watchdog node

[PATCH] arm64: dts: qcom: ipq5210: add watchdog node

[Kathiravan Thirumoorthy]

Add the watchdog device node for IPQ5210 SoC.

Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/ipq5210.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/ipq5210.dtsi b/arch/arm64/boot/dts/qcom/ipq5210.dtsi
index 3761eb03ab24..2cdc10529c48 100644
--- a/arch/arm64/boot/dts/qcom/ipq5210.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq5210.dtsi
@@ -236,6 +236,13 @@ v2m2: v2m@2000 {
 			};
 		};
 
+		watchdog@b017000 {
+			compatible = "qcom,apss-wdt-ipq5210", "qcom,kpss-wdt";
+			reg = <0x0 0x0b017000 0x0 0x1000>;
+			interrupts = <GIC_SPI 277 IRQ_TYPE_EDGE_RISING>;
+			clocks = <&sleep_clk>;
+		};
+
 		timer@b120000 {
 			compatible = "arm,armv7-timer-mem";
 			reg = <0x0 0x0b120000 0x0 0x1000>;

---
base-commit: e98d21c170b01ddef366f023bbfcf6b31509fa83
change-id: 20260511-ipq5210_wdt-6544eac908e0
prerequisite-change-id: 20260511-ipq5210_wdt_binding-9f77d959a28b:v1
prerequisite-patch-id: bc56c2cdb782ff7ff58f9f4ab886ad5d8ef146ac

Best regards,
--  
Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>

Re: [PATCH] arm64: dts: qcom: ipq5210: add watchdog node

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The new compatible string `qcom,apss-wdt-ipq5210` is not documented in the YAML device tree bindings.
--

commit b8d52e9b8c29f20f20c1b99e740ee76b20c2506c
Author: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>

arm64: dts: qcom: ipq5210: add watchdog node

This commit adds the watchdog device node for the IPQ5210 SoC to the device
tree.

> diff --git a/arch/arm64/boot/dts/qcom/ipq5210.dtsi b/arch/arm64/boot/dts/qcom/ipq5210.dtsi
> index 3761eb03ab246..2cdc10529c489 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5210.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5210.dtsi
[ ... ]
> +		watchdog@b017000 {
> +			compatible = "qcom,apss-wdt-ipq5210", "qcom,kpss-wdt";

This isn't a bug, but is the "qcom,apss-wdt-ipq5210" compatible string
documented in the YAML bindings? 

It doesn't appear to be added to the allowed enum list in
Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml.

Would this omission result in a warning when running make dtbs_check?

> +			reg = <0x0 0x0b017000 0x0 0x1000>;
> +			interrupts = <GIC_SPI 277 IRQ_TYPE_EDGE_RISING>;
> +			clocks = <&sleep_clk>;
> +		};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260511-ipq5210_wdt-v1-1-870c4b7f77b6@oss.qualcomm.com?part=1

Re: [PATCH] arm64: dts: qcom: ipq5210: add watchdog node

[Konrad Dybcio]

On 5/11/26 12:56 PM, Kathiravan Thirumoorthy wrote:
> Add the watchdog device node for IPQ5210 SoC.
> 
> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/ipq5210.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq5210.dtsi b/arch/arm64/boot/dts/qcom/ipq5210.dtsi
> index 3761eb03ab24..2cdc10529c48 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5210.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5210.dtsi
> @@ -236,6 +236,13 @@ v2m2: v2m@2000 {
>  			};
>  		};
>  
> +		watchdog@b017000 {
> +			compatible = "qcom,apss-wdt-ipq5210", "qcom,kpss-wdt";
> +			reg = <0x0 0x0b017000 0x0 0x1000>;
> +			interrupts = <GIC_SPI 277 IRQ_TYPE_EDGE_RISING>;

Are you sure about the interrupt no?

Konrad

Re: [PATCH] arm64: dts: qcom: ipq5210: add watchdog node

[Kathiravan Thirumoorthy]

On 5/15/2026 4:20 PM, Konrad Dybcio wrote:
> On 5/11/26 12:56 PM, Kathiravan Thirumoorthy wrote:
>> Add the watchdog device node for IPQ5210 SoC.
>>
>> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
>> ---
>>   arch/arm64/boot/dts/qcom/ipq5210.dtsi | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/ipq5210.dtsi b/arch/arm64/boot/dts/qcom/ipq5210.dtsi
>> index 3761eb03ab24..2cdc10529c48 100644
>> --- a/arch/arm64/boot/dts/qcom/ipq5210.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/ipq5210.dtsi
>> @@ -236,6 +236,13 @@ v2m2: v2m@2000 {
>>   			};
>>   		};
>>   
>> +		watchdog@b017000 {
>> +			compatible = "qcom,apss-wdt-ipq5210", "qcom,kpss-wdt";
>> +			reg = <0x0 0x0b017000 0x0 0x1000>;
>> +			interrupts = <GIC_SPI 277 IRQ_TYPE_EDGE_RISING>;
> Are you sure about the interrupt no?

Yes. If you are referring to HW doc, it is incorrect. We are working 
with the HW folks to update it.

>
> Konrad

Re: [PATCH] arm64: dts: qcom: ipq5210: add watchdog node

[Konrad Dybcio]

On 5/15/26 12:53 PM, Kathiravan Thirumoorthy wrote:
> 
> On 5/15/2026 4:20 PM, Konrad Dybcio wrote:
>> On 5/11/26 12:56 PM, Kathiravan Thirumoorthy wrote:
>>> Add the watchdog device node for IPQ5210 SoC.
>>>
>>> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
>>> ---
>>>   arch/arm64/boot/dts/qcom/ipq5210.dtsi | 7 +++++++
>>>   1 file changed, 7 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/ipq5210.dtsi b/arch/arm64/boot/dts/qcom/ipq5210.dtsi
>>> index 3761eb03ab24..2cdc10529c48 100644
>>> --- a/arch/arm64/boot/dts/qcom/ipq5210.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/ipq5210.dtsi
>>> @@ -236,6 +236,13 @@ v2m2: v2m@2000 {
>>>               };
>>>           };
>>>   +        watchdog@b017000 {
>>> +            compatible = "qcom,apss-wdt-ipq5210", "qcom,kpss-wdt";
>>> +            reg = <0x0 0x0b017000 0x0 0x1000>;
>>> +            interrupts = <GIC_SPI 277 IRQ_TYPE_EDGE_RISING>;
>> Are you sure about the interrupt no?
> 
> Yes. If you are referring to HW doc, it is incorrect. We are working with the HW folks to update it.

OK thanks

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Re: [PATCH] arm64: dts: qcom: ipq5210: add watchdog node

[Bjorn Andersson]

On Mon, 11 May 2026 16:26:41 +0530, Kathiravan Thirumoorthy wrote:
> Add the watchdog device node for IPQ5210 SoC.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: ipq5210: add watchdog node
      commit: 7a473107f9785700a5c57cee69f60c19a9703f95

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>