From: Frank Li <Frank.Li@nxp.com>
To: Linus Walleij <linusw@kernel.org>,
linux-gpio@vger.kernel.org (open list:PIN CONTROL SUBSYSTEM),
linux-kernel@vger.kernel.org (open list)
Cc: imx@lists.linux.dev, Frank Li <Frank.Li@nxp.com>,
kernel test robot <lkp@intel.com>
Subject: [PATCH 1/1] pinctrl: Add OF dependency for PINCTRL_GENERIC_MUX
Date: Tue, 12 May 2026 10:48:05 -0400 [thread overview]
Message-ID: <20260512144806.22447-1-Frank.Li@nxp.com> (raw)
Add an explicit OF dependency for PINCTRL_GENERIC_MUX to ensure the
generic mux support is only enabled when device tree is available.
Also fix the stub implementation of pinctrl_generic_to_map() by correcting
its last argument to match the non-stub prototype.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202604072013.aI84l57L-lkp@intel.com/
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Linus Walleij:
I am sorry for missed a previous fixes patch
(https://lore.kernel.org/imx/20260408050702.2454661-1-Frank.Li@nxp.com/)
when rebase since it is located another fixes tree.
Frank
---
drivers/pinctrl/Kconfig | 1 +
drivers/pinctrl/pinconf.h | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 31d698fbaa01d..f4ffe1f3b720f 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -275,6 +275,7 @@ config PINCTRL_GEMINI
config PINCTRL_GENERIC_MUX
tristate "Generic Pinctrl driver by using multiplexer"
depends on MULTIPLEXER
+ depends on OF
select PINMUX
select GENERIC_PINCTRL
help
diff --git a/drivers/pinctrl/pinconf.h b/drivers/pinctrl/pinconf.h
index fa8fb0d290d1d..9711d16c38b62 100644
--- a/drivers/pinctrl/pinconf.h
+++ b/drivers/pinctrl/pinconf.h
@@ -195,7 +195,7 @@ pinctrl_generic_to_map(struct pinctrl_dev *pctldev, struct device_node *parent,
unsigned int *num_maps, unsigned int *num_reserved_maps,
const char **group_name, unsigned int ngroups,
const char **functions, unsigned int *pins,
- void *function_data)
+ unsigned int npins)
{
return -ENOTSUPP;
}
--
2.43.0
next reply other threads:[~2026-05-12 14:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 14:48 Frank Li [this message]
2026-05-14 21:27 ` [PATCH 1/1] pinctrl: Add OF dependency for PINCTRL_GENERIC_MUX Conor Dooley
-- strict thread matches above, loose matches on Subject: below --
2026-04-08 5:07 Frank Li
2026-04-08 7:53 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260512144806.22447-1-Frank.Li@nxp.com \
--to=frank.li@nxp.com \
--cc=imx@lists.linux.dev \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.