Re: [PATCH 1/1] pinctrl: Add OF dependency for PINCTRL_GENERIC_MUX

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2249 bytes --]

On Tue, May 12, 2026 at 10:48:05AM -0400, Frank Li wrote:
> Add an explicit OF dependency for PINCTRL_GENERIC_MUX to ensure the
> generic mux support is only enabled when device tree is available.
> 
> Also fix the stub implementation of pinctrl_generic_to_map() by correcting
> its last argument to match the non-stub prototype.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202604072013.aI84l57L-lkp@intel.com/
> Signed-off-by: Frank Li <Frank.Li@nxp.com>

Having been baited into sending a fix for the incorrect signature cos
the commit message here suggested that this was a dependency fix for
just the driver, I think this should be split into two patches,
especially since the commits fixed by each hunk here are different.

Additionally, looks like you're also missing fixes tags.

Cheers,
Conor.

> ---
> Linus Walleij:
> 	I am sorry for missed a previous fixes patch
> (https://lore.kernel.org/imx/20260408050702.2454661-1-Frank.Li@nxp.com/)
> when rebase since it is located another fixes tree.
> 
> Frank
> ---
>  drivers/pinctrl/Kconfig   | 1 +
>  drivers/pinctrl/pinconf.h | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index 31d698fbaa01d..f4ffe1f3b720f 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -275,6 +275,7 @@ config PINCTRL_GEMINI
>  config PINCTRL_GENERIC_MUX
>  	tristate "Generic Pinctrl driver by using multiplexer"
>  	depends on MULTIPLEXER
> +	depends on OF
>  	select PINMUX
>  	select GENERIC_PINCTRL
>  	help
> diff --git a/drivers/pinctrl/pinconf.h b/drivers/pinctrl/pinconf.h
> index fa8fb0d290d1d..9711d16c38b62 100644
> --- a/drivers/pinctrl/pinconf.h
> +++ b/drivers/pinctrl/pinconf.h
> @@ -195,7 +195,7 @@ pinctrl_generic_to_map(struct pinctrl_dev *pctldev, struct device_node *parent,
>  		       unsigned int *num_maps, unsigned int *num_reserved_maps,
>  		       const char **group_name, unsigned int ngroups,
>  		       const char **functions, unsigned int *pins,
> -		       void *function_data)
> +		       unsigned int npins)
>  {
>  	return -ENOTSUPP;
>  }
> -- 
> 2.43.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]