[PATCH 1/3] target/sh4: Re-allow unaligned access on system emulation

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

The change 0 -> MO_ALIGN in commit eb978e50e42 ("target/sh4: Use
MO_ALIGN for system UNALIGN()") would have been correct if it was
merged before commit 1fceff9c3ca ("tcg: Remove TARGET_ALIGNED_ONLY")
which defined MO_UNALN -> 0. What we really want here now is
MO_UNALN (MO_ALIGN is dealt with in commit 03a0d87e8dd "target/sh4:
Use MO_ALIGN where required").

Use the correct definition, otherwise we get when booting Linux:

  ok 14 bitfields
      KTAP version 1
      # Subtest: blackholedev
      # module: blackhole_dev_kunit
      1..1
  delay-slot-insn faulting in handle_unaligned_delayslot: 0000 [#1]
  Modules linked in:
  CPU: 0 UID: 0 PID: 298 Comm: kunit_try_catch Tainted: G                 N
  6.17.0-12907-g8765f467912f #1 NONE
  Tainted: [N]=TEST
  PC is at test_blackholedev+0xc6/0x1c8
  PR is at test_blackholedev+0xca/0x1c8
  PC  : 8c228d16 SP  : 8d40bed0 SR  : 40008001 TEA : 8cce4026
  R0  : 00000000 R1  : 00000000 R2  : 000000d2 R3  : 8cc77b80
  R4  : 8cc77b40 R5  : 0000000e R6  : 8c228cea R7  : 8cce400e
  R8  : 8cc77b40 R9  : 8cc77bbc R10 : 8cc77bbe R11 : 8c4b46b0
  R12 : 8c78310c R13 : 8cc29cf4 R14 : 8c6e3a88
  MACH: 0000d80d MACL: e554cb0f GBR : 00000000 PR  : 8c228d1a
  Call trace:
   [<8c05b378>] pick_next_task_fair+0x94/0x164
   [<8c5c2bce>] __schedule+0x306/0x6ec
   [<8c21fa68>] kunit_try_run_case+0x58/0x174
  ...

Cc: qemu-stable@nongnu.org
Fixes: eb978e50e42 ("target/sh4: Use MO_ALIGN for system UNALIGN()")
Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 target/sh4/translate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/sh4/translate.c b/target/sh4/translate.c
index 5adf650744c..3ddd4f612e4 100644
--- a/target/sh4/translate.c
+++ b/target/sh4/translate.c
@@ -54,7 +54,7 @@ typedef struct DisasContext {
 #define UNALIGN(C)   (ctx->tbflags & TB_FLAG_UNALIGN ? MO_UNALN : MO_ALIGN)
 #else
 #define IS_USER(ctx) (!(ctx->tbflags & (1u << SR_MD)))
-#define UNALIGN(C)   MO_ALIGN
+#define UNALIGN(C)   MO_UNALN
 #endif
 
 /* Target-specific values for ctx->base.is_jmp.  */
-- 
2.53.0