Re: [PATCH v2 3/3] sched/fair: Add compile time check in fastpaths for CONFIG_SCHED_SMT=n

[Phil Auld <pauld@redhat.com>]

On Wed, May 13, 2026 at 09:45:53AM +0530 Shrikanth Hegde wrote:
> Hi Phil.
> 
> On 5/12/26 10:29 PM, Phil Auld wrote:
> > Hi Shrikanth,
> > 
> > On Tue, May 12, 2026 at 08:51:25PM +0530 Shrikanth Hegde wrote:
> > > For fastpaths such as wakeup, load balance even a minimal code additons
> > > can pop up. Add IS_ENABLED checks there to ensure there is no overhead.
> > 
> > "For fastpaths such as wakeup and load balance, even minimal code additions
> > can add up. Add IS_ENABLED() checks..."  ?
> > 
> 
> Ok.
> 
> > > 
> > > Other places are either have sched_smt_active() check or they are not in
> > 
> > s/are//
> 
> ok.
> 
> > 
> > "have a sched_smt_active_check()" or drop "check" ?
> > 
> > 
> 
> I was saying sched_smt_active() runtime gating is there for many fast paths where
> cpu_smt_mask is being referred or those code paths are not fast paths.
> 
> Let me re-word a bit.
>

I know what you were saying. I just wanted an article when I read it :)


Cheers,
Phil

> > Otherwise lgtm.
> > 
> > Reviewed-by: Phil Auld <pauld@redhat.com>
> > 
> > 
> > Cheers,
> > Phil
> > 
> Thanks for the review.
> 

--