* drivers/tty/amiserial.c:456 rs_startup() warn: missing error code 'retval'
@ 2026-01-14 15:51 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2026-01-14 15:51 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Josh Poimboeuf <jpoimboe@kernel.org>
CC: Peter Zijlstra <peterz@infradead.org>
Hi Josh,
FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: c537e12daeecaecdcd322c56a5f70659d2de7bde
commit: 845c09e4744f111eae894ad3b67a369bb43d50fb tty: amiserial: Fix namespace collision and startup() section placement with -ffunction-sections
date: 8 weeks ago
:::::: branch date: 10 hours ago
:::::: commit date: 8 weeks ago
config: m68k-randconfig-r072-20260114 (https://download.01.org/0day-ci/archive/20260114/202601142357.wl3rZxBW-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 8.5.0
smatch version: v0.5.0-8985-g2614ff1a
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202601142357.wl3rZxBW-lkp@intel.com/
New smatch warnings:
drivers/tty/amiserial.c:456 rs_startup() warn: missing error code 'retval'
Old smatch warnings:
drivers/tty/amiserial.c:343 check_modem_status() error: we previously assumed 'port->tty' could be null (see line 338)
drivers/tty/amiserial.c:687 change_speed() warn: inconsistent indenting
vim +/retval +456 drivers/tty/amiserial.c
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 425
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 426 /*
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 427 * -------------------------------------------------------------------
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 428 * Here ends the serial interrupt routines.
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 429 * -------------------------------------------------------------------
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 430 */
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 431
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 432 /*
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 433 * ---------------------------------------------------------------
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 434 * Low level utility subroutines for the serial driver: routines to
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 435 * figure out the appropriate timeout for an interrupt chain, routines
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 436 * to initialize and startup a serial port, and routines to shutdown a
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 437 * serial port. Useful stuff like that.
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 438 * ---------------------------------------------------------------
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 439 */
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 440
845c09e4744f11 drivers/tty/amiserial.c Josh Poimboeuf 2025-11-20 441 static int rs_startup(struct tty_struct *tty, struct serial_state *info)
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 442 {
01bd730d92bd00 drivers/tty/amiserial.c Jiri Slaby 2012-03-05 443 struct tty_port *port = &info->tport;
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 444 unsigned long flags;
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 445 int retval=0;
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 446 unsigned long page;
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 447
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 448 page = get_zeroed_page(GFP_KERNEL);
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 449 if (!page)
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 450 return -ENOMEM;
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 451
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 452 local_irq_save(flags);
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 453
d41861ca19c9e9 drivers/tty/amiserial.c Peter Hurley 2016-04-09 454 if (tty_port_initialized(port)) {
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 455 free_page(page);
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 @456 goto errout;
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 457 }
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 458
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 459 if (info->xmit.buf)
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 460 free_page(page);
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 461 else
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 462 info->xmit.buf = (unsigned char *) page;
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 463
:::::: The code at line 456 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
* drivers/tty/amiserial.c:456 rs_startup() warn: missing error code 'retval'
@ 2026-05-13 13:14 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2026-05-13 13:14 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Josh Poimboeuf <jpoimboe@kernel.org>
CC: Peter Zijlstra <peterz@infradead.org>
Hi Josh,
FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 1d5dcaa3bd65f2e8c9baa14a393d3a2dc5db7524
commit: 845c09e4744f111eae894ad3b67a369bb43d50fb tty: amiserial: Fix namespace collision and startup() section placement with -ffunction-sections
date: 6 months ago
:::::: branch date: 20 hours ago
:::::: commit date: 6 months ago
config: m68k-randconfig-r071-20260513 (https://download.01.org/0day-ci/archive/20260513/202605132134.mBpVmwOp-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 14.3.0
smatch: v0.5.0-9185-gbcc58b9c
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Fixes: 845c09e4744f ("tty: amiserial: Fix namespace collision and startup() section placement with -ffunction-sections")
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202605132134.mBpVmwOp-lkp@intel.com/
New smatch warnings:
drivers/tty/amiserial.c:456 rs_startup() warn: missing error code 'retval'
Old smatch warnings:
drivers/tty/amiserial.c:343 check_modem_status() error: we previously assumed 'port->tty' could be null (see line 338)
drivers/tty/amiserial.c:687 change_speed() warn: inconsistent indenting
vim +/retval +456 drivers/tty/amiserial.c
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 425
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 426 /*
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 427 * -------------------------------------------------------------------
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 428 * Here ends the serial interrupt routines.
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 429 * -------------------------------------------------------------------
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 430 */
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 431
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 432 /*
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 433 * ---------------------------------------------------------------
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 434 * Low level utility subroutines for the serial driver: routines to
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 435 * figure out the appropriate timeout for an interrupt chain, routines
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 436 * to initialize and startup a serial port, and routines to shutdown a
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 437 * serial port. Useful stuff like that.
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 438 * ---------------------------------------------------------------
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 439 */
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 440
845c09e4744f11 drivers/tty/amiserial.c Josh Poimboeuf 2025-11-20 441 static int rs_startup(struct tty_struct *tty, struct serial_state *info)
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 442 {
01bd730d92bd00 drivers/tty/amiserial.c Jiri Slaby 2012-03-05 443 struct tty_port *port = &info->tport;
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 444 unsigned long flags;
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 445 int retval=0;
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 446 unsigned long page;
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 447
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 448 page = get_zeroed_page(GFP_KERNEL);
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 449 if (!page)
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 450 return -ENOMEM;
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 451
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 452 local_irq_save(flags);
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 453
d41861ca19c9e9 drivers/tty/amiserial.c Peter Hurley 2016-04-09 454 if (tty_port_initialized(port)) {
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 455 free_page(page);
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 @456 goto errout;
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 457 }
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 458
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 459 if (info->xmit.buf)
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 460 free_page(page);
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 461 else
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 462 info->xmit.buf = (unsigned char *) page;
^1da177e4c3f41 drivers/char/amiserial.c Linus Torvalds 2005-04-16 463
:::::: The code at line 456 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-13 13:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-13 13:14 drivers/tty/amiserial.c:456 rs_startup() warn: missing error code 'retval' kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2026-01-14 15:51 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.