Re: [PATCH v2 01/22] dt-bindings: pincfg-node: Add property 'input-debounce-nanoseconds'

From: Conor Dooley <conor@kernel.org>
To: Changhuang Liang <changhuang.liang@starfivetech.com>
Cc: Linus Walleij <linusw@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Emil Renner Berthing <kernel@esmil.dk>,
	Paul Walmsley <pjw@kernel.org>, Albert Ou <aou@eecs.berkeley.edu>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Alexandre Ghiti <alex@ghiti.fr>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Bartosz Golaszewski <brgl@kernel.org>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
	Lianfeng Ouyang <lianfeng.ouyang@starfivetech.com>
Subject: Re: [PATCH v2 01/22] dt-bindings: pincfg-node: Add property 'input-debounce-nanoseconds'
Date: Thu, 14 May 2026 19:35:47 +0100	[thread overview]
Message-ID: <20260514-petted-onscreen-0e588a2d1023@spud> (raw)
In-Reply-To: <20260514111218.94519-2-changhuang.liang@starfivetech.com>

[-- Attachment #1: Type: text/plain, Size: 1824 bytes --]

On Thu, May 14, 2026 at 04:11:57AM -0700, Changhuang Liang wrote:
> Add the property 'input-debounce-nanoseconds' to specify debounce time
> in nanoseconds as an alternative to the existing 'input-debounce' which
> uses microseconds. Make the new property unavailable when the existing
> property 'input-debounce' is selected to prevent conflicting definitions.
> 
> Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
> ---
>  .../devicetree/bindings/pinctrl/pincfg-node.yaml     | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml b/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml
> index 97dbce8a261f..4db66cdf438c 100644
> --- a/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml
> @@ -104,6 +104,11 @@ properties:
>      description: Takes the debounce time in usec as argument or 0 to disable
>        debouncing
>  
> +  input-debounce-nanoseconds:

-ns is the standard suffix here, and if you use it you can drop the ref
below.
pw-bot: changes-requested

> +    $ref: /schemas/types.yaml#/definitions/uint32-array
> +    description: Takes the debounce time in nsec as argument or 0 to disable
> +      debouncing
> +
>    power-source:
>      $ref: /schemas/types.yaml#/definitions/uint32
>      description: select between different power supplies
> @@ -214,6 +219,13 @@ allOf:
>          input-schmitt-enable: false
>          input-schmitt-microvolt: false
>  
> +  - if:
> +      required:
> +        - input-debounce
> +    then:
> +      properties:
> +        input-debounce-nanoseconds: false
> +
>    - if:
>        required:
>          - drive-strength
> -- 
> 2.25.1
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]