From: Conor Dooley <conor@kernel.org>
To: Daire McNamara <daire.mcnamara@microchip.com>,
Pierre-Henry Moussay <pierre-henry.moussay@microchip.com>,
Felix Gu <ustc.gu@gmail.com>
Cc: conor@kernel.org, Conor Dooley <conor.dooley@microchip.com>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc: microchip: mpfs-sys-controller: fix resource leak on probe error
Date: Thu, 14 May 2026 21:04:12 +0100 [thread overview]
Message-ID: <20260514-shape-perfume-a98d4e53502e@spud> (raw)
In-Reply-To: <20260506-mpfs-v1-1-a690c45178c6@gmail.com>
From: Conor Dooley <conor.dooley@microchip.com>
On Wed, 06 May 2026 19:29:02 +0800, Felix Gu wrote:
> In mpfs_sys_controller_probe(), when device_get_match_data() returns
> NULL, it returns -EINVAL directly without freeing the mbox channel
> or the allocated sys_controller memory, causing a resource leak.
Applied to riscv-soc-fixes, thanks!
[1/1] soc: microchip: mpfs-sys-controller: fix resource leak on probe error
https://git.kernel.org/conor/c/75ef23397558
Thanks,
Conor.
WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org>
To: Daire McNamara <daire.mcnamara@microchip.com>,
Pierre-Henry Moussay <pierre-henry.moussay@microchip.com>,
Felix Gu <ustc.gu@gmail.com>
Cc: conor@kernel.org, Conor Dooley <conor.dooley@microchip.com>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc: microchip: mpfs-sys-controller: fix resource leak on probe error
Date: Thu, 14 May 2026 21:04:12 +0100 [thread overview]
Message-ID: <20260514-shape-perfume-a98d4e53502e@spud> (raw)
In-Reply-To: <20260506-mpfs-v1-1-a690c45178c6@gmail.com>
From: Conor Dooley <conor.dooley@microchip.com>
On Wed, 06 May 2026 19:29:02 +0800, Felix Gu wrote:
> In mpfs_sys_controller_probe(), when device_get_match_data() returns
> NULL, it returns -EINVAL directly without freeing the mbox channel
> or the allocated sys_controller memory, causing a resource leak.
Applied to riscv-soc-fixes, thanks!
[1/1] soc: microchip: mpfs-sys-controller: fix resource leak on probe error
https://git.kernel.org/conor/c/75ef23397558
Thanks,
Conor.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2026-05-14 20:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 11:29 [PATCH] soc: microchip: mpfs-sys-controller: fix resource leak on probe error Felix Gu
2026-05-06 11:29 ` Felix Gu
2026-05-14 20:04 ` Conor Dooley [this message]
2026-05-14 20:04 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260514-shape-perfume-a98d4e53502e@spud \
--to=conor@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=pierre-henry.moussay@microchip.com \
--cc=ustc.gu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.