Re: [PATCH v2 3/3] arm64: dts: amlogic: t7: khadas-vim4: add PWM-driven status LED

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The subnode for the LED under `pwm-leds` is named `status`, which violates the `leds-pwm` device tree binding schema.
--

commit fa7913b140af3e7d64c22b109d1765f504180ad0
Author: Ronald Claveau <linux-kernel-dev@aliel.fr>

arm64: dts: amlogic: t7: khadas-vim4: add PWM-driven status LED

This commit enables the pwm_ao_cd controller and adds a pwm-leds node with a
heartbeat trigger to expose the status LED on the VIM4 board.

> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts b/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts
> --- a/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts
> +++ b/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts
> @@ -53,6 +53,16 @@ dc_in: regulator-dc-in {
>  		regulator-always-on;
>  	};
>  
> +	pwm-leds {
> +		compatible = "pwm-leds";
> +
> +		status {

Does this subnode name trigger a device tree schema validation error?

The leds-pwm binding schema in
Documentation/devicetree/bindings/leds/leds-pwm.yaml specifies
additionalProperties: false and expects child node names to match the
regular expression ^led(-[0-9a-f]+)?$.

Using status as a node name is also confusing since it is commonly used as a
standard device tree property.

Should this be renamed to something like led-status or led-0 to comply with
the schema?

> +			linux,default-trigger="heartbeat";
> +			max-brightness = <255>;
> +			pwms = <&pwm_ao_cd 0 30040 0>;
> +		};
> +	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260513-add-kvim4-sysled-v2-0-3ec9779e8875@aliel.fr?part=3

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic