Re: [PATCH v2 15/16] arm64: dts: ti: k3-am62p-j722s-common-main: Add support for DSS

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `dss0_oldi1` device tree node is missing the mandatory `clocks`, `clock-names`, and `ti,oldi-io-ctrl` properties, leading to device tree schema validation failures.
--

commit 15bd859b1e4ef9aa0d15277777045451416f00b7
Author: Jayesh Choudhary <j-choudhary@ti.com>

arm64: dts: ti: k3-am62p-j722s-common-main: Add support for DSS

This commit adds device tree nodes for the Display Subsystem (DSS) and
associated hardware like OLDI, DPHY, and DSI for TI's AM62P and J722S SoCs.

> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
> index 5e8eb9f2fe243..576fa2f883648 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
[ ... ]
> @@ -1111,6 +1116,110 @@ dphy0: phy@30110000 {
[ ... ]
> +		oldi-transmitters {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			dss0_oldi0: oldi@0 {
> +				reg = <0>;
> +				clocks = <&k3_clks 186 0>;
> +				clock-names = "serial";
> +				ti,oldi-io-ctrl = <&dss_oldi_io_ctrl>;
> +				status = "disabled";
> +				power-domains = <&k3_pds 243 TI_SCI_PD_EXCLUSIVE>; /* OLDI0_VD */
> +			};
> +
> +			dss0_oldi1: oldi@1 {
> +				reg = <1>;
> +				status = "disabled";
> +				power-domains = <&k3_pds 244 TI_SCI_PD_EXCLUSIVE>; /* OLDI1_VD */
> +			};

Should dss0_oldi1 include the clocks, clock-names, and ti,oldi-io-ctrl
properties?

The ti,am625-oldi.yaml schema requires these properties for all oldi nodes.
While dss0_oldi0 and dss1_oldi1 specify them, they are missing here.

Would omitting these properties cause dtbs_check validation errors when a
board enables the node? Since this represents the same physical OLDI1 block
as dss1_oldi1, does it need the same physical clock and syscon connections
specified to pass validation and accurately describe the hardware?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260513-beagley-ai-display-v2-0-9e9bcefde6bc@ideasonboard.com?part=15