From: SeongJae Park <sj@kernel.org>
Cc: SeongJae Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Steven Rostedt <rostedt@goodmis.org>,
damon@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org
Subject: [RFC PATCH v2.1 18/28] mm/damon: trace probe_hits
Date: Thu, 14 May 2026 07:08:51 -0700 [thread overview]
Message-ID: <20260514140904.119781-19-sj@kernel.org> (raw)
In-Reply-To: <20260514140904.119781-1-sj@kernel.org>
Introduce a new tracepoint for exposing the per-region per-probe
positive sample count via tracefs.
Signed-off-by: SeongJae Park <sj@kernel.org>
---
include/trace/events/damon.h | 38 ++++++++++++++++++++++++++++++++++++
mm/damon/core.c | 9 +++++++++
2 files changed, 47 insertions(+)
diff --git a/include/trace/events/damon.h b/include/trace/events/damon.h
index 7e25f4469b81b..2b96a03876034 100644
--- a/include/trace/events/damon.h
+++ b/include/trace/events/damon.h
@@ -130,6 +130,44 @@ TRACE_EVENT(damon_monitor_intervals_tune,
TP_printk("sample_us=%lu", __entry->sample_us)
);
+TRACE_EVENT_CONDITION(damon_aggregated_v2,
+
+ TP_PROTO(unsigned int target_id, struct damon_region *r,
+ unsigned int nr_regions, unsigned int nr_probes),
+
+ TP_ARGS(target_id, r, nr_regions, nr_probes),
+
+ TP_CONDITION(nr_probes > 0),
+
+ TP_STRUCT__entry(
+ __field(unsigned long, target_id)
+ __field(unsigned long, start)
+ __field(unsigned long, end)
+ __field(unsigned int, nr_regions)
+ __field(unsigned int, nr_accesses)
+ __field(unsigned int, age)
+ __dynamic_array(unsigned char, probe_hits, nr_probes)
+ ),
+
+ TP_fast_assign(
+ __entry->target_id = target_id;
+ __entry->start = r->ar.start;
+ __entry->end = r->ar.end;
+ __entry->nr_regions = nr_regions;
+ __entry->nr_accesses = r->nr_accesses;
+ __entry->age = r->age;
+ memcpy(__get_dynamic_array(probe_hits), r->probe_hits,
+ sizeof(*r->probe_hits) * nr_probes);
+ ),
+
+ TP_printk("target_id=%lu nr_regions=%u %lu-%lu: %u %u probe_hits=%s",
+ __entry->target_id, __entry->nr_regions,
+ __entry->start, __entry->end,
+ __entry->nr_accesses, __entry->age,
+ __print_hex(__get_dynamic_array(probe_hits),
+ __get_dynamic_array_len(probe_hits)))
+);
+
TRACE_EVENT(damon_aggregated,
TP_PROTO(unsigned int target_id, struct damon_region *r,
diff --git a/mm/damon/core.c b/mm/damon/core.c
index fe6c789f2cecb..0ad1a0af06893 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -1905,6 +1905,13 @@ static void kdamond_reset_aggregated(struct damon_ctx *c)
{
struct damon_target *t;
unsigned int ti = 0; /* target's index */
+ unsigned int nr_probes = 0;
+ struct damon_probe *probe;
+
+ if (trace_damon_aggregated_v2_enabled()) {
+ damon_for_each_probe(probe, c)
+ nr_probes++;
+ }
damon_for_each_target(t, c) {
struct damon_region *r;
@@ -1913,6 +1920,8 @@ static void kdamond_reset_aggregated(struct damon_ctx *c)
int i;
trace_damon_aggregated(ti, r, damon_nr_regions(t));
+ trace_damon_aggregated_v2(ti, r, damon_nr_regions(t),
+ nr_probes);
damon_warn_fix_nr_accesses_corruption(r);
r->last_nr_accesses = r->nr_accesses;
r->nr_accesses = 0;
--
2.47.3
next prev parent reply other threads:[~2026-05-14 14:09 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 14:08 [RFC PATCH v2.1 00/28] mm/damon: introduce data attributes monitoring SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 01/28] mm/damon/core: introduce struct damon_probe SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 02/28] mm/damon/core: embed damon_probe objects in damon_ctx SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 03/28] mm/damon/core: introduce damon_filter SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 04/28] mm/damon/core: commit probes SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 05/28] mm/damon/core: introduce damon_region->probe_hits SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 06/28] mm/damon/core: introduce damon_ops->apply_probes SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 07/28] mm/damon/core: do data attributes monitoring SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 08/28] mm/damon/paddr: support " SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 09/28] mm/damon/sysfs: implement probes dir SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 10/28] mm/damon/sysfs: implement probe dir SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 11/28] mm/damon/sysfs: implement filters directory SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 12/28] mm/damon/sysfs: implement filter dir SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 13/28] mm/damon/sysfs: implement filter dir files SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 14/28] mm/damon/sysfs: setup probes on DAMON core API parameters SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 15/28] mm/damon/sysfs-schemes: implement tried_regions/<r>/probes/ SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 16/28] mm/damon/sysfs-schemes: implement probe dir SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 17/28] mm/damon/sysfs-schemes: implement probe/hits file SeongJae Park
2026-05-14 14:08 ` SeongJae Park [this message]
2026-05-14 14:08 ` [RFC PATCH v2.1 19/28] selftests/damon/sysfs.sh: test probes dir SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 20/28] Docs/mm/damon/design: document data attributes monitoring SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 21/28] Docs/admin-guide/mm/damon/usage: " SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 22/28] mm/damon/core: introduce DAMON_FILTER_TYPE_MEMCG SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 23/28] mm/damon/paddr: support DAMON_FILTER_TYPE_MEMCG SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 24/28] mm/damon/sysfs: add filters/<F>/path file SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 25/28] mm/damon/sysfs-schemes: move memcg_path_to_id() to sysfs-common SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 26/28] mm/damon/sysfs: setup damon_filter->memcg_id from path SeongJae Park
2026-05-14 14:09 ` [RFC PATCH v2.1 27/28] Docs/mm/damon/design: update for memcg damon filter SeongJae Park
2026-05-14 14:09 ` [RFC PATCH v2.1 28/28] Docs/admin-guide/mm/damon/usage: " SeongJae Park
2026-05-15 0:41 ` [RFC PATCH v2.1 00/28] mm/damon: introduce data attributes monitoring SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260514140904.119781-19-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.