From: SeongJae Park <sj@kernel.org>
Cc: SeongJae Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
damon@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: [RFC PATCH v2.1 05/28] mm/damon/core: introduce damon_region->probe_hits
Date: Thu, 14 May 2026 07:08:38 -0700 [thread overview]
Message-ID: <20260514140904.119781-6-sj@kernel.org> (raw)
In-Reply-To: <20260514140904.119781-1-sj@kernel.org>
Add an array for the per-region per-probe positive samples count. For
simple and efficient implementation, add a limit to the number of data
probes and set the array to support only the limited number of counters.
Signed-off-by: SeongJae Park <sj@kernel.org>
---
include/linux/damon.h | 4 ++++
mm/damon/core.c | 3 +++
2 files changed, 7 insertions(+)
diff --git a/include/linux/damon.h b/include/linux/damon.h
index 95b2c508a63ea..19b780bfab051 100644
--- a/include/linux/damon.h
+++ b/include/linux/damon.h
@@ -17,6 +17,8 @@
/* Minimal region size. Every damon_region is aligned by this. */
#define DAMON_MIN_REGION_SZ PAGE_SIZE
+/* Maximum number of monitoring probes. */
+#define DAMON_MAX_PROBES (4)
/* Max priority score for DAMON-based operation schemes */
#define DAMOS_MAX_SCORE (99)
@@ -47,6 +49,7 @@ struct damon_size_range {
* @nr_accesses: Access frequency of this region.
* @nr_accesses_bp: @nr_accesses in basis point (0.01%) that updated for
* each sampling interval.
+ * @probe_hits: Number of probe-positive region samples.
* @list: List head for siblings.
* @age: Age of this region.
*
@@ -75,6 +78,7 @@ struct damon_region {
unsigned long sampling_addr;
unsigned int nr_accesses;
unsigned int nr_accesses_bp;
+ unsigned char probe_hits[DAMON_MAX_PROBES];
struct list_head list;
unsigned int age;
diff --git a/mm/damon/core.c b/mm/damon/core.c
index 240cae1420c12..72acdeb8c478e 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -229,6 +229,7 @@ static void damon_verify_new_region(unsigned long start, unsigned long end)
struct damon_region *damon_new_region(unsigned long start, unsigned long end)
{
struct damon_region *region;
+ int i;
damon_verify_new_region(start, end);
region = kmem_cache_alloc(damon_region_cache, GFP_KERNEL);
@@ -239,6 +240,8 @@ struct damon_region *damon_new_region(unsigned long start, unsigned long end)
region->ar.end = end;
region->nr_accesses = 0;
region->nr_accesses_bp = 0;
+ for (i = 0; i < DAMON_MAX_PROBES; i++)
+ region->probe_hits[i] = 0;
INIT_LIST_HEAD(®ion->list);
region->age = 0;
--
2.47.3
next prev parent reply other threads:[~2026-05-14 14:09 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 14:08 [RFC PATCH v2.1 00/28] mm/damon: introduce data attributes monitoring SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 01/28] mm/damon/core: introduce struct damon_probe SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 02/28] mm/damon/core: embed damon_probe objects in damon_ctx SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 03/28] mm/damon/core: introduce damon_filter SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 04/28] mm/damon/core: commit probes SeongJae Park
2026-05-14 14:08 ` SeongJae Park [this message]
2026-05-14 14:08 ` [RFC PATCH v2.1 06/28] mm/damon/core: introduce damon_ops->apply_probes SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 07/28] mm/damon/core: do data attributes monitoring SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 08/28] mm/damon/paddr: support " SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 09/28] mm/damon/sysfs: implement probes dir SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 10/28] mm/damon/sysfs: implement probe dir SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 11/28] mm/damon/sysfs: implement filters directory SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 12/28] mm/damon/sysfs: implement filter dir SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 13/28] mm/damon/sysfs: implement filter dir files SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 14/28] mm/damon/sysfs: setup probes on DAMON core API parameters SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 15/28] mm/damon/sysfs-schemes: implement tried_regions/<r>/probes/ SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 16/28] mm/damon/sysfs-schemes: implement probe dir SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 17/28] mm/damon/sysfs-schemes: implement probe/hits file SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 18/28] mm/damon: trace probe_hits SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 19/28] selftests/damon/sysfs.sh: test probes dir SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 20/28] Docs/mm/damon/design: document data attributes monitoring SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 21/28] Docs/admin-guide/mm/damon/usage: " SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 22/28] mm/damon/core: introduce DAMON_FILTER_TYPE_MEMCG SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 23/28] mm/damon/paddr: support DAMON_FILTER_TYPE_MEMCG SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 24/28] mm/damon/sysfs: add filters/<F>/path file SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 25/28] mm/damon/sysfs-schemes: move memcg_path_to_id() to sysfs-common SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 26/28] mm/damon/sysfs: setup damon_filter->memcg_id from path SeongJae Park
2026-05-14 14:09 ` [RFC PATCH v2.1 27/28] Docs/mm/damon/design: update for memcg damon filter SeongJae Park
2026-05-14 14:09 ` [RFC PATCH v2.1 28/28] Docs/admin-guide/mm/damon/usage: " SeongJae Park
2026-05-15 0:41 ` [RFC PATCH v2.1 00/28] mm/damon: introduce data attributes monitoring SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260514140904.119781-6-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.