Re: [PATCH v2 2/7] iio: temperature: ltc2983: Use local device pointer consistently

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added 'dev' variable in `__ltc2983_chan_assign_common` is declared but never used, leading to compiler warnings.
--

commit cab83c99167bc9d0ae1294b92a3bded27d02aabf
Author: Liviu Stan <liviu.stan@analog.com>

iio: temperature: ltc2983: Use local device pointer consistently

This patch adds local dev pointers across various functions in the driver
to replace bare references to st->spi->dev.

> diff --git a/drivers/iio/temperature/ltc2983.c b/drivers/iio/temperature/ltc2983.c
> --- a/drivers/iio/temperature/ltc2983.c
> +++ b/drivers/iio/temperature/ltc2983.c
> @@ -351,6 +351,7 @@ static int __ltc2983_chan_assign_common(struct ltc2983_data *st,
>  					const struct ltc2983_sensor *sensor,
>  					u32 chan_val)
>  {
> +	struct device *dev = &st->spi->dev;
>  	u32 reg = LTC2983_CHAN_ASSIGN_ADDR(sensor->chan);
>  
>  	chan_val |= LTC2983_CHAN_TYPE(sensor->type);

Does this leave the newly added dev variable entirely unused?

It looks like the dev_dbg() call immediately following this still uses
&st->spi->dev instead of the local dev pointer.

This will cause an unused-variable compiler warning, which breaks builds
configured with W=1 or -Werror and can harm bisectability.

While this oversight is fixed later in the patch series in commit
7aff450fb9c7b5749766cff8040dd8d12bc74f0c, each patch must compile
cleanly and independently.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260514144712.64374-1-liviu.stan@analog.com?part=2