From: sashiko-bot@kernel.org
To: "Liviu Stan" <liviu.stan@analog.com>
Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org,
krzk+dt@kernel.org
Subject: Re: [PATCH v2 3/7] iio: temperature: ltc2983: Fix inconsistent channel wording in messages
Date: Thu, 14 May 2026 19:47:37 +0000 [thread overview]
Message-ID: <20260514194738.56B4DC2BCB3@smtp.kernel.org> (raw)
In-Reply-To: <20260514144712.64374-4-liviu.stan@analog.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incomplete refactoring / Commit message mismatch: The commit claims to replace all occurrences of 'chan' and 'chann' with 'channel' in error and debug messages, but misses several occurrences.
--
commit f3ba963d38e5d70969e64d92b33f465e108805e4
Author: Liviu Stan <liviu.stan@analog.com>
iio: temperature: ltc2983: Fix inconsistent channel wording in messages
This commit replaces abbreviations like 'chann' and 'chan' with 'channel'
in error and debug messages across the ltc2983 driver to improve
consistency.
> Replace all occurrences of the abbreviated 'chann' and 'chan' with
> 'channel' in error and debug messages throughout the driver.
This isn't a bug, but since the goal is to replace all occurrences,
should the following instances in ltc2983_parse_fw() also be updated?
drivers/iio/temperature/ltc2983.c:ltc2983_parse_fw() {
...
if (sensor.chan < LTC2983_MIN_CHANNELS_NR ||
sensor.chan > st->info->max_channels_nr)
return dev_err_probe(dev, -EINVAL,
"chan:%d must be from %u to %u\n",
...
if (channel_avail_mask & BIT(sensor.chan))
return dev_err_probe(dev, -EINVAL,
"chan:%d already in use\n",
...
dev_dbg(dev, "Create new sensor, type %u, chann %u",
...
}
It appears these were missed during the refactoring.
While the "chann %u" debug message is coincidentally updated in a later
commit ("iio: temperature: ltc2983: Add support for ADT7604"), the error
messages remain unfixed throughout the patch series.
Could these be updated here to ensure the code fully matches the commit
message?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260514144712.64374-1-liviu.stan@analog.com?part=3
next prev parent reply other threads:[~2026-05-14 19:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 14:46 [PATCH v2 0/7] iio: temperature: ltc2983: Add support for ADT7604 Liviu Stan
2026-05-14 14:46 ` [PATCH v2 1/7] iio: temperature: ltc2983: Fix macro parenthesization and rename Liviu Stan
2026-05-14 19:32 ` sashiko-bot
2026-05-14 14:46 ` [PATCH v2 2/7] iio: temperature: ltc2983: Use local device pointer consistently Liviu Stan
2026-05-14 19:39 ` sashiko-bot
2026-05-14 14:46 ` [PATCH v2 3/7] iio: temperature: ltc2983: Fix inconsistent channel wording in messages Liviu Stan
2026-05-14 19:47 ` sashiko-bot [this message]
2026-05-14 14:46 ` [PATCH v2 4/7] iio: temperature: ltc2983: Use fwnode_property_present() for optional properties Liviu Stan
2026-05-14 20:04 ` sashiko-bot
2026-05-14 14:46 ` [PATCH v2 5/7] iio: core: Add IIO_COVERAGE_PERCENT channel type Liviu Stan
2026-05-14 20:16 ` sashiko-bot
2026-05-15 8:38 ` Francesco Lavra
2026-05-15 9:01 ` Stan, Liviu
2026-05-14 14:46 ` [PATCH v2 6/7] dt-bindings: iio: temperature: Add ADT7604 support to adi,ltc2983 Liviu Stan
2026-05-14 20:43 ` sashiko-bot
2026-05-14 14:46 ` [PATCH v2 7/7] iio: temperature: ltc2983: Add support for ADT7604 Liviu Stan
2026-05-15 8:38 ` Francesco Lavra
2026-05-15 9:07 ` Stan, Liviu
2026-05-15 6:42 ` [PATCH v2 0/7] " Stan, Liviu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260514194738.56B4DC2BCB3@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=liviu.stan@analog.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.